Differential D1917 Diff 4585 src/plugins/runner/gdal/CMakeLists.txt

Changeset View

Standalone View

View Options

src/plugins/runner/gdal/CMakeLists.txt

  • This file was added.
1​PROJECT( GdalPlugin )
2​
3​INCLUDE_DIRECTORIES(
4​ ${CMAKE_CURRENT_SOURCE_DIR}
5​ ${CMAKE_CURRENT_BINARY_DIR}
6​ ${QT_INCLUDE_DIR}
7​ ${GDAL_INCLUDE_DIR}
kossebauUnsubmitted
Not Done

No need for that, Qt include dirs are automatically added by mechanisms elsewhere (if curious how, ask me for details on irc please :) ). Besides, that var is not set in Qt5 worlds anyway.

kossebau: No need for that, Qt include dirs are automatically added by mechanisms elsewhere (if curious…
8​)
9​
10​set( gdal_SRCS GdalPlugin.cpp GdalRunner.cpp )
11​
12​set( GdalPlugin_LIBS ${GDAL_LIBRARY} )
13​
14​add_compile_options(-Wno-switch)
15​
nienhueserUnsubmitted
Done

What does this do, is it needed? If so it should be done only for GCC since e.g. visual studio would not understand the switch.

nienhueser: What does this do, is it needed? If so it should be done only for GCC since e.g. visual studio…
chaz6AuthorUnsubmitted
Not Done

This prevents warnings about un-handled enum cases in the switch statement. GDAL has dozens of types so this is for convenience for now; I will remove it before the next code review.

chaz6: This prevents warnings about un-handled enum cases in the switch statement. GDAL has dozens of…
16​marble_add_plugin( GdalPlugin ${gdal_SRCS} )