Differential D1917 Diff 4554 src/plugins/runner/CMakeLists.txt

Changeset View

Standalone View

View Options

src/plugins/runner/CMakeLists.txt

Context not available.
38if( LIBSHP_FOUND ) 38​if( LIBSHP_FOUND )
39 add_subdirectory( shp ) 39​ add_subdirectory( shp )
40endif( LIBSHP_FOUND ) 40​endif( LIBSHP_FOUND )
41​
42​macro_optional_find_package( GDAL 2.0.0 )
43​if( GDAL_FOUND )
nienhueserUnsubmitted
Done

I'd move that three lines below. Otherwise people who have not yet gdal on their system do not get the description in the cmake output.

nienhueser: I'd move that three lines below. Otherwise people who have not yet gdal on their system do not…
chaz6AuthorUnsubmitted
Not Done

OK!

chaz6: OK!
44​ marble_set_package_properties( GDAL PROPERTIES DESCRIPTION "Geospatial Data Abstration Library" )
dfaureUnsubmitted
Done

I think you want to do the set_package_properties in all cases, not only if found, so that the report at the end of the cmake run inform people about the missing (optional) dependency.

dfaure: I think you want to do the set_package_properties in all cases, not only if found, so that the…
chaz6AuthorUnsubmitted
Not Done

OK!

chaz6: OK!
45​ marble_set_package_properties( GDAL PROPERTIES URL "http://www.gdal.org/" )
46​ marble_set_package_properties( GDAL PROPERTIES TYPE OPTIONAL PURPOSE "reading datasets supported by the GDAL library" )
47​ add_subdirectory( gdal )
48​endif( GDAL_FOUND )
Context not available.