Differential D21420 Diff 58731 krusader/Synchronizer/synchronizergui.cpp

Changeset View

Standalone View

View Options

krusader/Synchronizer/synchronizergui.cpp

Context not available.
603 syncList->setPalette(pal); 603​ syncList->setPalette(pal);
604 } 604​ }
605 605​
606 int sx = group.readEntry("Window Width", -1); 606​ if (group.readEntry("Window Maximized", false))
607 int sy = group.readEntry("Window Height", -1); ​
608 ​
609 if (sx != -1 && sy != -1) ​
610 resize(sx, sy); ​
611 ​
612 if (group.readEntry("Window Maximized", false)) { ​
613 setWindowState(windowState() | Qt::WindowMaximized); 607​ setWindowState(windowState() | Qt::WindowMaximized);
608​ else {
609​ int sx = group.readEntry("Window Width", -1);
610​ int sy = group.readEntry("Window Height", -1);
nmelUnsubmitted
Not Done

Logically, it's fine, however I think it will be more clear if it is in a form of

if (maximized) {
  // maximize the window
  setWindowState(windowState() | Qt::WindowMaximized);
} else {
  // resize if the window size is stored in the config
  if (sx != -1 && sy != -1)
    resize(sx, sy);
}
nmel: Logically, it's fine, however I think it will be more clear if it is in a form of ``` if…
611​ if (sx != -1 && sy != -1)
612​ resize(sx, sy);
614 } 613​ }
615 614​
616 if (equalSizes) { 615​ if (equalSizes) {
Context not available.
1252 1251​
1253void SynchronizerGUI::resizeEvent(QResizeEvent *e) 1252​void SynchronizerGUI::resizeEvent(QResizeEvent *e)
1254{ 1253​{
1255 if (!isMaximized()) { 1254​ if (sizeX != e->size().width() || sizeY != e->size().height())
1255​ {
1256 sizeX = e->size().width(); 1256​ sizeX = e->size().width();
1257 sizeY = e->size().height(); 1257​ sizeY = e->size().height();
1258 } ​
1259 1258​
1260 if (!firstResize) { 1259​ if (!firstResize) {
1261 int delta = e->size().width() - e->oldSize().width() + (e->size().width() & 1); 1260​ int delta = e->size().width() - e->oldSize().width() + (e->size().width() & 1);
1262 int newSize = syncList->header()->sectionSize(0) + delta / 2; 1261​ int newSize = syncList->header()->sectionSize(0) + delta / 2;
1263 1262​
1264 if (newSize > 20) 1263​ if (newSize > 20)
1265 syncList->header()->resizeSection(0, newSize); 1264​ syncList->header()->resizeSection(0, newSize);
1265​ }
1266​ firstResize = false;
1266 } 1267​ }
1267 firstResize = false; 1268​
1268 QDialog::resizeEvent(e); 1269​ QDialog::resizeEvent(e);
1269} 1270​}
1270 1271​
Context not available.