Changeset View
Changeset View
Standalone View
Standalone View
src/dolphintabwidget.h
Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Line(s) | 34 | public: | |||
---|---|---|---|---|---|
73 | void readProperties(const KConfigGroup& group); | 73 | void readProperties(const KConfigGroup& group); | ||
74 | 74 | | |||
75 | /** | 75 | /** | ||
76 | * Refreshes the views of the main window by recreating them according to | 76 | * Refreshes the views of the main window by recreating them according to | ||
77 | * the given Dolphin settings. | 77 | * the given Dolphin settings. | ||
78 | */ | 78 | */ | ||
79 | void refreshViews(); | 79 | void refreshViews(); | ||
80 | 80 | | |||
81 | /** | ||||
82 | * @param url The URL that we would like | ||||
83 | * @return index of the tab with the desired URL. returns -1 if not found | ||||
84 | */ | ||||
85 | int getIndexByUrl(const QUrl& url) const; | ||||
elvisangelaccio: Missing `const`.
I'd call it `getIndexByUrl`, uppercase `URL` is less frequent in Qt API names. | |||||
86 | | ||||
81 | signals: | 87 | signals: | ||
82 | /** | 88 | /** | ||
83 | * Is emitted when the active view has been changed, by changing the current | 89 | * Is emitted when the active view has been changed, by changing the current | ||
84 | * tab or by activating another view when split view is enabled in the current | 90 | * tab or by activating another view when split view is enabled in the current | ||
85 | * tab. | 91 | * tab. | ||
86 | */ | 92 | */ | ||
87 | void activeViewChanged(DolphinViewContainer* viewContainer); | 93 | void activeViewChanged(DolphinViewContainer* viewContainer); | ||
88 | 94 | | |||
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines |
Missing const.
I'd call it getIndexByUrl, uppercase URL is less frequent in Qt API names.