Differential D20535 Diff 57644 src/widgets/profilemanager.cpp

Changeset View

Standalone View

View Options

src/widgets/profilemanager.cpp

  • This file was added.
1​/* AtCore - Widgets
2​ Copyright (C) <2019>
3​ Author: Chris Rizzitello - rizzitello@kde.org
4​
5​ This program is free software: you can redistribute it and/or modify
6​ it under the terms of the GNU General Public License as published by
7​ the Free Software Foundation, either version 3 of the License, or
8​ (at your option) any later version.
9​
10​ This program is distributed in the hope that it will be useful,
11​ but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13​ GNU General Public License for more details.
14​
15​ You should have received a copy of the GNU General Public License
16​ along with this program. If not, see <http://www.gnu.org/licenses/>.
17​*/
18​
19​#include "profilemanager.h"
20​#include "atcore_default_folders.h"
21​#include "machineinfo.h"
22​
23​#include <QCoreApplication>
24​#include <QDir>
25​#include <QToolButton>
26​#include <QLineEdit>
27​#include <QGroupBox>
28​#include <QButtonGroup>
29​
30​ProfileManager::ProfileManager(QWidget *parent) :
31​ QWidget(parent)
32​{
33​ auto newLabel = new QLabel(tr("Profile:"));
34​ cbProfile = new QComboBox();
35​ cbProfile->setEditable(true);
36​ cbProfile->setAutoCompletion(true);
37​ cbProfile->addItems(MachineInfo::instance()->profileNames());
38​ connect(MachineInfo::instance(), &MachineInfo::profilesChanged, this, [this] {
39​ int index = cbProfile->currentIndex();
40​ cbProfile->clear();
41​ cbProfile->addItems(MachineInfo::instance()->profileNames());
42​ cbProfile->setCurrentIndex(std::min<int>(index, cbProfile->count() - 1));
43​ });
44​
45​ connect(cbProfile, QOverload<int>::of(&QComboBox::currentIndexChanged), this, [this] {
46​ if (MachineInfo::instance()->profileNames().contains(cbProfile->currentText()))
47​ {
48​ loadProfile(cbProfile->currentText());
49​ }
50​ });
51​
52​ connect(cbProfile->lineEdit(), &QLineEdit::editingFinished, this, &ProfileManager::onCbProfileEditingFinished);
53​
54​ auto newHLayout = new QHBoxLayout();
55​ newHLayout->addWidget(newLabel);
56​ newHLayout->addWidget(cbProfile, 75);
57​
patrickelectricUnsubmitted
Done

else is unnecessary use return

patrickelectric: else is unnecessary use return
58​ auto newButton = new QToolButton();
59​ newButton->setIcon(QIcon::fromTheme(QStringLiteral("edit-delete"), style()->standardIcon(QStyle::SP_DialogDiscardButton)));
60​ newButton->setToolTip(tr("Delete Current Profile"));
61​ newButton->setIconSize(QSize(fontMetrics().height(), fontMetrics().height()));
62​ connect(newButton, &QToolButton::clicked, this, [this] {
63​ if (!cbProfile->currentText().isEmpty())
64​ {
65​ MachineInfo::instance()->removeProfile(cbProfile->currentText());
66​ }
67​ });
68​
69​ auto mainLayout = new QVBoxLayout();
70​ newHLayout->addWidget(newButton);
71​ mainLayout->addLayout(newHLayout);
72​ auto profileLayout = new QVBoxLayout();
73​ auto boxLayout = new QVBoxLayout();
74​
75​ newLabel = new QLabel(tr("Name"));
76​ lineName = new QLineEdit();
77​ connect(lineName, &QLineEdit::editingFinished, this, [this] {
78​ QString itemName = lineName->text();
79​ if (MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::NAME, itemName))
80​ {
81​ loadProfile(itemName);
82​ }
83​ });
84​ newHLayout = new QHBoxLayout;
85​ newHLayout->addWidget(newLabel);
86​ newHLayout->addWidget(lineName);
87​ profileLayout->addLayout(newHLayout);
88​
89​ newLabel = new QLabel(tr("Printer Type:"));
90​ radioDelta = new QRadioButton(tr("Delta"));
91​ radioCartesian = new QRadioButton(tr("Cartesian"));
92​ radioCartesian->setChecked(true);
93​ connect(radioCartesian, &QRadioButton::toggled, this, &ProfileManager::onRadioCartesianToggled);
94​
95​ newHLayout = new QHBoxLayout;
96​ newHLayout->addWidget(newLabel);
97​ newHLayout->addWidget(radioCartesian);
98​ newHLayout->addWidget(radioDelta);
99​ boxLayout->addLayout(newHLayout);
100​
101​ lblX = new QLabel(tr("Maximum X"));
102​ sbMaxX = new QSpinBox();
103​ sbMaxX->setMaximum(std::numeric_limits<int>::max());
104​ sbMaxX->setSuffix(QStringLiteral("mm"));
105​ connect(sbMaxX, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int value) {
106​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::XMAX, value);
107​ });
108​
109​ newHLayout = new QHBoxLayout;
110​ newHLayout->addWidget(lblX);
111​ newHLayout->addWidget(sbMaxX);
112​ boxLayout->addLayout(newHLayout);
113​
114​ newLabel = new QLabel(tr("Maximum Y"));
115​ sbMaxY = new QSpinBox();
116​ sbMaxY->setMaximum(std::numeric_limits<int>::max());
117​ sbMaxY->setSuffix(QStringLiteral("mm"));
118​ connect(sbMaxY, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int value) {
119​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::YMAX, value);
120​ });
121​
122​ newHLayout = new QHBoxLayout;
123​ newHLayout->setContentsMargins(0, 0, 0, 0);
124​ newHLayout->addWidget(newLabel);
125​ newHLayout->addWidget(sbMaxY);
126​ axisY = new QWidget(this);
127​ axisY->setLayout(newHLayout);
128​ boxLayout->addWidget(axisY);
129​
130​ lblZ = new QLabel(tr("Maximum Z"));
131​ sbMaxZ = new QSpinBox();
132​ sbMaxZ->setMaximum(std::numeric_limits<int>::max());
133​ sbMaxZ->setSuffix(QStringLiteral("mm"));
134​ connect(sbMaxZ, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int value) {
135​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::ZMAX, value);
136​ });
137​
138​ newHLayout = new QHBoxLayout;
patrickelectricUnsubmitted
Done

Is this the upside-down number of the beast ?
use std::numeric_limits<T>::max()

patrickelectric: Is this the upside-down number of the beast ? use `std::numeric_limits<T>::max()`
139​ newHLayout->addWidget(lblZ);
140​ newHLayout->addWidget(sbMaxZ);
patrickelectricUnsubmitted
Done

well, this is huge, you should move to a function and stay with only min number of lines inside lambda functions.

patrickelectric: well, this is huge, you should move to a function and stay with only min number of lines inside…
141​ boxLayout->addLayout(newHLayout);
142​
143​ auto groupBox = new QGroupBox(tr("Mechanics"));
144​ groupBox->setLayout(boxLayout);
145​ profileLayout->addWidget(groupBox);
146​
147​ boxLayout = new QVBoxLayout;
148​ newLabel = new QLabel(tr("Bed Maximum"));
149​ sbMaxBedTemp = new QSpinBox();
150​ sbMaxBedTemp->setMaximum(999);
151​ sbMaxBedTemp->setSuffix(QStringLiteral(" ºC"));
152​ connect(sbMaxBedTemp, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int value) {
153​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::MAXBEDTEMP, value);
154​ });
155​
156​ newHLayout = new QHBoxLayout;
157​ newHLayout->addWidget(newLabel);
158​ newHLayout->addWidget(sbMaxBedTemp);
159​ boxLayout->addLayout(newHLayout);
160​
161​ sbMaxExtTemp = new QSpinBox();
162​ sbMaxExtTemp->setMaximum(999);
163​ newLabel = new QLabel(tr("Extruder Maximum"));
164​ sbMaxExtTemp->setSuffix(QStringLiteral(" ºC"));
165​ connect(sbMaxExtTemp, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int value) {
166​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::MAXEXTTEMP, value);
167​ });
168​
169​ newHLayout = new QHBoxLayout();
170​ newHLayout->addWidget(newLabel);
171​ newHLayout->addWidget(sbMaxExtTemp);
172​ boxLayout->addLayout(newHLayout);
173​
174​ checkAutoTempReport = new QCheckBox(tr("Auto Temperature Report"));
175​ checkAutoTempReport->setLayoutDirection(Qt::RightToLeft);
176​ connect(checkAutoTempReport, &QCheckBox::toggled, this, [this](bool checked) {
177​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::AUTOTEMPREPORT, checked);
178​ });
179​ boxLayout->addWidget(checkAutoTempReport, 0, Qt::AlignRight);
180​
181​ groupBox = new QGroupBox(tr("Temperature"));
182​ groupBox->setLayout(boxLayout);
183​ profileLayout->addWidget(groupBox);
184​
185​ boxLayout = new QVBoxLayout();
186​ cbBaud = new QComboBox();
187​ cbBaud->addItems(SERIAL::BAUDS);
188​ cbBaud->setCurrentText(QStringLiteral("115200"));
189​ connect(cbBaud, &QComboBox::currentTextChanged, this, [this](const QString & newText) {
190​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::BAUDRATE, newText);
191​ });
192​
193​ newLabel = new QLabel(tr("Bit Rate"));
194​ newHLayout = new QHBoxLayout();
195​ newHLayout->addWidget(newLabel);
196​ newHLayout->addWidget(cbBaud);
197​ boxLayout->addLayout(newHLayout);
198​
199​ newLabel = new QLabel(tr("Firmware"));
200​ cbFirmware = new QComboBox();
201​ cbFirmware->addItem(QStringLiteral("Auto-Detect"));
202​ cbFirmware->addItems(detectFWPlugins());
203​ connect(cbFirmware, &QComboBox::currentTextChanged, this, [this](const QString & newText) {
204​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::FIRMWARE, newText);
205​ });
206​
207​ newHLayout = new QHBoxLayout();
208​ newHLayout->addWidget(newLabel);
209​ newHLayout->addWidget(cbFirmware);
210​ boxLayout->addLayout(newHLayout);
211​
212​ linePostPause = new QLineEdit();
213​ connect(linePostPause, &QLineEdit::editingFinished, this, [this] {
214​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::POSTPAUSE, linePostPause->text());
215​ });
216​
217​ newLabel = new QLabel(tr("PostPause"));
218​ newHLayout = new QHBoxLayout();
219​ newHLayout->addWidget(newLabel);
220​ newHLayout->addWidget(linePostPause);
221​ boxLayout->addLayout(newHLayout);
222​
223​ groupBox = new QGroupBox(tr("Advanced"));
224​ groupBox->setLayout(boxLayout);
225​ profileLayout->addWidget(groupBox);
226​ groupBox = new QGroupBox(tr("Profile"));
227​ groupBox->setLayout(profileLayout);
228​ mainLayout->addWidget(groupBox);
229​ setLayout(mainLayout);
230​ loadProfile(cbProfile->currentText());
231​}
232​
233​void ProfileManager::onCbProfileEditingFinished()
234​{
235​ if (MachineInfo::instance()->profileNames().contains(cbProfile->currentText())) {
236​ loadProfile(cbProfile->currentText());
237​ return;
238​ }
239​ QMap <MachineInfo::KEY, QVariant> newProfile = {
240​ {MachineInfo::KEY::NAME, cbProfile->currentText()},
241​ {MachineInfo::KEY::FIRMWARE, cbFirmware->currentText()},
242​ {MachineInfo::KEY::BAUDRATE, cbBaud->currentText()},
243​ {MachineInfo::KEY::POSTPAUSE, linePostPause->text()},
244​ {MachineInfo::KEY::ISCARTESIAN, radioCartesian->isChecked()},
245​ {MachineInfo::KEY::XMAX, sbMaxX->value()},
246​ {MachineInfo::KEY::YMAX, sbMaxY->value()},
247​ {MachineInfo::KEY::ZMAX, sbMaxZ->value()},
248​ {MachineInfo::KEY::AUTOTEMPREPORT, checkAutoTempReport->isChecked()},
249​ {MachineInfo::KEY::MAXBEDTEMP, sbMaxBedTemp->value()},
250​ {MachineInfo::KEY::MAXEXTTEMP, sbMaxExtTemp->value()}
251​ };
252​ MachineInfo::instance()->storeProfile(newProfile);
253​ loadProfile(newProfile[MachineInfo::KEY::NAME].toString());
254​}
255​
256​void ProfileManager::onRadioCartesianToggled(bool checked)
257​{
258​ axisY->setVisible(checked);
259​ if (checked) {
260​ lblX->setText(tr("Maximum X"));
261​ lblZ->setText(tr("Maximum Z"));
262​ } else {
263​ lblX->setText(tr("Radius"));
264​ lblZ->setText(tr("Height"));
265​ }
266​ if (MachineInfo::instance()->profileNames().contains(cbProfile->currentText())) {
267​ MachineInfo::instance()->storeKey(cbProfile->currentText(), MachineInfo::KEY::ISCARTESIAN, checked);
268​ }
269​}
270​
patrickelectricUnsubmitted
Done

if empty return

patrickelectric: if empty return
271​void ProfileManager::loadProfile(const QString &profileName)
272​{
273​ if (profileName.isEmpty()) {
274​ return;
275​ }
276​ blockSignals(true);
277​ lineName->setText(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::NAME).toString());
278​ radioCartesian->setChecked(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::ISCARTESIAN).toBool());
279​ radioDelta->setChecked(!MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::ISCARTESIAN).toBool());
280​ sbMaxX->setValue(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::XMAX).toInt());
281​ sbMaxY->setValue(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::YMAX).toInt());
282​ sbMaxZ->setValue(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::ZMAX).toInt());
283​ checkAutoTempReport->setChecked(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::AUTOTEMPREPORT).toBool());
284​ sbMaxBedTemp->setValue(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::MAXBEDTEMP).toInt());
285​ sbMaxExtTemp->setValue(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::MAXEXTTEMP).toInt());
286​ cbFirmware->setCurrentText(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::FIRMWARE).toString());
287​ cbBaud->setCurrentText(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::BAUDRATE).toString());
288​ linePostPause->setText(MachineInfo::instance()->readKey(profileName, MachineInfo::KEY::POSTPAUSE).toString());
289​ cbProfile->setCurrentText(profileName);
290​ cbProfile->setCurrentIndex(MachineInfo::instance()->profileNames().indexOf(profileName));
291​ blockSignals(false);
292​}
293​
294​QStringList ProfileManager::detectFWPlugins()
295​{
296​ QStringList firmwares;
297​ QStringList paths = AtCoreDirectories::pluginDir;
298​ //Add our runtime paths
299​ const QString &p(qApp->applicationDirPath());
300​ paths.prepend(p + QStringLiteral("/../Plugins/AtCore"));
301​ paths.prepend(p + QStringLiteral("/AtCore"));
302​ paths.prepend(p + QStringLiteral("/plugins"));
303​ for (const QString &path : qAsConst(paths)) {
304​ firmwares = firmwaresInPath(path);
305​ if (!firmwares.isEmpty()) {
306​ //use path where plugins were detected.
307​ break;
308​ }
309​ }
310​ return firmwares;
311​}
312​
313​QStringList ProfileManager::firmwaresInPath(const QString &path)
patrickelectricUnsubmitted
Done

get by copy if you are doing a copy.

patrickelectric: get by copy if you are doing a copy.
314​{
315​ QStringList firmwares;
316​ QStringList files = QDir(path).entryList(QDir::Files);
317​ for (QString file : files) {
318​#if defined(Q_OS_WIN)
319​ if (file.endsWith(QStringLiteral(".dll")))
320​#elif defined(Q_OS_MAC)
321​ if (file.endsWith(QStringLiteral(".dylib")))
322​#else
323​ if (file.endsWith(QStringLiteral(".so")))
324​#endif
325​ file = file.split(QChar::fromLatin1('.')).at(0);
326​ else {
327​ continue;
328​ }
329​ if (file.startsWith(QStringLiteral("lib"))) {
330​ file = file.remove(QStringLiteral("lib"));
331​ }
332​ file = file.toLower().simplified();
333​ firmwares.append(file);
334​ }
335​ return firmwares;
336​}