Differential D20737 Diff 57616 src/kitemviews/private/kbaloorolesprovider.cpp

Changeset View

Standalone View

View Options

src/kitemviews/private/kbaloorolesprovider.cpp

Context not available.
104 104​
105 // Mapping from the URIs to the KFileItemModel roles. Note that this must not be 105​ // Mapping from the URIs to the KFileItemModel roles. Note that this must not be
106 // a 1:1 mapping: One role may contain several URI-values 106​ // a 1:1 mapping: One role may contain several URI-values
107 static const PropertyInfo propertyInfoList[] = { 107​ static constexpr std::array<PropertyInfo, 20> propertyInfoList{{
108 { "rating", "rating" }, 108​ { "rating", "rating" },
109 { "tag", "tags" }, 109​ { "tag", "tags" },
110 { "comment", "comment" }, 110​ { "comment", "comment" },
Context not available.
125 { "releaseYear", "releaseYear" }, 125​ { "releaseYear", "releaseYear" },
126 { "trackNumber", "track" }, 126​ { "trackNumber", "track" },
127 { "originUrl", "originUrl" } 127​ { "originUrl", "originUrl" }
128 }; 128​ }};
129 129​
130 for (unsigned int i = 0; i < sizeof(propertyInfoList) / sizeof(PropertyInfo); ++i) { 130​ for (unsigned int i = 0; i < sizeof(propertyInfoList) / sizeof(PropertyInfo); ++i) {
pinoUnsubmitted
Not Done

won't the sizeof() here be invalid now?

pino: won't the sizeof() here be invalid now?
elvisangelaccioUnsubmitted
Not Done

Good catch, yes that needs to be changed

elvisangelaccio: Good catch, yes that needs to be changed
131 m_roleForProperty.insert(propertyInfoList[i].property, propertyInfoList[i].role); 131​ m_roleForProperty.insert(propertyInfoList[i].property, propertyInfoList[i].role);
Context not available.