Differential D19011 Diff 57147 kcms/bolt/package/contents/ui/DeviceView.qml

Changeset View

Standalone View

View Options

kcms/bolt/package/contents/ui/DeviceView.qml

  • This file was added.
1​/*
2​ * Copyright (c) 2018 - 2019 Daniel Vrátil <dvratil@kde.org>
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​import QtQuick 2.7
22​import QtQuick.Layouts 1.1
23​import QtQuick.Controls 2.3
24​
25​import org.kde.kirigami 2.4 as Kirigami
26​import org.kde.kquickcontrolsaddons 2.0 as KQCAddons
27​import org.kde.bolt 0.1 as Bolt
28​import "utils.js" as Utils
29​
30​Kirigami.ScrollablePage {
31​ id: page
32​
33​ property Bolt.Manager manager: null
34​ property Bolt.Device device: null
35​
36​ property int _evalTrigger: 0
37​
38​ Timer {
39​ interval: 2000
40​ running: device != null
41​ repeat: true
42​ onTriggered: page._evalTrigger++;
43​ }
44​
45​ ColumnLayout {
46​ spacing: Kirigami.Units.smallSpacing * 5
47​
48​ RowLayout {
49​ Button {
50​ icon.name: "draw-arrow-back"
51​ visible: !pageRow.wideMode
ngrahamUnsubmitted
Not Done

Can we give this a label or make it a Button instead? Many users have difficulty recognizing label-less toolbuttons floating inside the page as clickable buttons.

ngraham: Can we give this a label or make it a `Button` instead? Many users have difficulty recognizing…
52​ onClicked: pageRow.pop()
53​ }
54​
55​ Kirigami.Heading {
56​ level: 2
57​ text: _evalTrigger, device ? device.name : ""
58​ }
59​ }
60​
61​ Kirigami.InlineMessage {
62​ id: errorMessage
63​
64​ Layout.fillWidth: true
65​
66​ type: Kirigami.MessageType.Error
67​ showCloseButton: true
68​
69​ function show(msg) {
70​ text = msg;
71​ visible = true;
72​ }
73​ }
74​
75​ Kirigami.FormLayout {
76​ Label {
77​ text: _evalTrigger, device ? device.vendor : ""
78​ Kirigami.FormData.label: i18n("Vendor:")
79​ }
80​ Label {
81​ text: _evalTrigger, device ? device.uid : ""
82​ Kirigami.FormData.label: i18n("UID:")
83​ }
84​ Label {
85​ text: _evalTrigger, device ? Utils.deviceStatus(device, false).text : ""
86​ Kirigami.FormData.label: i18n("Status:")
87​ }
88​ Label {
89​ visible: device && device.status == Bolt.Bolt.Status.Authorized
90​ text: _evalTrigger, device ? Qt.formatDateTime(device.authorizeTime) : ""
91​ Kirigami.FormData.label: i18n("Authorized at:")
92​ }
93​ Label {
94​ visible: device && device.status == Bolt.Bolt.Status.Connected
95​ text: _evalTrigger, device ? Qt.formatDateTime(device.connectTime) : ""
96​ Kirigami.FormData.label: i18n("Connected at:")
97​ }
98​ Label {
99​ visible: device && device.status == Bolt.Bolt.Status.Disconnected
100​ text: _evalTrigger, device ? Qt.formatDateTime(device.storeTime) : ""
101​ Kirigami.FormData.label: i18n("Enrolled at:")
102​ }
103​ Label {
104​ visible: device && (device.status == Bolt.Bolt.Status.Authorized || device.status == Bolt.Bolt.Status.Disconnected)
105​ text: _evalTrigger, device && device.stored ? i18n("Yes") : i18n("No")
106​ Kirigami.FormData.label: i18n("Trusted:")
107​ }
108​ }
109​
110​ RowLayout {
111​ Layout.alignment: Qt.AlignHCenter
112​
113​ Button {
114​ id: authorizeBtn
115​ text: device && device.status == Bolt.Bolt.Status.Authorizing ? i18n("Authorizing...") : i18n("Authorize")
116​ enabled: device && device.status != Bolt.Bolt.Status.Authorizing
117​ visible: device && (device.status == Bolt.Bolt.Status.Connected || device.status == Bolt.Bolt.Status.AuthError)
118​ onClicked: {
119​ Bolt.QMLHelper.enrollDevice(
120​ manager, device.uid, Bolt.Bolt.Policy.Default,
121​ Bolt.Bolt.Auth.Boot | Bolt.Bolt.Auth.NoKey,
122​ function() {
123​ console.log("Thunderbolt device " + device.uid + " (" + device.name + ") enrolled successfully");
yurchorUnsubmitted
Done

Typo: successfuly -> successfully

yurchor: Typo: successfuly -> successfully
124​ },
125​ function(error) {
126​ errorMessage.show(i18n("Failed to enroll device <b>%1</b>: %2", device.name, error));
127​ }
128​ );
129​ }
130​ }
131​ Button {
132​ id: storeBtn
133​ text: i18n("Trust this Device")
134​ visible: device && device.status == Bolt.Bolt.Status.Authorized && device.stored == false
ngrahamUnsubmitted
Not Done

"Trust this Device"?

ngraham: "Trust this Device"?
135​ onClicked: {
136​ enabled = false;
137​ Bolt.QMLHelper.enrollDevice(
138​ manager, device.uid, Bolt.Bolt.Policy.Default,
139​ Bolt.Bolt.Auth.Boot | Bolt.Bolt.Auth.NoKey,
140​ function() {
141​ enabled = true;
142​ console.log("Thunderbolt Device " + device.uid + " (" + device.name + ") enrolled successfully");
yurchorUnsubmitted
Done

Typo: successfuly -> successfully

yurchor: Typo: successfuly -> successfully
143​ },
144​ function(error) {
145​ enabled = true;
146​ errorMessage.show(i18n("Failed to enroll device <b>%1</b>: %2", device.name, error));
147​ }
148​ );
149​ }
150​ }
151​
ngrahamUnsubmitted
Not Done

I'd recommend that we center this horizontally on the page.

ngraham: I'd recommend that we center this horizontally on the page.
152​ Button {
153​ id: forgetBtn
154​ text: i18n("Revoke Trust")
155​ visible: device && device.stored
ngrahamUnsubmitted
Not Done

"Revoke Trust"?

ngraham: "Revoke Trust"?
156​ onClicked: {
157​ enabled = false
158​ Bolt.QMLHelper.forgetDevice(
159​ manager, device.uid,
160​ function() {
161​ enabled = true;
162​ console.log("Device " + device.uid + " successfully forgotten.");
163​ },
164​ function(error) {
165​ enabled = true;
166​ errorMessage.show(i18n("Error changing device trust: <b>%1</b>: %2", device.name, error));
167​ }
168​ );
169​ // If the device is not connected it will cease to exist
170​ // once forgotten, so we should pop this view
171​ if (device.status == Bolt.Bolt.Status.Disconnected) {
172​ pageRow.pop();
173​ }
174​ }
175​ }
176​ }
177​
178​ Label {
179​ Layout.alignment: Qt.AlignHCenter
180​ Layout.fillWidth: true
181​
182​ text: device && !device.stored
183​ ? qsTr("Hint: trusted device will be automatically authorized the next time it is connected to the computer.")
184​ : qsTr("Hint: an untrusted device needs to be manually authorized each time it is connected to the computer.")
185​ visible: storeBtn.visible || forgetBtn.visible
186​ wrapMode: Text.WordWrap
187​ horizontalAlignment: Qt.AlignHCenter
188​ }
189​ }
190​}