Differential D1722 Diff 4228 libtaskmanager/launchertasksmodel.cpp

Changeset View

Standalone View

View Options

libtaskmanager/launchertasksmodel.cpp

  • This file was added.
1​/********************************************************************
2​Copyright 2016 Eike Hein <hein@kde.org>
3​
4​This library is free software; you can redistribute it and/or
5​modify it under the terms of the GNU Lesser General Public
6​License as published by the Free Software Foundation; either
7​version 2.1 of the License, or (at your option) version 3, or any
8​later version accepted by the membership of KDE e.V. (or its
9​successor approved by the membership of KDE e.V.), which shall
10​act as a proxy defined in Section 6 of version 3 of the license.
11​
12​This library is distributed in the hope that it will be useful,
13​but WITHOUT ANY WARRANTY; without even the implied warranty of
14​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​Lesser General Public License for more details.
16​
17​You should have received a copy of the GNU Lesser General Public
18​License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​*********************************************************************/
20​
21​#include "launchertasksmodel.h"
22​#include "tasktools.h"
23​
24​#include <KRun>
25​#include <KService>
26​#include <KStartupInfo>
27​#include <KSycoca>
28​
29​#include <config-X11.h>
30​
31​#include <QIcon>
32​#include <QTimer>
33​#if HAVE_X11
34​#include <QX11Info>
35​#endif
36​
37​namespace TaskManager
38​{
39​
40​class LauncherTasksModel::Private
41​{
42​public:
43​ Private(LauncherTasksModel *q);
44​ QList<QUrl> launchers;
45​ QHash<QUrl, AppData> appDataCache;
46​ QTimer sycocaChangeTimer;
47​
48​ void init();
49​ AppData appData(const QUrl &url);
50​
51​private:
52​ LauncherTasksModel *q;
53​};
54​
55​LauncherTasksModel::Private::Private(LauncherTasksModel *q)
56​ : q(q)
57​{
58​}
59​
broulikUnsubmitted
Not Done

(const) find to avoid double lookup (contains and value)? Probably negligible with a QHash compared to the code ugliness it causes

broulik: (const) find to avoid double lookup (contains and value)? Probably negligible with a QHash…
60​void LauncherTasksModel::Private::init()
61​{
62​ sycocaChangeTimer.setSingleShot(true);
63​ sycocaChangeTimer.setInterval(100);
64​
65​ QObject::connect(&sycocaChangeTimer, &QTimer::timeout, q,
66​ [this]() {
67​ if (!launchers.count()) {
68​ return;
69​ }
70​
71​ appDataCache.clear();
72​
73​ // Emit changes of all roles satisfied from app data cache.
74​ q->dataChanged(q->index(0, 0), q->index(launchers.count() - 1, 0),
75​ QVector<int>{Qt::DisplayRole, Qt::DecorationRole,
76​ AbstractTasksModel::AppId, AbstractTasksModel::AppName,
77​ AbstractTasksModel::GenericName, AbstractTasksModel::LauncherUrl});
78​ }
79​ );
80​
81​ void (KSycoca::*myDatabaseChangeSignal)(const QStringList &) = &KSycoca::databaseChanged;
82​ QObject::connect(KSycoca::self(), myDatabaseChangeSignal, q,
83​ [this](const QStringList &changedResources) {
84​ if (changedResources.contains(QLatin1String("services"))
85​ || changedResources.contains(QLatin1String("apps"))
86​ || changedResources.contains(QLatin1String("xdgdata-apps"))) {
87​ sycocaChangeTimer.start();
88​ }
89​ }
90​ );
91​}
92​
93​AppData LauncherTasksModel::Private::appData(const QUrl &url)
94​{
95​ if (!appDataCache.contains(url)) {
96​ const AppData &data = appDataFromUrl(url, QIcon::fromTheme(QLatin1String("unknown")));
97​ appDataCache.insert(url, data);
98​
99​ return data;
100​ }
101​
102​ return appDataCache.value(url);
103​}
104​
105​LauncherTasksModel::LauncherTasksModel(QObject *parent)
106​ : AbstractTasksModel(parent)
107​ , d(new Private(this))
108​{
109​ d->init();
110​}
111​
112​LauncherTasksModel::~LauncherTasksModel()
113​{
114​}
115​
116​QVariant LauncherTasksModel::data(const QModelIndex &index, int role) const
117​{
118​ if (!index.isValid() || index.row() >= d->launchers.count()) {
119​ return QVariant();
120​ }
121​
122​ const QUrl &url = d->launchers.at(index.row());
broulikUnsubmitted
Not Done

That variable name is weird

broulik: That variable name is weird
123​ const AppData &data = d->appData(url);
124​
125​ if (role == Qt::DisplayRole) {
126​ return data.name;
broulikUnsubmitted
Not Done

coding style: foreach (...)

broulik: coding style: foreach (...)
heinAuthorUnsubmitted
Not Done

I don't understand this. You're complaining about the white space or ...? I changed it assuming that was it.

hein: I don't understand this. You're complaining about the white space or ...? I changed it assuming…
127​ } else if (role == Qt::DecorationRole) {
broulikUnsubmitted
Done

An empty QUrl is invalid already but I understand you don't trust QUrl :)

broulik: An empty QUrl is invalid already but I understand you don't trust QUrl :)
heinAuthorUnsubmitted
Not Done

Changed it ...

hein: Changed it ...
128​ return data.icon;
129​ } else if (role == AppId) {
130​ return data.id;
131​ } else if (role == AppName) {
132​ return data.name;
133​ } else if (role == GenericName) {
134​ return data.genericName;
135​ } else if (role == LauncherUrl) {
136​ // Take resolved URL from cache.
137​ return data.url;
138​ } else if (role == IsLauncher) {
139​ return true;
140​ } else if (role == IsOnAllVirtualDesktops) {
141​ return true;
142​ }
143​
144​ return QVariant();
145​}
146​
147​int LauncherTasksModel::rowCount(const QModelIndex &parent) const
148​{
149​ return parent.isValid() ? 0 : d->launchers.count();
150​}
151​
152​QStringList LauncherTasksModel::launcherList() const
153​{
154​ return QUrl::toStringList(d->launchers);
155​}
156​
157​void LauncherTasksModel::setLauncherList(const QStringList &launchers)
158​{
159​ const QList<QUrl> &_urls = QUrl::fromStringList(launchers, QUrl::StrictMode);
160​ QList<QUrl> urls;
161​
162​ // Reject invalid urls and duplicates.
163​ foreach(const QUrl &url, _urls) {
164​ if (url.isValid()) {
165​ bool dupe = false;
166​
167​ foreach(const QUrl &addedUrl, urls) {
168​ dupe = launcherUrlsMatch(url, addedUrl, IgnoreQueryItems);
169​ }
170​
171​ if (!dupe) {
172​ urls.append(url);
173​ }
174​ }
175​ }
176​
177​ if (d->launchers != urls) {
178​ beginResetModel();
179​
180​ d->launchers.clear();
181​ d->appDataCache.clear();
182​
183​ d->launchers = urls;
184​
185​ endResetModel();
186​
187​ emit launcherListChanged();
188​ }
189​}
190​
191​bool LauncherTasksModel::requestAddLauncher(const QUrl &_url)
192​{
193​ // isValid() for the passed-in URL might return true if it was
194​ // constructed in TolerantMode, but we want to reject invalid URLs.
195​ QUrl url(_url.toString(), QUrl::StrictMode);
196​
197​ if (url.isEmpty() || !url.isValid()) {
198​ return false;
199​ }
200​
201​ // Reject duplicates.
202​ foreach(const QUrl &launcher, d->launchers) {
203​ if (launcherUrlsMatch(url, launcher, IgnoreQueryItems)) {
204​ return false;
205​ }
206​ }
207​
208​ const int count = d->launchers.count();
209​ beginInsertRows(QModelIndex(), count, count);
210​ d->launchers.append(url);
211​ endInsertRows();
212​
213​ emit launcherListChanged();
214​
215​ return true;
216​}
217​
218​bool LauncherTasksModel::requestRemoveLauncher(const QUrl &url)
219​{
220​ for (int i = 0; i < d->launchers.count(); ++i) {
221​ const QUrl &launcher = d->launchers.at(i);
222​
223​ if (launcherUrlsMatch(url, launcher, IgnoreQueryItems)
224​ || launcherUrlsMatch(url, d->appData(launcher).url, IgnoreQueryItems)) {
225​ beginRemoveRows(QModelIndex(), i, i);
226​ d->launchers.removeAt(i);
227​ d->appDataCache.remove(launcher);
228​ endRemoveRows();
229​
230​ emit launcherListChanged();
231​
232​ return true;
233​ }
234​ }
235​
236​ return false;
237​}
238​
239​int LauncherTasksModel::launcherPosition(const QUrl &url) const
240​{
241​ for (int i = 0; i < d->launchers.count(); ++i) {
242​ if (launcherUrlsMatch(url, d->launchers.at(i), IgnoreQueryItems)) {
243​ return i;
244​ }
245​ }
246​
247​ return -1;
248​}
249​
250​void LauncherTasksModel::requestActivate(const QModelIndex &index)
251​{
252​ requestNewInstance(index);
253​}
254​
255​void LauncherTasksModel::requestNewInstance(const QModelIndex &index)
256​{
257​ if (!index.isValid() || index.model() != this
258​ || index.row() < 0 || index.row() >= d->launchers.count()) {
259​ return;
260​ }
261​
262​ const QUrl &url = d->launchers.at(index.row());
263​
264​ quint32 timeStamp = 0;
265​
266​#if HAVE_X11
267​ if (QX11Info::isPlatformX11()) {
268​ timeStamp = QX11Info::appUserTime();
269​ }
270​#endif
271​
272​ if (url.scheme() == QLatin1String("preferred")) {
273​ KService::Ptr service = KService::serviceByStorageId(defaultApplication(url));
274​
275​ if (!service) {
276​ return;
277​ }
278​
279​ new KRun(QUrl::fromLocalFile(service->entryPath()), 0, false,
280​ KStartupInfo::createNewStartupIdForTimestamp(timeStamp));
281​ } else {
282​ new KRun(url, 0, false, KStartupInfo::createNewStartupIdForTimestamp(timeStamp));
283​ }
284​}
285​
286​}