Differential D1722 Diff 4228 libtaskmanager/CMakeLists.txt

Changeset View

Standalone View

View Options

libtaskmanager/CMakeLists.txt

  • This file was added.
1​add_subdirectory(declarative)
2​add_subdirectory(autotests)
3​
4​set(taskmanager_LIB_SRCS
5​ abstracttasksmodel.cpp
6​ activityinfo.cpp
7​ concatenatetasksproxymodel.cpp
8​ launchertasksmodel.cpp
9​ startuptasksmodel.cpp
10​ taskfilterproxymodel.cpp
11​ taskgroupingproxymodel.cpp
12​ tasksmodel.cpp
13​ tasktools.cpp
14​ virtualdesktopinfo.cpp
15​ waylandtasksmodel.cpp
16​)
17​
18​if (X11_FOUND)
19​ set(taskmanager_LIB_SRCS
20​ ${taskmanager_LIB_SRCS}
21​ xwindowtasksmodel.cpp
22​ )
23​endif()
24​
graesslinUnsubmitted
Done

do we want to have X11 conditional? Other areas of Plasma use X11 unconditionally.

graesslin: do we want to have X11 conditional? Other areas of Plasma use X11 unconditionally.
heinAuthorUnsubmitted
Not Done

Personally as maintainer I do :). From my POV X11 is a legacy windowing system for libtaskmanager and I want to support building without it. If nothing else being disciplined about that helps a bit to prevent X11 stuff from creeping over the codebase again ...

hein: Personally as maintainer I do :). From my POV X11 is a legacy windowing system for…
25​add_library(taskmanager ${taskmanager_LIB_SRCS})
26​add_library(PW::LibTaskManager ALIAS taskmanager)
27​
28​generate_export_header(taskmanager)
29​
30​target_include_directories(taskmanager PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>" "$<INSTALL_INTERFACE:${KDE_INSTALL_INCLUDEDIR}/taskmanager>")
31​
32​target_link_libraries(taskmanager
33​ PUBLIC
34​ Qt5::Core
35​ Qt5::Gui
36​ Qt5::Quick
37​ KF5::WaylandClient
38​ PRIVATE
39​ KF5::Activities
40​ KF5::ItemModels
41​ KF5::ConfigCore
42​ KF5::KIOCore
43​ KF5::KIOWidgets
44​ KF5::ProcessCore
45​ KF5::WindowSystem
46​)
47​
48​if (X11_FOUND)
49​ target_link_libraries(taskmanager
50​ PRIVATE
51​ Qt5::X11Extras
52​ KF5::IconThemes)
graesslinUnsubmitted
Done

Qt5::X11Extras

graesslin: Qt5::X11Extras
heinAuthorUnsubmitted
Not Done

Done.

hein: Done.
53​endif()
54​
55​set_target_properties(taskmanager PROPERTIES
56​ VERSION ${PROJECT_VERSION}
57​ SOVERSION ${PROJECT_VERSION_MAJOR}
58​ EXPORT_NAME LibTaskManager)
59​
60​install(TARGETS taskmanager EXPORT libtaskmanagerLibraryTargets ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} )
61​
62​install(FILES
63​ abstracttasksmodel.h
64​ abstracttasksmodeliface.h
65​ activityinfo.h
66​ concatenatetasksproxymodel.h
67​ launchertasksmodel.h
68​ startuptasksmodel.h
69​ taskfilterproxymodel.h
70​ taskgroupingproxymodel.h
71​ tasksmodel.h
72​ tasktools.h
73​ virtualdesktopinfo.h
74​ waylandtasksmodel.h
75​ ${CMAKE_CURRENT_BINARY_DIR}/taskmanager_export.h
76​ DESTINATION ${KDE_INSTALL_INCLUDEDIR}/taskmanager COMPONENT Devel
77​)
78​
79​if (X11_FOUND)
80​ install(FILES
81​ xwindowtasksmodel.h
82​ ${CMAKE_CURRENT_BINARY_DIR}/taskmanager_export.h
83​ DESTINATION ${KDE_INSTALL_INCLUDEDIR}/taskmanager COMPONENT Devel
84​ )
85​endif()
86​
87​write_basic_config_version_file(${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfigVersion.cmake VERSION "${PROJECT_VERSION}" COMPATIBILITY AnyNewerVersion)
davidedmundsonUnsubmitted
Done

add_definitions(-DTRANSLATION_DOMAIN=...)

somewhere in this file

davidedmundson: add_definitions(-DTRANSLATION_DOMAIN=...) somewhere in this file
88​
89​set(CMAKECONFIG_INSTALL_DIR ${KDE_INSTALL_LIBDIR}/cmake/LibTaskManager)
90​
91​ecm_configure_package_config_file(LibTaskManagerConfig.cmake.in
92​ "${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfig.cmake"
93​ INSTALL_DESTINATION ${CMAKECONFIG_INSTALL_DIR})
94​
95​install(FILES ${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfig.cmake
96​ ${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfigVersion.cmake
97​ DESTINATION ${CMAKECONFIG_INSTALL_DIR})
98​
99​install(EXPORT libtaskmanagerLibraryTargets
100​ NAMESPACE PW::
101​ DESTINATION ${CMAKECONFIG_INSTALL_DIR}
102​ FILE LibTaskManagerLibraryTargets.cmake )
103​
104​install(FILES taskmanagerrulesrc
105​ DESTINATION ${KDE_INSTALL_CONFDIR})