Differential D20535 Diff 56190 src/core/machineinfo.cpp

Changeset View

Standalone View

View Options

src/core/machineinfo.cpp

  • This file was added.
1​/* AtCore
2​ Copyright (C) <2019>
3​
4​ Authors:
5​ Chris Rizzitello <rizzitello@kde.org>
6​
7​ This library is free software; you can redistribute it and/or
8​ modify it under the terms of the GNU Lesser General Public
9​ License as published by the Free Software Foundation; either
10​ version 2.1 of the License, or (at your option) version 3, or any
11​ later version accepted by the membership of KDE e.V. (or its
12​ successor approved by the membership of KDE e.V.), which shall
13​ act as a proxy defined in Section 6 of version 3 of the license.
14​
15​ This library is distributed in the hope that it will be useful,
16​ but WITHOUT ANY WARRANTY; without even the implied warranty of
17​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18​ Lesser General Public License for more details.
19​
20​ You should have received a copy of the GNU Lesser General Public
21​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
22​*/
23​
24​#include "machineinfo.h"
25​
26​#include <QCoreApplication>
27​#include <QDir>
28​#include <QFile>
29​#include <QMetaEnum>
30​
31​const QMap<MachineInfo::KEY, QString> MachineInfo::nameMap = {
32​ {NAME, QStringLiteral("Name")}
33​ , {BAUDRATE, QStringLiteral("bps")}
patrickelectricUnsubmitted
Done

Use {foo}, to create a single indentation

patrickelectric: Use `{foo},` to create a single indentation
34​ , {FIRMWARE, QStringLiteral("firmware")}
35​ , {MAXBEDTEMP, QStringLiteral("maximumTemperatureBed")}
36​ , {MAXEXTTEMP, QStringLiteral("maximumTemperatureExtruder")}
37​ , {POSTPAUSE, QStringLiteral("postPause")}
38​ , {HEATEDBED, QStringLiteral("heatedBed")}
39​ , {ISCARTESIAN, QStringLiteral("isCartesian")}
40​ , {XMAX, QStringLiteral("dimensionX")}
41​ , {YMAX, QStringLiteral("dimensionY")}
42​ , {ZMAX, QStringLiteral("dimensionZ")}
43​ , {AUTOTEMPREPORT, QStringLiteral("autoReportTemp")}
44​};
45​
46​const MachineInfo &MachineInfo::getInstance()
patrickelectricUnsubmitted
Done

This should be a pointer to be accessible in qml;

patrickelectric: This should be a pointer to be accessible in qml;
rizzitelloAuthorUnsubmitted
Done

I was thinking it would be used like this in the main cpp file

qmlEngine.rootContext()->setContextProperty("machineInfo", MachineInfo::getInstance());
rizzitello: I was thinking it would be used like this in the main cpp file qmlEngine.rootContext()…
patrickelectricUnsubmitted
Done

you just need to register as a singleton, please use a pointer.
google for qmlregistersingletontype

patrickelectric: you just need to register as a singleton, please use a pointer. google for…
patrickelectricUnsubmitted
Done

You should return a pointer, but you don't need to create the object in the heap.

static MachineInfo m;
return &m;

Do not forget to set the ownership to cpp

patrickelectric: You should return a pointer, but you don't need to create the object in the heap. ```…
47​{
48​ static MachineInfo m;
49​ return m;
50​}
51​
52​MachineInfo::MachineInfo(QObject *parent) : QObject(parent)
53​{
54​ if (QFile(QString(QCoreApplication::applicationDirPath() + QDir::separator() + QStringLiteral("profiles.ini"))).exists()) {
55​ m_settings = new QSettings(QCoreApplication::applicationDirPath() + QDir::separator() + QStringLiteral("profiles"), QSettings::IniFormat, this);
56​ } else {
57​ m_settings = new QSettings(QSettings::IniFormat, QSettings::UserScope, QStringLiteral("atcore"), QStringLiteral("profiles"), this);
58​ }
patrickelectricUnsubmitted
Done

Why not a QMap<MachineInfo::KEY, QPair<QString, QVariant>> ?

patrickelectric: Why not a QMap<MachineInfo::KEY, QPair<QString, QVariant>> ?
rizzitelloAuthorUnsubmitted
Not Done

made a small struct with keyString and defaultValue Instaed but a similar idea.

rizzitello: made a small struct with keyString and defaultValue Instaed but a similar idea.
59​}
patrickelectricUnsubmitted
Done

is it possible to do this population with a for loop ?

patrickelectric: is it possible to do this population with a for loop ?
60​
61​QVariantMap MachineInfo::profile(const QString &profileName) const
62​{
63​ m_settings->beginGroup(profileName);
64​ QVariantMap data{
65​ {nameMap[BAUDRATE], m_settings->value(nameMap[BAUDRATE], QStringLiteral("115200"))}
patrickelectricUnsubmitted
Done

This values should be somewhere else no in the middle of the code. We should create a const standard profile in the class.

patrickelectric: This values should be somewhere else no in the middle of the code. We should create a const…
66​ , {nameMap[MAXBEDTEMP], m_settings->value(nameMap[MAXBEDTEMP], QStringLiteral("0"))}
67​ , {nameMap[MAXEXTTEMP], m_settings->value(nameMap[MAXEXTTEMP], QStringLiteral("0"))}
68​ , {nameMap[FIRMWARE], m_settings->value(nameMap[FIRMWARE], QStringLiteral("Auto-Detect"))}
patrickelectricUnsubmitted
Done

this is not necessary, you just need to save the settings inside a profiles configuration list.

patrickelectric: this is not necessary, you just need to save the settings inside a profiles configuration list.
69​ , {nameMap[POSTPAUSE], m_settings->value(nameMap[POSTPAUSE], QString())}
patrickelectricUnsubmitted
Not Done

does not need to be a pointer.

patrickelectric: does not need to be a pointer.
70​ , {nameMap[HEATEDBED], m_settings->value(nameMap[HEATEDBED], true)}
71​ , {nameMap[NAME], m_settings->group()}
72​ , {nameMap[ISCARTESIAN], m_settings->value(nameMap[ISCARTESIAN], true)}
73​ , {nameMap[XMAX], m_settings->value(nameMap[XMAX], QStringLiteral("200"))}
74​ , {nameMap[YMAX], m_settings->value(nameMap[YMAX], QStringLiteral("200"))}
75​ , {nameMap[ZMAX], m_settings->value(nameMap[ZMAX], QStringLiteral("180"))}
76​ , {nameMap[AUTOTEMPREPORT], m_settings->value(nameMap[AUTOTEMPREPORT], false)}
77​ };
patrickelectricUnsubmitted
Done

This line is huge.

patrickelectric: This line is huge.
78​ m_settings->endGroup();
79​ return data;
80​}
81​
82​void MachineInfo::storeProfile(const QMap<MachineInfo::KEY, QVariant> &profile) const
83​{
patrickelectricUnsubmitted
Done

qCWarning missing

patrickelectric: qCWarning missing
84​ m_settings->beginGroup(profile[NAME].toString());
85​ m_settings->setValue(nameMap[FIRMWARE], profile[FIRMWARE]);
86​ m_settings->setValue(nameMap[BAUDRATE], profile[BAUDRATE]);
87​ m_settings->setValue(nameMap[MAXBEDTEMP], profile[MAXBEDTEMP]);
patrickelectricUnsubmitted
Done

qCWarning missing

patrickelectric: qCWarning missing
rizzitelloAuthorUnsubmitted
Done

This is triggered a bunch of times. You see it with the profile manager If your starting profile shares any values with what the defaults are set to one warning per instance of that same if you change between profiles and they any profile data in common you will get more of these in the log.

rizzitello: This is triggered a bunch of times. You see it with the profile manager If your starting…
88​ m_settings->setValue(nameMap[MAXEXTTEMP], profile[MAXEXTTEMP]);
89​ m_settings->setValue(nameMap[POSTPAUSE], profile[POSTPAUSE]);
90​ m_settings->setValue(nameMap[HEATEDBED], profile[HEATEDBED]);
91​ m_settings->setValue(nameMap[ISCARTESIAN], profile[ISCARTESIAN]);
92​ m_settings->setValue(nameMap[XMAX], profile[XMAX]);
93​ m_settings->setValue(nameMap[YMAX], profile[YMAX]);
94​ m_settings->setValue(nameMap[ZMAX], profile[ZMAX]);
95​ m_settings->setValue(nameMap[AUTOTEMPREPORT], profile[AUTOTEMPREPORT]);
96​ m_settings->endGroup();
97​ emit profileChanged(profile[NAME].toString());
98​}
99​
100​QStringList MachineInfo::profileNames() const
101​{
patrickelectricUnsubmitted
Done

if does not contain return false, avoid indentation.

patrickelectric: if does not contain return false, avoid indentation.
102​ QStringList groups = m_settings->childGroups();
103​ return groups;
104​}
105​
patrickelectricUnsubmitted
Done

can you return childGRoups directly ? why m_settings is a pointer ?

patrickelectric: can you return childGRoups directly ? why m_settings is a pointer ?
patrickelectricUnsubmitted
Done

qCWarning missing

patrickelectric: qCWarning missing
patrickelectricUnsubmitted
Done

qCWarning missing

patrickelectric: qCWarning missing
patrickelectricUnsubmitted
Done

qCWarning missing

patrickelectric: qCWarning missing
patrickelectricUnsubmitted
Done

qCWarning missing

patrickelectric: qCWarning missing
patrickelectricUnsubmitted
Done

is it possible to do that with a for ?

patrickelectric: is it possible to do that with a for ?