Differential D20467 Diff 56091 src/dialogs/katedialogs.cpp

Changeset View

Standalone View

View Options

src/dialogs/katedialogs.cpp

Show First 20 Lines • Show All 1285 Lines • ▼ Show 20 Line(s)1274 if (!onDiskDeleted) {
1286 } 1286​ }
1287 1287​
1288 QAction * aReload = new QAction(i18n("&Reload"), this); 1288​ QAction * aReload = new QAction(i18n("&Reload"), this);
1289 aReload->setIcon(QIcon::fromTheme(QStringLiteral("view-refresh"))); 1289​ aReload->setIcon(QIcon::fromTheme(QStringLiteral("view-refresh")));
1290 aReload->setToolTip(i18n("Reload the file from disk. Unsaved changes will be lost.")); 1290​ aReload->setToolTip(i18n("Reload the file from disk. Unsaved changes will be lost."));
1291 m_message->addAction(aReload); 1291​ m_message->addAction(aReload);
1292 connect(aReload, SIGNAL(triggered()), this, SIGNAL(reloadTriggered())); 1292​ connect(aReload, SIGNAL(triggered()), this, SIGNAL(reloadTriggered()));
1293 } else { 1293​ } else {
1294​ QAction * closeFile = new QAction(i18n("&Close"), this);
1295​ closeFile->setIcon(QIcon::fromTheme(QStringLiteral("document-close")));
1296​ closeFile->setToolTip(i18n("Close the file, discarding its content."));
ngrahamUnsubmitted
Done

file discarding -> file, discarding

ngraham: `file discarding` -> `file, discarding`
1297​ m_message->addAction(closeFile, false);
1298​ connect(closeFile, &QAction::triggered, this, &KateModOnHdPrompt::closeTriggered);
dhaumannUnsubmitted
Done

Could you switch this to new style signal slot syntax? In a separate review request would also be fine.

dhaumann: Could you switch this to new style signal slot syntax? In a separate review request would also…
1299​
1294 QAction * aSaveAs = new QAction(i18n("&Save As..."), this); 1300​ QAction * aSaveAs = new QAction(i18n("&Save As..."), this);
1295 aSaveAs->setIcon(QIcon::fromTheme(QStringLiteral("document-save-as"))); 1301​ aSaveAs->setIcon(QIcon::fromTheme(QStringLiteral("document-save-as")));
1296 aSaveAs->setToolTip(i18n("Lets you select a location and save the file again.")); 1302​ aSaveAs->setToolTip(i18n("Lets you select a location and save the file again."));
1297 m_message->addAction(aSaveAs, false); 1303​ m_message->addAction(aSaveAs, false);
1298 connect(aSaveAs, SIGNAL(triggered()), this, SIGNAL(saveAsTriggered())); 1304​ connect(aSaveAs, SIGNAL(triggered()), this, SIGNAL(saveAsTriggered()));
1299 } 1305​ }
1300 1306​
1301 QAction * aIgnore = new QAction(i18n("&Ignore"), this); 1307​ QAction * aIgnore = new QAction(i18n("&Ignore"), this);
▲ Show 20 Lines • Show All 95 Lines • Show Last 20 Lines