Differential D18604 Diff 55428 autotests/taglibwritertest.cpp

Changeset View

Standalone View

View Options

autotests/taglibwritertest.cpp

Show First 20 Lines • Show All 337 Lines • ▼ Show 20 Line(s)335 QTest::addRow("wav")
338 ; 338​ ;
339 339​
340 QTest::addRow("wavpack") 340​ QTest::addRow("wavpack")
341 << QStringLiteral("wv") 341​ << QStringLiteral("wv")
342 << QStringLiteral("audio/x-wavpack") 342​ << QStringLiteral("audio/x-wavpack")
343 ; 343​ ;
344} 344​}
345 345​
346​void TagLibWriterTest::testRating()
347​{
348​ QFETCH(QString, fileType);
349​ QFETCH(QString, mimeType);
350​ QFETCH(int, rating);
351​
352​ QString temporaryFileName = QStringLiteral("writertest.") + fileType;
353​
354​ QFile::copy(testFilePath("test.") + fileType, testFilePath(temporaryFileName));
355​ TagLibWriter writerPlugin{this};
356​ QCOMPARE(writerPlugin.writeMimetypes().contains(mimeType),true);
357​
358​ WriteData data(testFilePath(temporaryFileName), mimeType);
359​
360​ data.add(Property::Rating, rating);
361​ writerPlugin.write(data);
362​
363​ KFileMetaData::ExtractorCollection extractors;
364​ QList<KFileMetaData::Extractor*> extractorList = extractors.fetchExtractors(mimeType);
365​ if (extractorList.isEmpty())
366​ QFAIL("This mime type is not supported by the extractor. Likely a newer KDE Frameworks version is required.");
367​ KFileMetaData::Extractor* ex = extractorList.first();
368​ KFileMetaData::SimpleExtractionResult result(testFilePath(temporaryFileName), mimeType,
369​ KFileMetaData::ExtractionResult::ExtractMetaData);
370​
371​ ex->extract(&result);
372​ QCOMPARE(result.properties().value(Property::Rating).toInt(), rating);
373​
374​ QFile::remove(testFilePath(temporaryFileName));
375​}
376​
377​void TagLibWriterTest::testRating_data()
378​{
379​
380​ QTest::addColumn<QString>("fileType");
381​ QTest::addColumn<QString>("mimeType");
382​ QTest::addColumn<int>("rating");
383​
384​ QTest::addRow("aiff")
385​ << QStringLiteral("aif")
386​ << QStringLiteral("audio/x-aiff")
387​ << 3
388​ ;
389​
390​ QTest::addRow("ape")
391​ << QStringLiteral("ape")
392​ << QStringLiteral("audio/x-ape")
393​ << 1
394​ ;
395​
396​ QTest::addRow("flac")
397​ << QStringLiteral("flac")
398​ << QStringLiteral("audio/flac")
399​ << 3
400​ ;
401​
402​ QTest::addRow("m4a")
403​ << QStringLiteral("m4a")
404​ << QStringLiteral("audio/mp4")
405​ << 5
406​ ;
407​
408​ QTest::addRow("mp3_0")
409​ << QStringLiteral("mp3")
brunsUnsubmitted
Not Done

What are the differences between the various mp3 test cases?

bruns: What are the differences between the various mp3 test cases?
astippichAuthorUnsubmitted
Not Done

It tests all possible ratings, since the commonly used numbers are somewhat arbitrary, and I wanted to make sure writing and extracting works

astippich: It tests all possible ratings, since the commonly used numbers are somewhat arbitrary, and I…
410​ << QStringLiteral("audio/mpeg3")
411​ << 0
412​ ;
413​
414​ QTest::addRow("mp3_1")
415​ << QStringLiteral("mp3")
416​ << QStringLiteral("audio/mpeg3")
417​ << 1
418​ ;
419​
420​ QTest::addRow("mp3_2")
421​ << QStringLiteral("mp3")
422​ << QStringLiteral("audio/mpeg3")
423​ << 2
424​ ;
425​
426​ QTest::addRow("mp3_3")
427​ << QStringLiteral("mp3")
428​ << QStringLiteral("audio/mpeg3")
429​ << 3
430​ ;
431​
432​ QTest::addRow("mp3_4")
433​ << QStringLiteral("mp3")
434​ << QStringLiteral("audio/mpeg3")
435​ << 4
436​ ;
437​
438​ QTest::addRow("mp3_5")
439​ << QStringLiteral("mp3")
440​ << QStringLiteral("audio/mpeg3")
441​ << 5
442​ ;
443​
444​ QTest::addRow("mp3_6")
445​ << QStringLiteral("mp3")
446​ << QStringLiteral("audio/mpeg3")
447​ << 6
448​ ;
449​
450​ QTest::addRow("mp3_7")
451​ << QStringLiteral("mp3")
452​ << QStringLiteral("audio/mpeg3")
453​ << 7
454​ ;
455​
456​ QTest::addRow("mp3_8")
457​ << QStringLiteral("mp3")
458​ << QStringLiteral("audio/mpeg3")
459​ << 8
460​ ;
461​
462​ QTest::addRow("mp3_9")
463​ << QStringLiteral("mp3")
464​ << QStringLiteral("audio/mpeg3")
465​ << 9
466​ ;
467​
468​ QTest::addRow("mp3_10")
469​ << QStringLiteral("mp3")
470​ << QStringLiteral("audio/mpeg3")
471​ << 10
472​ ;
473​
474​ QTest::addRow("mpc")
475​ << QStringLiteral("mpc")
476​ << QStringLiteral("audio/x-musepack")
477​ << 7
478​ ;
479​
480​ QTest::addRow("opus")
481​ << QStringLiteral("opus")
482​ << QStringLiteral("audio/opus")
483​ << 6
484​ ;
485​
486​ QTest::addRow("speex")
487​ << QStringLiteral("spx")
488​ << QStringLiteral("audio/speex")
489​ << 8
490​ ;
491​
492​ QTest::addRow("wav")
493​ << QStringLiteral("wav")
494​ << QStringLiteral("audio/wav")
495​ << 4
496​ ;
497​
498​ QTest::addRow("wavpack")
499​ << QStringLiteral("wv")
500​ << QStringLiteral("audio/x-wavpack")
501​ << 9
502​ ;
503​
504​ QTest::addRow("wma_0")
505​ << QStringLiteral("wma")
506​ << QStringLiteral("audio/x-ms-wma")
507​ << 0
508​ ;
509​
510​ QTest::addRow("wma_2")
511​ << QStringLiteral("wma")
512​ << QStringLiteral("audio/x-ms-wma")
513​ << 2
514​ ;
515​
516​ QTest::addRow("wma_4")
517​ << QStringLiteral("wma")
518​ << QStringLiteral("audio/x-ms-wma")
519​ << 4
520​ ;
521​
522​ QTest::addRow("wma_5")
523​ << QStringLiteral("wma")
524​ << QStringLiteral("audio/x-ms-wma")
525​ << 5
526​ ;
527​
528​ QTest::addRow("wma_6")
529​ << QStringLiteral("wma")
530​ << QStringLiteral("audio/x-ms-wma")
531​ << 6
532​ ;
533​
534​ QTest::addRow("wma_8")
535​ << QStringLiteral("wma")
536​ << QStringLiteral("audio/x-ms-wma")
537​ << 8
538​ ;
539​
540​ QTest::addRow("wma_10")
541​ << QStringLiteral("wma")
542​ << QStringLiteral("audio/x-ms-wma")
543​ << 10
544​ ;
545​}
546​
346QTEST_GUILESS_MAIN(TagLibWriterTest) 547​QTEST_GUILESS_MAIN(TagLibWriterTest)