Differential D18230 Diff 55046 src/activities/question_and_answer/Question_and_answer.qml

Changeset View

Standalone View

View Options

src/activities/question_and_answer/Question_and_answer.qml

  • This file was added.
1​/* GCompris - question_and_answer.qml
2​ *
3​ * Copyright (C) 2018 Amit Sagtani <asagtani06@gmail.com>
4​ *
5​ * Authors:
6​ * Amit Sagtani <asagtani06@gmail.com>
7​ *
8​ * This program is free software; you can redistribute it and/or modify
9​ * it under the terms of the GNU General Public License as published by
10​ * the Free Software Foundation; either version 3 of the License, or
11​ * (at your option) any later version.
12​ *
13​ * This program is distributed in the hope that it will be useful,
14​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
15​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16​ * GNU General Public License for more details.
17​ *
18​ * You should have received a copy of the GNU General Public License
19​ * along with this program; if not, see <http://www.gnu.org/licenses/>.
20​ */
21​import QtQuick 2.6
22​import GCompris 1.0
23​import QtQuick.Controls 1.5
24​import QtQuick.Layouts 1.1
25​import QtQuick.Controls.Styles 1.4
26​
27​import "../../core"
28​import "question_and_answer.js" as Activity
29​
30​ActivityBase {
echarruauUnsubmitted
Done

You need to remove this line, otherwise it does not compile.

echarruau: You need to remove this line, otherwise it does not compile.
31​ id: activity
32​ onStart: focus = true
33​ onStop: {}
34​ pageComponent: Image {
echarruauUnsubmitted
Done

I get the following message when running
qrc:/gcompris/src/activities/question_and_answer/Question_and_answer.qml:33: ReferenceError: Dataset is not defined

echarruau: I get the following message when running qrc…
35​ id: background
36​ anchors.fill: parent
37​ source: "qrc:/gcompris/src/activities/algebra_by/resource/background.svg"
38​ signal start
39​ signal stop
40​
41​ Component.onCompleted: {
42​ dialogActivityConfig.getInitialConfiguration()
43​ activity.start.connect(start)
44​ activity.stop.connect(stop)
45​ }
jjazeixUnsubmitted
Done

missing dialogActivityConfig.getInitialConfiguration() to initialize the config dialog

jjazeix: missing dialogActivityConfig.getInitialConfiguration() to initialize the config dialog
46​
47​ // Add here the QML items you need to access in javascript
48​ QtObject {
49​ id: items
50​ property Item main: activity.main
51​ property alias background: background
52​ property alias bar: bar
53​ property alias bonus: bonus
54​ property alias menuScreen: menuScreen
55​ property alias menuModel: menuScreen.menuModel
56​ property alias startFinishButton: startFinishButton
57​ property string currentMode: "freeMode"
58​ property alias questionsGrid: questionsGrid
59​ property alias sampleQuestion: sampleQuestion
60​ property alias playArea: playArea
61​ property alias parser: parser
62​ property int noOfQuestions
63​ property int sampleWidth: 750
64​ property bool levelStarted: false
echarruauUnsubmitted
Not Done

Seems like a hard coded value?

echarruau: Seems like a hard coded value?
AkshayCHDAuthorUnsubmitted
Not Done

No these values change depending on the number of questions in the json

AkshayCHD: No these values change depending on the number of questions in the json
65​ property bool showAnswerStatus: false
jjazeixUnsubmitted
Done

int?

jjazeix: int?
66​ property var questions: []
67​ property var answers: []
68​ property var allQuestions: []
69​ property var longestQuestion: ""
jjazeixUnsubmitted
Done

if it is a string, use a string (else keep it as var)

jjazeix: if it is a string, use a string (else keep it as var)
jjazeixUnsubmitted
Not Done

it's really not a string?

jjazeix: it's really not a string?
70​ property int questionsCount: 0
71​ property var hash: []
72​ property int currentSubActivity
jjazeixUnsubmitted
Done

int?

jjazeix: int?
73​ property var buttonType: "submit"
74​ property bool editAnswers: false
jjazeixUnsubmitted
Done

int?

jjazeix: int?
75​ }
76​
77​ onStart: { Activity.init(items) }
78​ onStop: { Activity.stop() }
79​
80​ JsonParser {
81​ id: parser
82​ }
83​
84​ GCText {
85​ id: noQuestionText
86​ visible: (items.questions.length === 0)
87​ anchors.verticalCenter: playArea.verticalCenter
88​ horizontalAlignment: Text.AlignHCenter
jjazeixUnsubmitted
Done

you haven't

jjazeix: you haven't
89​ width: playArea.width
90​ text: qsTr("Please select at least one question in the configuration screen.")
91​ z: 1
92​ wrapMode: Text.WordWrap
93​ color: "white"
94​ fontSize: regularSize
95​ }
96​
97​ GCText {
98​ id: sampleQuestion
99​ visible: false
100​ width: (background.width < background.height) ? playArea.width / 2 :(text.length > 20) ? playArea.width / 2 : playArea.width / 5
101​ height: (text.length > 20) ? contentHeight : 200
102​ wrapMode: Text.WordWrap
103​ color: "white"
104​ fontSize: smallSize
105​ }
106​
107​ Rectangle {
108​ id: playArea
109​ width: background.width * 0.95
110​ height: (background.width > background.height) ? background.height * 0.90 - bar.height : background.height * 0.90 - bar.height - startFinishButton.width
111​ border.color: "black"
112​ border.width: 5
113​ anchors.horizontalCenter: parent.horizontalCenter
114​ anchors.top: background.top
115​ anchors.topMargin: 60
116​ color: "#32000000"
117​ radius: 20
118​ }
119​
120​ GridView {
121​ id: questionsGrid
122​ visible: false
123​ model: items.questions.length
124​ anchors.top: playArea.top
125​ anchors.left: playArea.left
126​ anchors.leftMargin: 30
127​ width: playArea.width
128​ height: playArea.height - 200
129​ anchors.horizontalCenter: playArea.horizontalCenter
130​ cellHeight: (sampleQuestion.height < sampleQuestion.width * 0.1) ? sampleQuestion.height * 2 : sampleQuestion.height * 1.2
131​ cellWidth: sampleQuestion.width * 2
132​ property int spacing: 60
133​ delegate:
134​ Item {
135​ id: questionItem
136​ state: "short"
137​ property alias text: sampleAnswer.text
138​ GCText {
139​ id: questionText
140​ text: items.questions[index]
141​ wrapMode: Text.WordWrap
142​ horizontalAlignment: Text.AlignHCenter
143​ fontSize: smallSize
144​ verticalAlignment: Text.AlignVCenter
145​ width: questionsGrid.cellWidth * 0.5
146​ height: questionsGrid.cellHeight
147​ fontSizeMode: Text.Fit
148​ }
149​ GCText {
150​ id: sampleAnswer
151​ visible: false
152​ height: getHeight()
153​ width: questionsGrid.cellWidth * 0.3
154​ wrapMode: Text.WordWrap
155​ color: "white"
156​ fontSize: tinySize
157​ function getHeight() {
158​ if(text.length > 20) {
159​ if(contentHeight > questionsGrid.cellHeight * 0.8) {
160​ return questionsGrid.cellHeight * 0.8
161​ } else {
162​ return contentHeight * 1.1
163​ }
164​ } else {
165​ return bar.height * 0.4
166​ }
167​ }
168​ }
169​ Rectangle {
170​ id: answerRectangle
171​ border.color: "black"
172​ border.width: 5
173​ radius: 10
174​ anchors.left: questionText.right
175​ width: getWidth()
176​ height: sampleAnswer.height * 0.8
177​ property alias cellWidth: questionText.width
178​ property real cellHeight: questionsGrid.cellHeight
179​ property alias text: questionItem.text
180​ color: "transparent"
181​ function getWidth() {
182​ if(sampleAnswer.contentWidth < questionsGrid.cellWidth * 0.3) {
183​ if(sampleAnswer.contentWidth < questionsGrid.cellWidth * 0.1)
184​ return questionsGrid.cellWidth * 0.1
185​ else
186​ return sampleAnswer.contentWidth * 1.2
187​ } else {
188​ return questionsGrid.cellWidth * 0.3
189​ }
190​ }
191​ TextArea {
192​ id: answerText
193​ width: parent.width
194​ height: parent.height
195​ anchors.left: parent.left
196​ anchors.verticalCenter: parent.verticalCenter
197​ anchors.topMargin: 20
198​ activeFocusOnPress: true
199​ readOnly: !items.editAnswers
200​ horizontalAlignment: TextInput.AlignHCenter
201​ implicitWidth: bar.height * 0.9
202​ implicitHeight: 130/800*parent.width
203​ text: answerRectangle.text
204​ font.pixelSize: 24
205​ backgroundVisible: false
206​
207​ onTextChanged:{
208​ answerRectangle.text = answerText.text
209​ }
210​
211​ onActiveFocusChanged: {
212​ if (!items.levelStarted && items.buttonType != "restart") {
213​ items.levelStarted = true
214​ items.startFinishButton.visibility = true
215​ items.editAnswers = true
216​ answerText.focus = true
217​ }
jjazeixUnsubmitted
Done

it seems you never actually store the parameters in the config file, so if you do changes, quit the game and restart it, everything is lost?
There is three methods in the item that should be used:
onLoadData, onSaveData and you should set the default values via setDefaultValues instead of doing everything in the onConfigClicked signal.

jjazeix: it seems you never actually store the parameters in the config file, so if you do changes, quit…
218​ }
219​ }
220​ }
221​ Image {
222​ id: question_image
223​ width: 50
224​ height: 50
225​ visible: items.showAnswerStatus
226​ fillMode: Image.PreserveAspectFit
227​ source: (answerRectangle.text).trim() === items.answers[index] ?
228​ "qrc:/gcompris/src/activities/question_and_answer/resource/right.svg" :
229​ "qrc:/gcompris/src/activities/photo_hunter/resource/wrong.svg"
230​ }
231​
232​ states: [
233​ State {
234​ name: "short"
235​ when: (items.sampleQuestion.contentHeight <= items.playArea.height) || questionText.text.length < 0.5 * items.longestQuestion.length
jjazeixUnsubmitted
Done

if you use an ExclusiveGroup, you won't need to change the other CheckBox

jjazeix: if you use an ExclusiveGroup, you won't need to change the other CheckBox
236​
237​ PropertyChanges {
238​ target: questionText
239​ width: questionsGrid.cellWidth * 0.5
240​ height: questionsGrid.cellHeight
241​ }
242​ PropertyChanges {
243​ target: answerRectangle
jjazeixUnsubmitted
Done

unused?

jjazeix: unused?
244​ anchors.left: questionText.right
245​ anchors.leftMargin: 50
246​ anchors.verticalCenter: questionText.verticalCenter
247​ anchors.horizontalCenter: undefined
248​ }
249​ PropertyChanges {
250​ target: question_image
251​ anchors.verticalCenter: questionText.verticalCenter
252​ anchors.left: answerRectangle.right
253​ anchors.top: questionText.top
254​ }
255​ },
256​ State {
257​ name: "long"
258​ when: (items.sampleQuestion.contentHeight > items.playArea.height) && questionText.text.length > 0.5 * items.longestQuestion.length
259​ PropertyChanges {
260​ target: questionText
261​ width: questionsGrid.cellWidth - 40
262​ height: questionsGrid.cellHeight * 0.3
263​ }
264​ PropertyChanges {
265​ target: answerRectangle
266​ anchors.top: questionText.bottom
267​ anchors.horizontalCenter: questionText.horizontalCenter
268​ anchors.verticalCenter: undefined
269​ anchors.left: undefined
270​ }
jjazeixUnsubmitted
Done

use GCText, not Text to have the same font everywhere

jjazeix: use GCText, not Text to have the same font everywhere
271​ PropertyChanges {
272​ target: question_image
273​ anchors.left: answerRectangle.right
274​ anchors.top: answerRectangle.top
275​ anchors.verticalCenter: answerRectangle.verticalCenter
276​ }
277​ }
278​ ]
279​ }
280​
281​ }
282​ MenuScreen {
283​ id: menuScreen
284​ z:2
285​ }
286​
287​ BarButton {
288​ id: startFinishButton
289​ property bool visibility: true
290​ source: "qrc:/gcompris/src/core/resource/bar_ok.svg"
291​ height: bar.height * 0.8
292​ width: startFinishButton.height
293​ sourceSize.width: startFinishButton.width
294​ sourceSize.height: startFinishButton.height
295​ z: 10
296​ anchors.top: playArea.bottom
297​ anchors.right: playArea.right
298​ visible: !menuScreen.visible && visibility && !noQuestionText.visible
299​ ParticleSystemStarLoader {
300​ id: okButtonParticles
301​ clip: false
302​ }
303​ onClicked: {
304​ if(items.buttonType == "submit") {
305​ if(items.levelStarted) {
306​ items.showAnswerStatus = true
307​ items.levelStarted = false
308​ items.buttonType = "restart"
309​ startFinishButton.source = "qrc:/gcompris/src/core/resource/bar_reload.svg"
310​ items.editAnswers = false
311​ }
312​ } else {
313​ Activity.restartLevel()
314​ items.buttonType = "submit"
315​ startFinishButton.source = "qrc:/gcompris/src/core/resource/bar_ok.svg"
316​ startFinishButton.visibility = false
317​ items.editAnswers = false
318​ }
319​ }
320​ }
321​
322​ BarButton {
323​ id: sandClock
324​ source: "qrc:/gcompris/src/activities/question_and_answer/resource/sandClock.svg"
325​ visible: startFinishButton.visible && items.buttonType != "restart"
326​ height: bar.height * 0.5
327​ anchors.verticalCenter: startFinishButton.verticalCenter
328​ anchors.margins: 20
329​ width: startFinishButton.height / 2
330​ sourceSize.width: startFinishButton.width
331​ sourceSize.height: startFinishButton.height
332​ z: 10
333​ anchors.top: playArea.bottom
334​ anchors.right: startFinishButton.left
335​ ParticleSystemStarLoader {
336​ id: okButtonParticles2
337​ clip: false
338​ }
339​ }
340​ SequentialAnimation {
341​ id: anim
342​ running: true
343​ loops: Animation.Infinite
344​ NumberAnimation {
345​ target: sandClock
346​ property: "rotation"
347​ from: -10; to: 10
348​ duration: 700
349​ easing.type: Easing.InOutQuad
350​ }
351​ NumberAnimation {
352​ target: sandClock
353​ property: "rotation"
354​ from: 10; to: -10
355​ duration: 700
356​ easing.type: Easing.InOutQuad
357​ }
358​ }
359​
360​ ExclusiveGroup {
361​ id: configOptions
362​ }
363​
364​ DialogActivityConfig {
365​ id: dialogActivityConfig
366​ currentActivity: activity
367​ content: Component {
368​ Item {
369​ width: dialogActivityConfig.width
370​ height: dialogActivityConfig.height
371​ property alias grid: grid
372​ property alias adminMode: adminMode
373​ GCDialogCheckBox {
374​ id: freeMode
375​ width: parent.width - 50
jjazeixUnsubmitted
Done

you can use of temp variable to store the children, it will be easier to read after

jjazeix: you can use of temp variable to store the children, it will be easier to read after
376​ text: qsTr("Free Mode")
377​ checked: items.currentMode === "freeMode" ? true : false
378​ exclusiveGroup: configOptions
379​ onCheckedChanged: {
380​ if(checked) {
381​ items.currentMode = "freeMode"
382​ adminMode.checked = false
383​
384​ }
385​ Activity.modeChanged()
386​ }
387​ }
388​
389​ GCDialogCheckBox {
390​ id: adminMode
391​ width: parent.width - 50
392​ text: qsTr("Admin Mode")
393​ checked: items.currentMode === "adminMode" ? true : false
394​ anchors.top: freeMode.bottom
395​ exclusiveGroup: configOptions
396​ onCheckedChanged: {
397​ if(checked) {
398​ items.currentMode = "adminMode"
399​ freeMode.checked = false
400​ }
401​ Activity.modeChanged()
402​ }
403​ }
404​
405​ CheckBox {
406​ id:sampleCheckBox
407​ text: items.longestQuestion
408​ checked: false
409​ width: ((dialogActivityConfig.width * 2) / (items.allQuestions[0].length)) * 0.9
410​ visible: false
411​ style: CheckBoxStyle {
412​ label: Text {
413​ text: items.longestQuestion
414​ wrapMode: Text.WordWrap
415​ anchors.leftMargin: 10
416​ }
417​ indicator: Rectangle {
418​ implicitWidth: sampleCheckBox.width / 5
419​ }
420​ }
421​ }
422​ GridView {
423​ id: grid
424​ width: dialogActivityConfig.width
425​ height: dialogActivityConfig.height
426​ anchors.top: adminMode.bottom
427​ visible: adminMode.checked
428​ anchors.topMargin: 30
429​ cellWidth: (dialogActivityConfig.width * 2) / (items.allQuestions[0].length)
430​ cellHeight: Math.max(sampleCheckBox.height, 40)
431​ model: items.questionsCount
432​ focus: true
433​ delegate: Component {
434​ id: contractDelegate
435​ CheckBox {
436​ id:checkBoxQuestion
437​ property int questionSet: items.hash[index][0]
438​ property int questionIndex: items.hash[index][1]
439​ checked: false
440​ width: grid.cellWidth * 0.9
441​ height: grid.cellHeight * 0.9
442​ style: CheckBoxStyle {
443​ label: Text {
444​ text: (items.allQuestions.length > 0) ? items.allQuestions[checkBoxQuestion.questionSet][checkBoxQuestion.questionIndex] : ""
445​ wrapMode: Text.WordWrap
446​ anchors.leftMargin: 10
447​ }
448​ indicator: Rectangle {
449​ implicitWidth: grid.cellWidth / 8
450​ implicitHeight: Math.max(grid.cellHeight / 2, 40)
451​ radius: 3
452​ border.color: control.activeFocus ? "darkblue" : "gray"
453​ border.width: 1
454​ Rectangle {
455​ visible: control.checked
456​ color: "#555"
457​ border.color: "#333"
458​ radius: 1
459​ anchors.margins: 4
460​ anchors.fill: parent
461​ }
462​ }
463​ }
464​ onCheckedChanged: {
465​ if(checked) {
466​ Activity.addQuestion(questionSet, questionIndex)
467​ } else {
468​ Activity.removeQuestion(items.allQuestions[questionSet][questionIndex])
469​ }
470​ }
471​ }
472​ }
473​ }
474​ }
475​ }
476​ onClose: {
477​ Activity.getMaxWidth()
478​ home()
479​ }
480​
481​ onLoadData: {
482​ if(dataToSave["currentMode"]) {
483​ items.currentMode = dataToSave["currentMode"]
484​ }
485​ }
486​ onSaveData: {
487​ dataToSave = {"currentMode": items.currentMode}
488​ }
489​
490​ function setDefaultValues() {
491​ items.levelStarted = false
492​ if (items.currentMode === "adminMode") {
493​ items.questions = []
494​ items.answers = []
495​ }
496​ dialogActivityConfig.active = true
497​ displayDialog(dialogActivityConfig)
498​ var dialogChildren = dialogActivityConfig.configItem.grid.contentItem.children
499​ for(var child in dialogChildren) {
500​ if (typeof dialogChildren[child].checked !== 'undefined') {
501​ dialogChildren[child].checked = false
502​ }
503​ }
504​ }
505​ }
506​
507​ DialogHelp {
508​ id: dialogHelp
509​ onClose: home()
510​ }
511​
512​ Bar {
513​ id: bar
514​ property BarEnumContent activityZoneContent: BarEnumContent { value: home | level | config}
515​ property BarEnumContent menuScreenContent: BarEnumContent { value: help | home }
516​ content: menuScreen.started ? menuScreenContent : activityZoneContent
517​ onHelpClicked: {
518​ displayDialog(dialogHelp)
519​ }
520​ onPreviousLevelClicked: Activity.previousLevel()
521​ onNextLevelClicked: Activity.nextLevel()
522​ onHomeClicked: {
523​ if(items.menuScreen.started)
524​ activity.home()
525​ else {
526​ Activity.launchMenuScreen()
527​ }
528​ }
529​ onConfigClicked: {
530​ dialogActivityConfig.setDefaultValues()
531​ }
532​ }
533​
534​ Bonus {
535​ id: bonus
536​ Component.onCompleted: win.connect(Activity.nextLevel)
537​ }
538​ }
539​
540​}