Changeset View
Changeset View
Standalone View
Standalone View
outputscreens.cpp
Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Line(s) | |||||
105 | Qt::ScreenOrientation OutputScreens::orientation(int screen) const | 105 | Qt::ScreenOrientation OutputScreens::orientation(int screen) const | ||
106 | { | 106 | { | ||
107 | const auto enOuts = m_platform->enabledOutputs(); | 107 | const auto enOuts = m_platform->enabledOutputs(); | ||
108 | if (screen >= enOuts.size()) { | 108 | if (screen >= enOuts.size()) { | ||
109 | return Qt::PrimaryOrientation; | 109 | return Qt::PrimaryOrientation; | ||
110 | } | 110 | } | ||
111 | return enOuts.at(screen)->orientation(); | 111 | return enOuts.at(screen)->orientation(); | ||
112 | } | 112 | } | ||
113 | int OutputScreens::rotation(int screen) const | ||||
114 | { | ||||
115 | const auto enOuts = m_platform->enabledOutputs(); | ||||
zzag: I know that you follow the rest of the code, but could you please rename this variable? | |||||
116 | if (screen >= enOuts.size()) { | ||||
117 | return 0; | ||||
zzag: return 0 | |||||
118 | } | ||||
119 | return enOuts.at(screen)->softwareRotationAngle(); | ||||
120 | } | ||||
113 | 121 | | |||
114 | void OutputScreens::updateCount() | 122 | void OutputScreens::updateCount() | ||
115 | { | 123 | { | ||
116 | setCount(m_platform->enabledOutputs().size()); | 124 | setCount(m_platform->enabledOutputs().size()); | ||
117 | } | 125 | } | ||
118 | 126 | | |||
119 | int OutputScreens::number(const QPoint &pos) const | 127 | int OutputScreens::number(const QPoint &pos) const | ||
120 | { | 128 | { | ||
Show All 21 Lines |
I know that you follow the rest of the code, but could you please rename this variable?
According to the Frameworks coding style, one shall not use short variable names.