Differential D20026 Diff 54815 src/widgets/kurlcombobox.h

Changeset View

Standalone View

View Options

src/widgets/kurlcombobox.h

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Line(s)56public:
105 /** 105​ /**
106 * Inserts @p urls into the combobox below the "default urls" (see 106​ * Inserts @p urls into the combobox below the "default urls" (see
107 * addDefaultUrl). 107​ * addDefaultUrl).
108 * 108​ *
109 * If the list of urls contains more items than maxItems, the first items 109​ * If the list of urls contains more items than maxItems, the first items
110 * will be stripped. 110​ * will be stripped.
111 */ 111​ */
112 void setUrls(const QStringList &urls); 112​ void setUrls(const QStringList &urls);
113​ void setUrls(const QStringList &urls, bool removeOld);
ngrahamUnsubmitted
Done

Too much indentation

ngraham: Too much indentation
113 114​
114 /** 115​ /**
115 * Inserts @p urls into the combobox below the "default urls" (see 116​ * Inserts @p urls into the combobox below the "default urls" (see
116 * addDefaultUrl). 117​ * addDefaultUrl).
117 * 118​ *
118 * If the list of urls contains more items than maxItems, the @p remove 119​ * If the list of urls contains more items than maxItems, the @p remove
119 * parameter determines whether the first or last items will be stripped. 120​ * parameter determines whether the first or last items will be stripped.
120 */ 121​ */
121 void setUrls(const QStringList &urls, OverLoadResolving remove); 122​ void setUrls(const QStringList &urls, OverLoadResolving remove);
123​ void setUrls(const QStringList &urls, OverLoadResolving remove, bool removeOld);
ngrahamUnsubmitted
Done

In general we prefer using Enums rather than bools for function arguments. It makes the code much more readable.

ngraham: In general we prefer using Enums rather than bools for function arguments. It makes the code…
122 124​
123 /** 125​ /**
124 * @returns a list of all urls currently handled. The list contains at most 126​ * @returns a list of all urls currently handled. The list contains at most
125 * maxItems() items. 127​ * maxItems() items.
126 * Use this to save the list of urls in a config-file and reinsert them 128​ * Use this to save the list of urls in a config-file and reinsert them
127 * via setUrls() next time. 129​ * via setUrls() next time.
128 * Note that all default urls set via addDefaultUrl() are not 130​ * Note that all default urls set via addDefaultUrl() are not
129 * returned, they will automatically be set via setUrls() or setUrl(). 131​ * returned, they will automatically be set via setUrls() or setUrl().
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines