Differential D19876 Diff 54614 src/syntax/katehighlight.cpp

Changeset View

Standalone View

View Options

src/syntax/katehighlight.cpp

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Line(s)58{
63 if (textStyle == KSyntaxHighlighting::Theme::Others) { 63​ if (textStyle == KSyntaxHighlighting::Theme::Others) {
64 return KTextEditor::dsOthers; 64​ return KTextEditor::dsOthers;
65 } 65​ }
66 66​
67 // else: simple cast 67​ // else: simple cast
68 return static_cast<KTextEditor::DefaultStyle>(textStyle); 68​ return static_cast<KTextEditor::DefaultStyle>(textStyle);
69} 69​}
70 70​
71​/**
72​ * convert the theme/schema name from KTextEditor => KSyntaxHighlighting.
73​ * NOTE: some themes of KTextEditor don't exist in KSyntaxHighlighting
74​ */
75​inline QString convertThemeName(const QString &themeName)
76​{
77​ if (themeName == QLatin1String("Normal")) {
78​ return QLatin1String("Default");
mwolffUnsubmitted
Done

return QStringLiteral, otherwise you allocate on every function call (also below)

mwolff: return QStringLiteral, otherwise you allocate on every function call (also below)
79​ } else if (themeName == QLatin1String("Solarized (light)")) {
80​ return QLatin1String("Solarized Light");
81​ } else if (themeName == QLatin1String("Solarized (dark)")) {
82​ return QLatin1String("Solarized Dark");
83​ }
84​ return themeName;
85​}
86​
71} 87​}
72//END 88​//END
73 89​
74//BEGIN KateHighlighting 90​//BEGIN KateHighlighting
75KateHighlighting::KateHighlighting(const KSyntaxHighlighting::Definition &def) 91​KateHighlighting::KateHighlighting(const KSyntaxHighlighting::Definition &def)
76{ 92​{
77 /** 93​ /**
78 * get name and section, always works 94​ * get name and section, always works
▲ Show 20 Lines • Show All 424 Lines • ▼ Show 20 Line(s)
503{ 519​{
504 // just clear the hashed attributes, we create them lazy again 520​ // just clear the hashed attributes, we create them lazy again
505 m_attributeArrays.clear(); 521​ m_attributeArrays.clear();
506} 522​}
507 523​
508QVector<KTextEditor::Attribute::Ptr> KateHighlighting::attributesForDefinition() 524​QVector<KTextEditor::Attribute::Ptr> KateHighlighting::attributesForDefinition()
509{ 525​{
510 /** 526​ /**
527​ * get the KSyntaxHighlighting theme from the chosen schema
528​ */
529​ KSyntaxHighlighting::Theme currentTheme = KateHlManager::self()->repository().theme(convertThemeName(KateRendererConfig::global()->schema()));
530​
531​ /**
511 * create list of all known things 532​ * create list of all known things
512 */ 533​ */
513 QVector<KTextEditor::Attribute::Ptr> array; 534​ QVector<KTextEditor::Attribute::Ptr> array;
514 for (const auto &format : m_formats) { 535​ for (const auto &format : m_formats) {
515 /** 536​ /**
516 * FIXME: atm we just set some theme here for later color generation 537​ * atm we just set the current chosen theme here for later color generation.
538​ * NOTE: if the theme isn't valid for KSyntaxHighlighting, the default light theme will be used.
539​ * For example, the "KDE" and "Vim (dark)" themes don't exist in KSyntaxHighlighting.
517 */ 540​ */
541​ if (currentTheme.isValid()) {
542​ setTheme(currentTheme);
543​ } else {
518 setTheme(KateHlManager::self()->repository().defaultTheme(KSyntaxHighlighting::Repository::LightTheme)); 544​ setTheme(KateHlManager::self()->repository().defaultTheme(KSyntaxHighlighting::Repository::LightTheme));
545​ }
519 546​
520 /** 547​ /**
521 * create a KTextEditor attribute matching the given format 548​ * create a KTextEditor attribute matching the given format
522 */ 549​ */
523 KTextEditor::Attribute::Ptr newAttribute(new KTextEditor::Attribute(nameForAttrib(array.size()), textStyleToDefaultStyle(format.textStyle()))); 550​ KTextEditor::Attribute::Ptr newAttribute(new KTextEditor::Attribute(nameForAttrib(array.size()), textStyleToDefaultStyle(format.textStyle())));
524 551​
552​ /**
553​ * don't apply attribute styles for themes that don't exist in KSyntaxHighlighting, but exist in KTextEditor
554​ */
555​ if (currentTheme.isValid()) {
525 if (format.hasTextColor(theme())) { 556​ if (format.hasTextColor(theme())) {
526 newAttribute->setForeground(format.textColor(theme())); 557​ newAttribute->setForeground(format.textColor(theme()));
527 newAttribute->setSelectedForeground(format.selectedTextColor(theme())); 558​ newAttribute->setSelectedForeground(format.selectedTextColor(theme()));
528 } 559​ }
529 560​
530 if (format.hasBackgroundColor(theme())) { 561​ if (format.hasBackgroundColor(theme())) {
531 newAttribute->setBackground(format.backgroundColor(theme())); 562​ newAttribute->setBackground(format.backgroundColor(theme()));
532 newAttribute->setSelectedBackground(format.selectedBackgroundColor(theme())); 563​ newAttribute->setSelectedBackground(format.selectedBackgroundColor(theme()));
Show All 9 Lines
542 573​
543 if (format.isUnderline(theme())) { 574​ if (format.isUnderline(theme())) {
544 newAttribute->setFontUnderline(true); 575​ newAttribute->setFontUnderline(true);
545 } 576​ }
546 577​
547 if (format.isStrikeThrough(theme())) { 578​ if (format.isStrikeThrough(theme())) {
548 newAttribute->setFontStrikeOut(true); 579​ newAttribute->setFontStrikeOut(true);
549 } 580​ }
581​ }
550 582​
551 newAttribute->setSkipSpellChecking(format.spellCheck()); 583​ newAttribute->setSkipSpellChecking(format.spellCheck());
552 584​
553 array.append(newAttribute); 585​ array.append(newAttribute);
554 } 586​ }
555 return array; 587​ return array;
556} 588​}
557 589​
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines