Changeset View
Changeset View
Standalone View
Standalone View
src/core/kfileitem.h
Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Line(s) | 108 | #endif | |||
---|---|---|---|---|---|
110 | /** | 110 | /** | ||
111 | * Creates an item representing a file, for which the mimetype is already known. | 111 | * Creates an item representing a file, for which the mimetype is already known. | ||
112 | * @param url the file url | 112 | * @param url the file url | ||
113 | * @param mimeType the name of the file's mimetype | 113 | * @param mimeType the name of the file's mimetype | ||
114 | * @param mode the mode (S_IFDIR...) | 114 | * @param mode the mode (S_IFDIR...) | ||
115 | */ | 115 | */ | ||
116 | KFileItem(const QUrl &url, const QString &mimeType = QString(), mode_t mode = KFileItem::Unknown); // KF6 TODO: explicit! | 116 | KFileItem(const QUrl &url, const QString &mimeType = QString(), mode_t mode = KFileItem::Unknown); // KF6 TODO: explicit! | ||
117 | 117 | | |||
118 | KFileItem(const QUrl &url, bool skipStat); | ||||
dfaure: booleans parameters are bad, please make it an enum.
https://wiki.qt. | |||||
119 | | ||||
118 | /** | 120 | /** | ||
119 | * Copy constructor | 121 | * Copy constructor | ||
120 | */ | 122 | */ | ||
121 | KFileItem(const KFileItem&); | 123 | KFileItem(const KFileItem&); | ||
122 | 124 | | |||
123 | /** | 125 | /** | ||
124 | * Destructor | 126 | * Destructor | ||
125 | */ | 127 | */ | ||
▲ Show 20 Lines • Show All 480 Lines • Show Last 20 Lines |
booleans parameters are bad, please make it an enum.
https://wiki.qt.io/API_Design_Principles#The_Boolean_Parameter_Trap
+ docu missing including @since tag.