Changeset View
Changeset View
Standalone View
Standalone View
3rdparty/ext_expat/CMakeLists.txt
1 | SET(PREFIX_ext_expat "${EXTPREFIX}" ) | 1 | SET(PREFIX_ext_expat "${EXTPREFIX}" ) | ||
---|---|---|---|---|---|
2 | 2 | | |||
3 | if (WIN32) | 3 | if (WIN32) | ||
4 | ExternalProject_Add( ext_expat | 4 | ExternalProject_Add( ext_expat | ||
apol: Maintainability-wise, having the same thing twice isn't very practical. Maybe you can just pass… | |||||
5 | DOWNLOAD_DIR ${EXTERNALS_DOWNLOAD_DIR} | 5 | DOWNLOAD_DIR ${EXTERNALS_DOWNLOAD_DIR} | ||
6 | URL http://files.kde.org/krita/build/dependencies/expat-2.1.0.tar.gz | 6 | URL http://files.kde.org/krita/build/dependencies/expat-2.1.0.tar.gz | ||
7 | URL_MD5 dd7dab7a5fea97d2a6a43f511449b7cd | 7 | URL_MD5 dd7dab7a5fea97d2a6a43f511449b7cd | ||
8 | 8 | | |||
9 | PATCH_COMMAND ${PATCH_COMMAND} -p1 -i ${CMAKE_CURRENT_SOURCE_DIR}/expat-2.1.0-20130311.diff | 9 | PATCH_COMMAND ${PATCH_COMMAND} -p1 -i ${CMAKE_CURRENT_SOURCE_DIR}/expat-2.1.0-20130311.diff | ||
10 | INSTALL_DIR ${PREFIX_ext_expat} | 10 | INSTALL_DIR ${PREFIX_ext_expat} | ||
11 | CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${PREFIX_ext_expat} -DBUILD_tests=OFF -DBUILD_examples=OFF -DBUILD_tools=OFF -DCMAKE_BUILD_TYPE=${GLOBAL_BUILD_TYPE} ${GLOBAL_PROFILE} | 11 | CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${PREFIX_ext_expat} -DBUILD_tests=OFF -DBUILD_examples=OFF -DBUILD_tools=OFF -DCMAKE_BUILD_TYPE=${GLOBAL_BUILD_TYPE} ${GLOBAL_PROFILE} | ||
12 | UPDATE_COMMAND "" | 12 | UPDATE_COMMAND "" | ||
13 | 13 | | |||
14 | DEPENDS ext_patch | 14 | DEPENDS ext_patch | ||
15 | ) | 15 | ) | ||
16 | 16 | | |||
17 | elseif (ANDROID) | ||||
18 | ExternalProject_Add( ext_expat | ||||
19 | DOWNLOAD_DIR ${EXTERNALS_DOWNLOAD_DIR} | ||||
20 | URL http://files.kde.org/krita/build/dependencies/expat-2.1.0.tar.gz | ||||
21 | URL_MD5 dd7dab7a5fea97d2a6a43f511449b7cd | ||||
22 | | ||||
23 | INSTALL_DIR ${PREFIX_ext_expat} | ||||
24 | CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${PREFIX_ext_expat} -DCMAKE_BUILD_TYPE=${GLOBAL_BUILD_TYPE} -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE} -DANDROID_PLATFORM=${ANDROID_PLATFORM} | ||||
25 | BUILD_COMMAND make | ||||
26 | INSTALL_COMMAND make install | ||||
27 | | ||||
28 | UPDATE_COMMAND "" | ||||
29 | ) | ||||
30 | | ||||
17 | else() | 31 | else() | ||
18 | 32 | | |||
19 | ExternalProject_Add( ext_expat | 33 | ExternalProject_Add( ext_expat | ||
20 | DOWNLOAD_DIR ${EXTERNALS_DOWNLOAD_DIR} | 34 | DOWNLOAD_DIR ${EXTERNALS_DOWNLOAD_DIR} | ||
21 | URL http://files.kde.org/krita/build/dependencies/expat-2.1.0.tar.gz | 35 | URL http://files.kde.org/krita/build/dependencies/expat-2.1.0.tar.gz | ||
22 | URL_MD5 dd7dab7a5fea97d2a6a43f511449b7cd | 36 | URL_MD5 dd7dab7a5fea97d2a6a43f511449b7cd | ||
23 | 37 | | |||
24 | INSTALL_DIR ${PREFIX_ext_expat} | 38 | INSTALL_DIR ${PREFIX_ext_expat} | ||
Show All 9 Lines |
Maintainability-wise, having the same thing twice isn't very practical. Maybe you can just pass to this one some android extra arguments?