Differential D19052 Diff 53364 autotests/integration/x11_client_test.cpp

Changeset View

Standalone View

View Options

autotests/integration/x11_client_test.cpp

Context not available.
50 void cleanup(); 50​ void cleanup();
51 51​
52 void testCaptionSimplified(); 52​ void testCaptionSimplified();
53​ void testCaptionNonPrintable();
53 void testFullscreenLayerWithActiveWaylandWindow(); 54​ void testFullscreenLayerWithActiveWaylandWindow();
54 void testFocusInWithWaylandLastActiveWindow(); 55​ void testFocusInWithWaylandLastActiveWindow();
55 void testX11WindowId(); 56​ void testX11WindowId();
Context not available.
145 c.reset(); 146​ c.reset();
146} 147​}
147 148​
149​void X11ClientTest::testCaptionNonPrintable()
150​{
151​ // this test verifies that non-printable characters in captions get stripped
152​ // but printable non-BMP characters, such as Emoji, are kept
153​ // BUG: 376813
154​ QSignalSpy windowAddedSpy(effects, &EffectsHandler::windowAdded);
155​ QVERIFY(windowAddedSpy.isValid());
zzagUnsubmitted
Not Done

Do we need these?

zzag: Do we need these?
156​
157​ // create an xcb window
158​ QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
159​ QVERIFY(!xcb_connection_has_error(c.data()));
160​ const QRect windowGeometry(0, 0, 100, 200);
161​ xcb_window_t w = xcb_generate_id(c.data());
162​ xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
163​ windowGeometry.x(),
164​ windowGeometry.y(),
165​ windowGeometry.width(),
166​ windowGeometry.height(),
167​ 0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
168​ xcb_size_hints_t hints;
169​ memset(&hints, 0, sizeof(hints));
170​ xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
171​ xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
172​ xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
173​ NETWinInfo winInfo(c.data(), w, rootWindow(), NET::Properties(), NET::Properties2());
174​ const QByteArray origTitle = QByteArrayLiteral("\bTesting non\302\255printable:\177, emoij:\360\237\230\203, non-characters:\357\277\276");
175​ const QByteArray expectedTitle = QByteArrayLiteral("Testing nonprintable:, emoij:\360\237\230\203, non-characters:");
176​ winInfo.setName(origTitle.constData());
177​ xcb_map_window(c.data(), w);
178​ xcb_flush(c.data());
179​
180​ // we should get a client for it
181​ QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
182​ QVERIFY(windowCreatedSpy.isValid());
183​ QVERIFY(windowCreatedSpy.wait());
184​ Client *client = windowCreatedSpy.first().first().value<Client*>();
185​ QVERIFY(client);
186​ QCOMPARE(client->window(), w);
187​ QVERIFY(client->caption() != QString::fromUtf8(origTitle));
188​ QCOMPARE(client->caption(), QString::fromUtf8(expectedTitle));
189​
190​ // and destroy the window again
191​ xcb_unmap_window(c.data(), w);
192​ xcb_flush(c.data());
193​
194​ QSignalSpy windowClosedSpy(client, &Client::windowClosed);
195​ QVERIFY(windowClosedSpy.isValid());
196​ QVERIFY(windowClosedSpy.wait());
197​ xcb_destroy_window(c.data(), w);
198​ c.reset();
zzagUnsubmitted
Not Done

Can it be moved up?

zzag: Can it be moved up?
199​}
200​
148void X11ClientTest::testFullscreenLayerWithActiveWaylandWindow() 201​void X11ClientTest::testFullscreenLayerWithActiveWaylandWindow()
149{ 202​{
150 // this test verifies that an X11 fullscreen window does not stay in the active layer 203​ // this test verifies that an X11 fullscreen window does not stay in the active layer
Context not available.