Differential D19559 Diff 53340 messageviewer/src/viewer/webengine/mailwebengineview.cpp

Changeset View

Standalone View

View Options

messageviewer/src/viewer/webengine/mailwebengineview.cpp

Show All 23 Lines63public:
75 MessageViewer::ViewerPrivate *mViewer = nullptr; 75​ MessageViewer::ViewerPrivate *mViewer = nullptr;
76 MessageViewer::BlockMailTrackingUrlInterceptor *mBlockMailTrackingUrl = nullptr; 76​ MessageViewer::BlockMailTrackingUrlInterceptor *mBlockMailTrackingUrl = nullptr;
77 bool mCanStartDrag = false; 77​ bool mCanStartDrag = false;
78}; 78​};
79 79​
80MailWebEngineView::MailWebEngineView(KActionCollection *ac, QWidget *parent) 80​MailWebEngineView::MailWebEngineView(KActionCollection *ac, QWidget *parent)
81 : WebEngineViewer::WebEngineView(parent) 81​ : WebEngineViewer::WebEngineView(parent)
82 , d(new MessageViewer::MailWebEngineViewPrivate) 82​ , d(new MessageViewer::MailWebEngineViewPrivate)
83{ 83​{
84 d->mPageEngine = new MailWebEnginePage(new QWebEngineProfile(this), this); 84​ // Do not create the QWebEngineProfile as a child of us, the MailWebEnginePage
85​ // will take ownershp of it and ensure that it it correctly deleted during
86​ // destruction.
87​ d->mPageEngine = new MailWebEnginePage(new QWebEngineProfile, this);
anthonyfieroniUnsubmitted
Not Done

It's not needed to change these lines, while you reparent inside.

anthonyfieroni: It's not needed to change these lines, while you reparent inside.
85 setPage(d->mPageEngine); 88​ setPage(d->mPageEngine);
86 d->mWebViewAccessKey = new WebEngineViewer::WebEngineAccessKey(this, this); 89​ d->mWebViewAccessKey = new WebEngineViewer::WebEngineAccessKey(this, this);
87 d->mWebViewAccessKey->setActionCollection(ac); 90​ d->mWebViewAccessKey->setActionCollection(ac);
88 d->mScamDetection = new ScamDetectionWebEngine(this); 91​ d->mScamDetection = new ScamDetectionWebEngine(this);
89 connect(d->mScamDetection, &ScamDetectionWebEngine::messageMayBeAScam, this, 92​ connect(d->mScamDetection, &ScamDetectionWebEngine::messageMayBeAScam, this,
90 &MailWebEngineView::messageMayBeAScam); 93​ &MailWebEngineView::messageMayBeAScam);
91 connect(d->mWebViewAccessKey, &WebEngineViewer::WebEngineAccessKey::openUrl, this, 94​ connect(d->mWebViewAccessKey, &WebEngineViewer::WebEngineAccessKey::openUrl, this,
92 &MailWebEngineView::openUrl); 95​ &MailWebEngineView::openUrl);
Show All 24 Lines