Changeset View
Changeset View
Standalone View
Standalone View
shell_client.h
Show First 20 Lines • Show All 189 Lines • ▼ Show 20 Line(s) | 166 | protected: | |||
---|---|---|---|---|---|
190 | bool isUnmapped() const { | 190 | bool isUnmapped() const { | ||
191 | return m_unmapped; | 191 | return m_unmapped; | ||
192 | } | 192 | } | ||
193 | 193 | | |||
194 | private Q_SLOTS: | 194 | private Q_SLOTS: | ||
195 | void clientFullScreenChanged(bool fullScreen); | 195 | void clientFullScreenChanged(bool fullScreen); | ||
196 | 196 | | |||
197 | private: | 197 | private: | ||
198 | /** | ||||
199 | * Called when the shell is created. | ||||
200 | **/ | ||||
zzag: I'm not sure whether `/* */` is the right choice here. Maybe use single line comments or stick… | |||||
198 | void init(); | 201 | void init(); | ||
202 | /** | ||||
203 | * Called for the XDG case when the shell surface is committed to the surface. | ||||
204 | * At this point all initial properties should have been set by the client. | ||||
205 | **/ | ||||
206 | void finishInit(); | ||||
199 | template <class T> | 207 | template <class T> | ||
200 | void initSurface(T *shellSurface); | 208 | void initSurface(T *shellSurface); | ||
201 | void createDecoration(const QRect &oldgeom); | 209 | void createDecoration(const QRect &oldgeom); | ||
202 | void destroyClient(); | 210 | void destroyClient(); | ||
203 | void createWindowId(); | 211 | void createWindowId(); | ||
204 | void updateIcon(); | 212 | void updateIcon(); | ||
205 | void setTransient(); | 213 | void setTransient(); | ||
206 | bool shouldExposeToWindowManagement(); | 214 | bool shouldExposeToWindowManagement(); | ||
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Line(s) | |||||
253 | bool m_userNoBorder = false; | 261 | bool m_userNoBorder = false; | ||
254 | bool m_fullScreen = false; | 262 | bool m_fullScreen = false; | ||
255 | bool m_transient = false; | 263 | bool m_transient = false; | ||
256 | bool m_hidden = false; | 264 | bool m_hidden = false; | ||
257 | bool m_internal; | 265 | bool m_internal; | ||
258 | bool m_hasPopupGrab = false; | 266 | bool m_hasPopupGrab = false; | ||
259 | qreal m_opacity = 1.0; | 267 | qreal m_opacity = 1.0; | ||
260 | 268 | | |||
261 | class RequestGeometryBlocker { | 269 | class RequestGeometryBlocker { //TODO rename ConfigureBlocker when this class is Xdg only | ||
Also it would be great to tell "future folks" when they could rename it to ConfigureBlocker. :-) zzag: Also it would be great to tell "future folks" when they could rename it to ConfigureBlocker. :-) | |||||
262 | public: | 270 | public: | ||
263 | RequestGeometryBlocker(ShellClient *client) | 271 | RequestGeometryBlocker(ShellClient *client) | ||
264 | : m_client(client) | 272 | : m_client(client) | ||
265 | { | 273 | { | ||
266 | m_client->m_requestGeometryBlockCounter++; | 274 | m_client->m_requestGeometryBlockCounter++; | ||
267 | } | 275 | } | ||
268 | ~RequestGeometryBlocker() | 276 | ~RequestGeometryBlocker() | ||
269 | { | 277 | { | ||
Show All 23 Lines |
I'm not sure whether /* */ is the right choice here. Maybe use single line comments or stick with /** **/?