Differential D17945 Diff 52532 src/activities/numbers-odd-even/resource/Tutorial5.qml

Changeset View

Standalone View

src/activities/numbers-odd-even/resource/Tutorial5.qml

This file was added.

1		/* GCompris - Tutorial5.qml
2
3		*
4		* Copyright (C) 2019 Deepak Kumar <deepakdk2431@gmail.com>
5		*
6		* Authors:
7		* Deepak Kumar <deepakdk2431@gmail.com>
8		*
9		* This program is free software; you can redistribute it and/or modify
10		* it under the terms of the GNU General Public License as published by
11		* the Free Software Foundation; either version 3 of the License, or
12		* (at your option) any later version.
13		*
14		* This program is distributed in the hope that it will be useful,
15		* but WITHOUT ANY WARRANTY; without even the implied warranty of
16		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17		* GNU General Public License for more details.
18		*
19		* You should have received a copy of the GNU General Public License
20		* along with this program; if not, see <https://www.gnu.org/licenses/>.
21		*/
22		import QtQuick 2.6
23		import GCompris 1.0
24
25		import "../../../core"
26
27		TutorialBase {
28
	jjazeixUnsubmitted Not Done 2 false wouldn't happen with only one bool jjazeix: 2 false wouldn't happen with only one bool
29		isEven: false
30		firstNumber: "59"
31		secondNumber: "52"
	amankumarguptaUnsubmitted Not Done I think Tutorial3.qml, Tutorial4.qml, Tutorial5.qml can be refactored and prevent creating separate files. amankumargupta: I think Tutorial3.qml, Tutorial4.qml, Tutorial5.qml can be refactored and prevent creating…
	jjazeixUnsubmitted Not Done how? jjazeix: how?
	amankumarguptaUnsubmitted Not Done Currently, 3 tutorial components are used to give 3 practice questions (skip one, and another comes). IMO, having it like this would be better: First 2 tutorials to explain would be there. Then these 3 practice questions would be in just one tutorial component. User answers correctly, the next one will be switched in the same file (technically, just the numbers will be updated inside TutorialBase only). On clicking "next" at any step of this practice, the tutorial ends (which currently happens when we skip all the 3 practice questions). amankumargupta: Currently, 3 tutorial components are used to give 3 practice questions (skip one, and another…
	jjazeixUnsubmitted Not Done there is no need for2 bools jjazeix: there is no need for2 bools
32		}
	jjazeixUnsubmitted Not Done it should be renamed firstChoice or firstNumber, having a variable called "evenNumber" and setting it to 59 is not a good practice jjazeix: it should be renamed firstChoice or firstNumber, having a variable called "evenNumber" and…