Differential D19280 Diff 52518 applets/taskmanager/package/contents/ui/ConfigBehavior.qml

Changeset View

Standalone View

View Options

applets/taskmanager/package/contents/ui/ConfigBehavior.qml

  • This file was added.
1​/***************************************************************************
2​ * Copyright (C) 2013 by Eike Hein <hein@kde.org> *
3​ * *
4​ * This program is free software; you can redistribute it and/or modify *
5​ * it under the terms of the GNU General Public License as published by *
6​ * the Free Software Foundation; either version 2 of the License, or *
7​ * (at your option) any later version. *
8​ * *
9​ * This program is distributed in the hope that it will be useful, *
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12​ * GNU General Public License for more details. *
13​ * *
14​ * You should have received a copy of the GNU General Public License *
15​ * along with this program; if not, write to the *
16​ * Free Software Foundation, Inc., *
17​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
18​ ***************************************************************************/
19​
20​import QtQuick 2.0
21​import QtQuick.Controls 1.4 as QQC1
22​import QtQuick.Controls 2.5
23​import QtQuick.Layouts 1.12
24​import org.kde.kirigami 2.4 as Kirigami
25​
26​import org.kde.plasma.core 2.0 as PlasmaCore
27​
28​Item {
29​ width: childrenRect.width
30​ height: childrenRect.height
31​
32​ property alias cfg_groupingStrategy: groupingStrategy.currentIndex
33​ property alias cfg_groupPopups: groupPopups.checked
34​ property alias cfg_onlyGroupWhenFull: onlyGroupWhenFull.checked
35​ property alias cfg_sortingStrategy: sortingStrategy.currentIndex
36​ property alias cfg_separateLaunchers: separateLaunchers.checked
37​ property alias cfg_middleClickAction: middleClickAction.currentIndex
38​ property alias cfg_wheelEnabled: wheelEnabled.checked
39​ property alias cfg_showOnlyCurrentScreen: showOnlyCurrentScreen.checked
40​ property alias cfg_showOnlyCurrentDesktop: showOnlyCurrentDesktop.checked
41​ property alias cfg_showOnlyCurrentActivity: showOnlyCurrentActivity.checked
42​ property alias cfg_showOnlyMinimized: showOnlyMinimized.checked
43​
44​ Kirigami.FormLayout {
45​ anchors.left: parent.left
46​ anchors.right: parent.right
47​
48​ // TODO: port to QQC2 version once we've fixed https://bugs.kde.org/show_bug.cgi?id=403153
49​ QQC1.ComboBox {
50​ id: groupingStrategy
51​ Layout.fillWidth: true
52​ Kirigami.FormData.label: i18n("Group:")
53​ model: [i18n("Do not group"), i18n("By program name")]
54​ }
55​
56​ CheckBox {
57​ id: groupPopups
58​ text: i18n("Open groups in popups")
59​ enabled: groupingStrategy.currentIndex > 0
60​ }
61​
62​ RowLayout {
63​
64​ // Indent the option as it depends on the previous one
65​ Item {
GB_2Unsubmitted
Done

"Task Manager" should be lowercase and a better text would be "Only group when the task manager is full".
I'd also switch the position with the above checkbox.

GB_2: "Task Manager" should be lowercase and a better text would be "Only group when the task manager…
ngrahamUnsubmitted
Done

Uppercase is fine since it's a proper noun.

ngraham: Uppercase is fine since it's a proper noun.
66​ width: Math.round(groupPopups.width * 10)
67​ }
68​
69​ CheckBox {
70​ id: onlyGroupWhenFull
heinUnsubmitted
Done

Wait, 10x the checkbox width?

hein: Wait, 10x the checkbox width?
GB_2Unsubmitted
Done

Should be units.largeSpacing

GB_2: Should be `units.largeSpacing`
filipfAuthorUnsubmitted
Done

I tried units.largeSpacing first then realized it's not aligned with the top text (not even with 1.0 scaling) so I did something like (units.largeSpacing - units.smallSpacing * 2) which worked ok with 1.0 scaling but the higher the scaling factor the more the text shifted to the right = it stopped being aligned with the top text. This bad code that's present now worked well with all scaling preferences. I can just do units.largeSpacing though if everyone is fine with that.

filipf: I tried `units.largeSpacing` first then realized it's not aligned with the top text (not even…
GB_2Unsubmitted
Done

units.largeSpacing is correct and used in other places too.

GB_2: `units.largeSpacing` is correct and used in other places too.
71​ text: i18n("Group only when the Task Manager is full")
72​ enabled: groupingStrategy.currentIndex > 0 && groupPopups.checked
73​ }
74​ }
75​
76​ Item {
77​ Kirigami.FormData.isSection: true
78​ }
79​
80​ // TODO: port to QQC2 version once we've fixed https://bugs.kde.org/show_bug.cgi?id=403153
81​ QQC1.ComboBox {
82​ id: sortingStrategy
83​ Kirigami.FormData.label: i18n("Sort:")
84​ Layout.fillWidth: true
85​ model: [i18n("Do not sort"), i18n("Manually"), i18n("Alphabetically"), i18n("By desktop"), i18n("By activity")]
86​ }
87​
88​ CheckBox {
89​ id: separateLaunchers
90​ text: i18n("Keep launchers separate")
91​ enabled: sortingStrategy.currentIndex == 1
92​ }
93​
94​ Item {
95​ Kirigami.FormData.isSection: true
96​ }
97​
98​ // TODO: port to QQC2 version once we've fixed https://bugs.kde.org/show_bug.cgi?id=403153
99​ QQC1.ComboBox {
100​ id: middleClickAction
101​ Kirigami.FormData.label: i18n("On middle-click:")
102​ Layout.fillWidth: true
103​ model: [
104​ i18nc("The click action", "None"),
105​ i18n("Close window or group"),
106​ i18n("New instance"),
107​ i18n("Minimize/Restore window or group"),
108​ i18nc("When clicking it would toggle grouping windows of a specific app", "Group/Ungroup")
109​ ]
110​ }
111​
112​ CheckBox {
113​ id: wheelEnabled
114​ text: i18n("Cycle through tasks with mouse wheel")
115​ }
116​
GB_2Unsubmitted
Done

Better: "Filter:"

GB_2: Better: "Filter:"
117​ Item {
118​ Kirigami.FormData.isSection: true
119​ }
120​
121​ CheckBox {
122​ id: showOnlyCurrentScreen
123​ Kirigami.FormData.label: i18n("Filter:")
124​ text: i18n("Show only tasks from the current screen")
125​ }
126​
127​ CheckBox {
128​ id: showOnlyCurrentDesktop
129​ text: i18n("Show only tasks from the current desktop")
130​ }
131​
132​ CheckBox {
133​ id: showOnlyCurrentActivity
134​ text: i18n("Show only tasks from the current activity")
135​ }
136​
137​ CheckBox {
138​ id: showOnlyMinimized
139​ visible: (plasmoid.pluginName != "org.kde.plasma.icontasks")
140​ text: i18n("Show only tasks that are minimized")
141​ }
142​ }
143​}