Differential D19291 Diff 52492 include/initialize.inc.php

Changeset View

Standalone View

View Options

include/initialize.inc.php

1<?php 1​<?php
2/* 2​/*
3 - Get the variables from the URL 3​ - Get the variables from the URL
4 - Initialize to sane defaults if empty 4​ - Initialize to sane defaults if empty
5 - The differen levels of given parameters 5​ - The differen levels of given parameters
6 are checked for existence. 6​ are checked for existence.
7 - Set to sane defaults if nonexistent 7​ - Set to sane defaults if nonexistent
8*/ 8​*/
9 9​
10function try_cleanup_input($input_string) 10​function try_cleanup_input(?string $input_string): string
11{ 11​{
12 /* keep only the first block of proper characters */ 12​ if (is_null($input_string)) {
ognarbAuthorUnsubmitted
Not Done

The original code didn't work for me with a recent php version

ognarb: The original code didn't work for me with a recent php version
13 $sane_pattern = "/^([[:alnum:]-_\.]+)/"; ​
14 $input_matched = preg_match($sane_pattern, htmlentities($input_string), $matches); ​
15 if ($input_matched) { ​
16 return $matches[1]; ​
17 } else { ​
18 return ""; 13​ return "";
19 } 14​ }
15​ return htmlspecialchars($input_string);
20} 16​}
21 17​
22/* Clear the nonexist indicators*/ 18​/* Clear the nonexist indicators*/
23$selected_branch_nonexist = ""; 19​$selected_branch_nonexist = "";
24$selected_language_nonexist = ""; 20​$selected_language_nonexist = "";
25$selected_package_nonexist = ""; 21​$selected_package_nonexist = "";
26$selected_application_nonexist = ""; 22​$selected_application_nonexist = "";
27 23​
28/* BRANCH: only valid if the other parameters have been specified, 24​/* BRANCH: only valid if the other parameters have been specified,
29 so an empty value is valid. If the values does not match 25​ so an empty value is valid. If the values does not match
30 an existing branch, the standard application page is shown 26​ an existing branch, the standard application page is shown
31*/ 27​*/
32$selected_branch = try_cleanup_input($_GET['branch']); 28​$selected_branch = try_cleanup_input($_GET['branch']);
33 29​
34/* branch for search */ 30​/* branch for search */
35$search_branch = try_cleanup_input($_GET['sbranch']); 31​$search_branch = try_cleanup_input($_GET['sbranch']);
36if ( $search_branch == "" ) { 32​if ($search_branch === "") {
37 $search_branch = "trunk"; 33​ $search_branch = "trunk";
38} 34​}
39 35​
40 36​
41/* LANGUAGE */ 37​/* LANGUAGE */
42$selected_language = try_cleanup_input($_GET['language']); 38​$selected_language = try_cleanup_input($_GET['language']);
43if ( $selected_language == "" ) { 39​if ($selected_language === "") {
44 $selected_language = "en"; 40​ $selected_language = "en";
45} 41​}
46if ( !in_array( $selected_language, $languagelist ) ) { 42​if (!in_array($selected_language, $languagelist)) {
47 /* Special rule for en_US */ 43​ /* Special rule for en_US */
48 if ( $selected_language == "en_US" ) { 44​ if ($selected_language === "en_US") {
49 $selected_language = "en"; 45​ $selected_language = "en";
50 } else { 46​ } else {
51 /* Try to see if the language follows the xx_XX pattern, and 47​ /* Try to see if the language follows the xx_XX pattern, and
52 if yes, look for xx language code */ 48​ if yes, look for xx language code */
53 $lang_pattern = "/([a-z]{2})_([A-Z]{2})/"; 49​ $lang_pattern = "/([a-z]{2})_([A-Z]{2})/";
54 $was_matched = preg_match($lang_pattern, $selected_language, $matches); 50​ $was_matched = preg_match($lang_pattern, $selected_language, $matches);
55 if ( $was_matched and ( strtoupper($matches[1]) == $matches[2] ) and 51​ if ($was_matched and (strtoupper($matches[1]) == $matches[2]) and
56 in_array( $matches[1], $languagelist ) ) { 52​ in_array($matches[1], $languagelist)) {
57 $selected_language = $matches[1]; 53​ $selected_language = $matches[1];
58 } else { 54​ } else {
59 $selected_language_nonexist = $selected_language; 55​ $selected_language_nonexist = $selected_language;
60 $selected_language = "en"; 56​ $selected_language = "en";
61 } 57​ }
62 } 58​ }
63} 59​}
64 60​
65/* PACKAGE */ 61​/* PACKAGE */
66$selected_package = try_cleanup_input($_GET['package']); 62​$selected_package = try_cleanup_input($_GET['package']);
67 63​
68 64​
69/* APPLICATION */ 65​/* APPLICATION */
70// original input from user 66​// original input from user
71$selected_application_from_user = try_cleanup_input($_GET['application']); 67​$selected_application_from_user = try_cleanup_input($_GET['application']);
68​
72// try the input, and if not found, try also the lowercase version 69​// try the input, and if not found, try also the lowercase version
73$selected_application = $selected_application_from_user; 70​$selected_application = $selected_application_from_user;
74$selected_application_found = false; 71​$selected_application_found = false;
75if ( array_key_exists( $selected_application_from_user, $programs_docs ) ) { 72​if (array_key_exists($selected_application_from_user, $programs_docs)) {
76 $selected_application_found = true; 73​ $selected_application_found = true;
77} else { 74​} else {
78 $selected_application = strtolower($selected_application_from_user); 75​ $selected_application = strtolower($selected_application_from_user);
79 if ( array_key_exists( $selected_application, $programs_docs ) ) { 76​ if (array_key_exists($selected_application, $programs_docs)) {
80 $selected_application_found = true; 77​ $selected_application_found = true;
81 } 78​ }
82} 79​}
83if ( ! $selected_application_found ) { 80​if (!$selected_application_found) {
84 $selected_application_nonexist = $selected_application; 81​ $selected_application_nonexist = $selected_application;
85 $selected_application = ""; 82​ $selected_application = "";
86} 83​}
87 84​
88 85​
89/* PATH to html file under application (used to fix help: links) */ 86​/* PATH to html file under application (used to fix help: links) */
90if(!empty(try_cleanup_input($_GET['path']))) { 87​if (!empty(try_cleanup_input($_GET['path']))) {
91 $html_path = try_cleanup_input($_GET['path']); 88​ $html_path = try_cleanup_input($_GET['path']);
92} 89​} else {
93else { ​
94 $html_path = 'index.html'; 90​ $html_path = 'index.html';
95} 91​}
96 92​
97?> 93​?>