Changeset View
Changeset View
Standalone View
Standalone View
app/mainwindow.h
Context not available. | |||||
30 | 30 | | |||
---|---|---|---|---|---|
31 | class QUrl; | 31 | class QUrl; | ||
32 | 32 | | |||
33 | class QMouseEvent; | ||||
34 | | ||||
33 | namespace Gwenview | 35 | namespace Gwenview | ||
34 | { | 36 | { | ||
35 | 37 | | |||
Context not available. | |||||
79 | void saveProperties(KConfigGroup&) override; | 81 | void saveProperties(KConfigGroup&) override; | ||
80 | void readProperties(const KConfigGroup&) override; | 82 | void readProperties(const KConfigGroup&) override; | ||
81 | bool eventFilter(QObject *, QEvent *) override; | 83 | bool eventFilter(QObject *, QEvent *) override; | ||
84 | void mousePressEvent(QMouseEvent *) override; | ||||
rkflx: Current master is using `override` instead of `Q_DECL_OVERRIDE;`, meaning your patch does not… | |||||
@ngraham wants it for 18.08 anthonyfieroni: @ngraham wants it for 18.08 | |||||
We are past the Beta (even past the RC), so it will be in 18.12. You are adding a new event handler to MainWindow, that's not material for stable. rkflx: We are past the Beta (even past the RC), so it will be in 18.12.
You are adding a new event… | |||||
I don't recall saying that. :) This should land on master since it's a new feature. Besides, if you intended this for 18.08, it would be nice to use arc so that the parent branch is specified automatically. :) ngraham: I don't recall saying that. :) This should land on master since it's a new feature. Besides, if… | |||||
I'm not a big fan of PHP, so arc and other PHP scripts are not welcome to me. anthonyfieroni: I'm not a big fan of PHP, so arc and other PHP scripts are not welcome to me. | |||||
You could at least add more context to your diff for future Diffs (there should be an argument to diff for that), so Phabricator would not show "Context not available", which makes reviewing harder. rkflx: You could at least add more context to your diff for future Diffs (there should be an argument… | |||||
85 | void mouseDoubleClickEvent(QMouseEvent *) override; | ||||
82 | 86 | | |||
83 | private Q_SLOTS: | 87 | private Q_SLOTS: | ||
84 | void setActiveViewModeAction(QAction* action); | 88 | void setActiveViewModeAction(QAction* action); | ||
Context not available. | |||||
139 | void saveConfig(); | 143 | void saveConfig(); | ||
140 | void configureShortcuts(); | 144 | void configureShortcuts(); | ||
141 | 145 | | |||
146 | void mouseButtonNavigate(QMouseEvent *); | ||||
147 | | ||||
142 | void folderViewUrlChanged(const QUrl &url); | 148 | void folderViewUrlChanged(const QUrl &url); | ||
143 | }; | 149 | }; | ||
144 | 150 | | |||
Context not available. |
Current master is using override instead of Q_DECL_OVERRIDE;, meaning your patch does not apply.
Please rebase on master.