Differential D16128 Diff 51874 plugins/dockers/overview/overviewdocker_dock.cpp

Changeset View

Standalone View

View Options

plugins/dockers/overview/overviewdocker_dock.cpp

Context not available.
20 20​
21#include <QLabel> 21​#include <QLabel>
22#include <QVBoxLayout> 22​#include <QVBoxLayout>
23​#include <QHBoxLayout>
24​#include <QToolButton>
23#include <QStatusBar> 25​#include <QStatusBar>
26​#include <kis_slider_spin_box.h>
24#include <klocalizedstring.h> 27​#include <klocalizedstring.h>
25 28​
26#include "kis_canvas2.h" 29​#include "kis_canvas2.h"
Context not available.
29#include "kis_image.h" 32​#include "kis_image.h"
30#include "kis_paint_device.h" 33​#include "kis_paint_device.h"
31#include "kis_signal_compressor.h" 34​#include "kis_signal_compressor.h"
32 35​#include "kis_canvas_controller.h"
36​#include "kis_icon_utils.h"
33 37​
34OverviewDockerDock::OverviewDockerDock( ) 38​OverviewDockerDock::OverviewDockerDock( )
35 : QDockWidget(i18n("Overview")) 39​ : QDockWidget(i18n("Overview"))
36 , m_zoomSlider(0) 40​ , m_zoomSlider(nullptr)
37 , m_canvas(0) 41​ , m_rotateSlider(nullptr)
42​ , m_mirrorCanvas(nullptr)
43​ , m_canvas(nullptr)
38{ 44​{
39 QWidget *page = new QWidget(this); 45​ QWidget *page = new QWidget(this);
40 m_layout = new QVBoxLayout(page); 46​ m_layout = new QVBoxLayout(page);
47​ m_horizontalLayout = new QHBoxLayout();
41 48​
42 m_overviewWidget = new OverviewWidget(this); 49​ m_overviewWidget = new OverviewWidget(this);
43 m_overviewWidget->setMinimumHeight(50); 50​ m_overviewWidget->setMinimumHeight(50);
Context not available.
54 if(m_canvas == canvas) 61​ if(m_canvas == canvas)
55 return; 62​ return;
56 63​
57 setEnabled(canvas != 0); 64​ setEnabled(canvas != nullptr);
58 65​
59 if (m_canvas) { 66​ if (m_canvas) {
60 m_canvas->disconnectCanvasObserver(this); 67​ m_canvas->disconnectCanvasObserver(this);
Context not available.
64 if (m_zoomSlider) { 71​ if (m_zoomSlider) {
65 m_layout->removeWidget(m_zoomSlider); 72​ m_layout->removeWidget(m_zoomSlider);
66 delete m_zoomSlider; 73​ delete m_zoomSlider;
67 m_zoomSlider = 0; 74​ m_zoomSlider = nullptr;
75​ }
76​
77​ if (m_rotateSlider) {
78​ m_horizontalLayout->removeWidget(m_rotateSlider);
79​ delete m_rotateSlider;
80​ m_rotateSlider = nullptr;
68 } 81​ }
69 82​
83​ if (m_mirrorCanvas) {
84​ m_horizontalLayout->removeWidget(m_mirrorCanvas);
85​ delete m_mirrorCanvas;
86​ m_mirrorCanvas = nullptr;
87​ }
88​
89​ m_layout->removeItem(m_horizontalLayout);
90​
70 m_canvas = dynamic_cast<KisCanvas2*>(canvas); 91​ m_canvas = dynamic_cast<KisCanvas2*>(canvas);
71 92​
72 m_overviewWidget->setCanvas(canvas); 93​ m_overviewWidget->setCanvas(canvas);
73 if (m_canvas && m_canvas->viewManager() && m_canvas->viewManager()->zoomController() && m_canvas->viewManager()->zoomController()->zoomAction()) { 94​ if (m_canvas && m_canvas->viewManager() && m_canvas->viewManager()->zoomController() && m_canvas->viewManager()->zoomController()->zoomAction()) {
74 m_zoomSlider = m_canvas->viewManager()->zoomController()->zoomAction()->createWidget(m_canvas->imageView()->KisView::statusBar()); 95​ m_zoomSlider = m_canvas->viewManager()->zoomController()->zoomAction()->createWidget(m_canvas->imageView()->KisView::statusBar());
75 m_layout->addWidget(m_zoomSlider); 96​ m_layout->addWidget(m_zoomSlider);
97​
98​ m_rotateSlider = new KisDoubleSliderSpinBox();
99​ m_rotateSlider->setRange(-180, 180, 2);
100​ m_rotateSlider->setValue(m_canvas->rotationAngle());
101​ m_rotateSlider->setPrefix(i18n("Rotation: "));
102​ m_rotateSlider->setSuffix("°");
103​ connect(m_rotateSlider, SIGNAL(valueChanged(qreal)), this, SLOT(rotateCanvasView(qreal)), Qt::UniqueConnection);
104​ connect(m_canvas->imageView()->canvasController(), SIGNAL(canvasRotated(qreal)), this, SLOT(updateSlider()));
105​
106​ m_mirrorCanvas = new QToolButton();
dkazakovUnsubmitted
Not Done

Erm... why this check is needed?

If it is about avoiding cycling updates via OverviewDockerDock::updateSlider(), then it is better to use KisSignalsBlocker to block slider's signals for the update time. Usage of sender() method is discouraged by Qt's documentation, because it can work a bit unexpectedly sometimes...

dkazakov: Erm... why this check is needed? If it is about avoiding cycling updates via…
107​ m_mirrorCanvas->setCheckable(true);
108​ m_mirrorCanvas->setIcon(KisIconUtils::loadIcon("mirror-view"));
109​ m_mirrorCanvas->setChecked(m_canvas->xAxisMirrored());
110​ connect(m_mirrorCanvas, SIGNAL(toggled(bool)), this, SLOT(mirrorCanvas(bool)));
111​ connect(m_canvas->imageView()->canvasController(), SIGNAL(canvasMirrored(bool)), this, SLOT(updateMirrorButton()));
112​ m_horizontalLayout->addWidget(m_mirrorCanvas);
113​ m_horizontalLayout->addWidget(m_rotateSlider);
114​ m_layout->addLayout(m_horizontalLayout);
76 } 115​ }
77} 116​}
78 117​
79void OverviewDockerDock::unsetCanvas() 118​void OverviewDockerDock::unsetCanvas()
80{ 119​{
81 setEnabled(false); 120​ setEnabled(false);
82 m_canvas = 0; 121​ m_canvas = nullptr;
83 m_overviewWidget->unsetCanvas(); 122​ m_overviewWidget->unsetCanvas();
84} 123​}
85 124​
125​void OverviewDockerDock::rotateCanvasView(qreal rotation)
126​{
127​ KisCanvasController *canvasController =
128​ dynamic_cast<KisCanvasController*>(m_canvas->viewManager()->canvasBase()->canvasController());
129​ if (canvasController) {
130​ canvasController->rotateCanvas(rotation-m_canvas->rotationAngle());
131​ }
132​}
133​
134​void OverviewDockerDock::updateSlider()
135​{
136​ qreal rotation = m_canvas->rotationAngle();
137​ if (rotation > 180) {
138​ rotation = rotation - 360;
139​ } else if (rotation < -180) {
140​ rotation = rotation + 360;
141​ }
142​ if (m_rotateSlider->value() != rotation) {
143​ m_rotateSlider->setValue(rotation);
144​ }
145​}
146​
147​void OverviewDockerDock::mirrorCanvas(bool mirror)
148​{
149​ KisCanvasController *canvasController =
150​ dynamic_cast<KisCanvasController*>(m_canvas->viewManager()->canvasBase()->canvasController());
151​ if (canvasController) {
152​ canvasController->mirrorCanvas(mirror);
153​ }
154​}
155​
156​void OverviewDockerDock::updateMirrorButton()
157​{
158​ m_mirrorCanvas->setChecked(m_canvas->xAxisMirrored());
159​}
160​
86 161​
Context not available.