Differential D18952 Diff 51576 find-modules/FindCanberra.cmake

Changeset View

Standalone View

View Options

find-modules/FindCanberra.cmake

  • This file was added.
1​#.rst:
2​# FindCanberra
3​# -------
4​#
5​# Try to find Canberra event sound library.
apolUnsubmitted
Done

Maybe you can follow the style (rst syntax?) that Volker used here D18944.

apol: Maybe you can follow the style (rst syntax?) that Volker used here D18944.
6​#
7​# This will define the following variables:
8​#
9​# ``CANBERRA_FOUND``
10​# True if (the requested version of) Canberra is available
11​# ``CANBERRA_VERSION``
12​# The version of Canberra
13​# ``CANBERRA_LIBRARIES``
14​# The libraries of Canberra for use with target_link_libraries()
15​# ``CANBERRA_INCLUDE_DIRS``
16​# The include dirs of Canberra for use with target_include_directories()
kropUnsubmitted
Done

The variables shall be renamed "Canberra_XXX".

If needed, the uppercase ones shall be added at the bottom of the file with a comment to indicate they only exist for compatibility.

krop: The variables shall be renamed "Canberra_XXX". If needed, the uppercase ones shall be added at…
17​#
18​# Since 5.56.0.
19​
20​#=============================================================================
21​# Copyright (c) 2012 Raphael Kubo da Costa <rakuco@FreeBSD.org>
22​# Copyright (c) 2019 Harald Sitter <sitter@kde.org>
23​#
24​# Redistribution and use in source and binary forms, with or without
25​# modification, are permitted provided that the following conditions
26​# are met:
27​#
28​# 1. Redistributions of source code must retain the copyright
29​# notice, this list of conditions and the following disclaimer.
30​# 2. Redistributions in binary form must reproduce the copyright
31​# notice, this list of conditions and the following disclaimer in the
32​# documentation and/or other materials provided with the distribution.
33​# 3. The name of the author may not be used to endorse or promote products
34​# derived from this software without specific prior written permission.
35​#
36​# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
37​# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
38​# OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
39​# IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
40​# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
41​# NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
42​# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
43​# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
44​# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
45​# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
46​#=============================================================================
47​
48​find_package(PkgConfig)
49​pkg_check_modules(PC_CANBERRA libcanberra)
kropUnsubmitted
Done

Use the 'QUIET' keyword for both lines

krop: Use the 'QUIET' keyword for both lines
50​
51​find_library(CANBERRA_LIBRARIES
52​ NAMES canberra
53​ HINTS ${PC_CANBERRA_LIBRARY_DIRS} ${PC_CANBERRA_LIBDIR}
kropUnsubmitted
Done

PC_CANBERRA_LIBDIR isn't needed

krop: PC_CANBERRA_LIBDIR isn't needed
54​)
55​
56​find_path(CANBERRA_INCLUDE_DIRS
57​ NAMES canberra.h
58​ HINTS ${PC_CANBERRA_INCLUDE_DIRS} ${PC_CANBERRA_INCLUDEDIR}
kropUnsubmitted
Done

Same thing for PC_CANBERRA_INCLUDEDIR

krop: Same thing for PC_CANBERRA_INCLUDEDIR
59​)
60​
61​set(CANBERRA_VERSION ${PC_CANBERRA_VERSION})
62​
63​include(FindPackageHandleStandardArgs)
64​find_package_handle_standard_args(Canberra
65​ REQUIRED_VARS CANBERRA_LIBRARIES CANBERRA_INCLUDE_DIRS
66​ VERSION_VAR CANBERRA_VERSION
67​)
68​
69​mark_as_advanced(CANBERRA_LIBRARIES CANBERRA_INCLUDE_DIRS CANBERRA_VERSION)
kropUnsubmitted
Done

Also add

FOUND_VAR Canberra_FOUND

The default for CMake 2.8.12 which ECM requires is '<UPPERCASED_NAME>_FOUND'.

krop: Also add ``` FOUND_VAR Canberra_FOUND ``` The default for CMake 2.8.12 which ECM requires is…