Differential D18230 Diff 51033 src/activities/question_and_answer/Question_and_answer.qml

Changeset View

Standalone View

View Options

src/activities/question_and_answer/Question_and_answer.qml

  • This file was added.
1​/* GCompris - question_and_answer.qml
2​ *
3​ * Copyright (C) 2018 Amit Sagtani <asagtani06@gmail.com>
4​ *
5​ * Authors:
6​ * Amit Sagtani <asagtani06@gmail.com>
7​ *
8​ * This program is free software; you can redistribute it and/or modify
9​ * it under the terms of the GNU General Public License as published by
10​ * the Free Software Foundation; either version 3 of the License, or
11​ * (at your option) any later version.
12​ *
13​ * This program is distributed in the hope that it will be useful,
14​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
15​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16​ * GNU General Public License for more details.
17​ *
18​ * You should have received a copy of the GNU General Public License
19​ * along with this program; if not, see <http://www.gnu.org/licenses/>.
20​ */
21​import QtQuick 2.6
22​import GCompris 1.0
23​import QtQuick.Controls 1.5
24​import QtQuick.Layouts 1.1
25​import QtQuick.Controls.Styles 1.4
26​
27​import "../../core"
28​import "question_and_answer.js" as Activity
29​
30​ActivityBase {
echarruauUnsubmitted
Done

You need to remove this line, otherwise it does not compile.

echarruau: You need to remove this line, otherwise it does not compile.
31​ id: activity
32​ onStart: focus = true
33​ onStop: {}
34​ pageComponent: Image {
echarruauUnsubmitted
Done

I get the following message when running
qrc:/gcompris/src/activities/question_and_answer/Question_and_answer.qml:33: ReferenceError: Dataset is not defined

echarruau: I get the following message when running qrc…
35​ id: background
36​ anchors.fill: parent
37​ source: "qrc:/gcompris/src/activities/algebra_by/resource/background.svg"
38​ signal start
39​ signal stop
40​
41​ Component.onCompleted: {
42​ dialogActivityConfig.getInitialConfiguration()
43​ activity.start.connect(start)
44​ activity.stop.connect(stop)
45​ }
jjazeixUnsubmitted
Done

missing dialogActivityConfig.getInitialConfiguration() to initialize the config dialog

jjazeix: missing dialogActivityConfig.getInitialConfiguration() to initialize the config dialog
46​
47​ // Add here the QML items you need to access in javascript
48​ QtObject {
49​ id: items
50​ property Item main: activity.main
51​ property alias background: background
52​ property alias bar: bar
53​ property alias bonus: bonus
54​ property alias menuScreen: menuScreen
55​ property alias menuModel: menuScreen.menuModel
56​ property alias startFinishButton: startFinishButton
57​ property string currentMode: "freeMode"
58​ property alias questionsGrid: questionsGrid
59​ property alias sampleQuestion: sampleQuestion
60​ property alias parser: parser
61​ property int noOfQuestions: 9
62​ property int sampleWidth: 750
63​ property bool levelStarted: false
64​ property bool showAnswerStatus: false
echarruauUnsubmitted
Not Done

Seems like a hard coded value?

echarruau: Seems like a hard coded value?
AkshayCHDAuthorUnsubmitted
Not Done

No these values change depending on the number of questions in the json

AkshayCHD: No these values change depending on the number of questions in the json
65​ property var questions: []
jjazeixUnsubmitted
Done

int?

jjazeix: int?
66​ property var answers: []
67​ property var allQuestions: []
68​ property var longestQuestion: ""
69​ property int questionsCount: 0
jjazeixUnsubmitted
Done

if it is a string, use a string (else keep it as var)

jjazeix: if it is a string, use a string (else keep it as var)
jjazeixUnsubmitted
Not Done

it's really not a string?

jjazeix: it's really not a string?
70​ property var hash: []
71​ property int currentSubActivity
72​ }
jjazeixUnsubmitted
Done

int?

jjazeix: int?
73​
74​ onStart: { Activity.init(items) }
jjazeixUnsubmitted
Done

int?

jjazeix: int?
75​ onStop: { Activity.stop() }
76​
77​ JsonParser {
78​ id: parser
79​ }
80​
81​ GCText {
82​ id: noQuestionText
83​ visible: (items.questions.length === 0)
84​ anchors.centerIn: playArea
85​ text: qsTr("You are in Admin mode but you haven't selected any question")
86​ z: 1
87​ wrapMode: Text.WordWrap
88​ color: "white"
jjazeixUnsubmitted
Done

you haven't

jjazeix: you haven't
89​ fontSize: regularSize
90​ }
91​
92​ GCText {
93​ id: sampleQuestion
94​ visible: false
95​ width: background.width > background.height ? items.sampleWidth / 3 : questionsGrid.width / 2
96​ wrapMode: Text.WordWrap
97​ color: "white"
98​ fontSize: smallSize
99​ }
100​
101​ Rectangle {
102​ id: playArea
103​ width: background.width * 0.95
104​ height: background.height * 0.90 - bar.height
105​ border.color: "black"
106​ border.width: 5
107​ anchors.horizontalCenter: parent.horizontalCenter
108​ anchors.bottom: bar.top
109​ anchors.bottomMargin: 30
110​ color: "#32000000"
111​ radius: 20
112​ }
113​
114​ GridView {
115​ id: questionsGrid
116​ visible: false
117​ model: items.questions.length
118​ anchors.top: playArea.top
119​ anchors.left: playArea.left
120​ anchors.leftMargin: 30
121​ width: playArea.width
122​ height: playArea.height - 200
123​ anchors.horizontalCenter: playArea.horizontalCenter
124​ cellHeight: (sampleQuestion.height < sampleQuestion.width * 0.5) ? sampleQuestion.height * 3 : sampleQuestion.height * 1.1
125​ cellWidth: sampleQuestion.width * 2
126​ property int spacing: 60
127​
128​ delegate:
129​ Item {
130​ GCText {
131​ id: questionText
132​ text: items.questions[index]
133​ wrapMode: Text.WordWrap
134​ horizontalAlignment: Text.AlignHCenter
135​ fontSize: smallSize
136​ verticalAlignment: Text.AlignVCenter
137​ width: questionsGrid.cellWidth * 0.5
138​ height: questionsGrid.cellHeight
139​ fontSizeMode: Text.Fit
140​ }
141​ GCText {
142​ id: equals
143​ height: questionsGrid.cellHeight
144​ text: " = "
145​ width: questionsGrid.cellWidth * 0.10
146​ verticalAlignment: Text.AlignVCenter
147​ anchors.left: questionText.right
148​ }
149​ TextField {
150​ id: answerText
151​ height: bar.height * 0.4
152​ width: questionsGrid.cellWidth * 0.30
153​ anchors.left: equals.right
154​ anchors.verticalCenter: questionText.verticalCenter
155​ activeFocusOnPress: true
156​ readOnly: !items.levelStarted
157​ onReadOnlyChanged: focus = false
158​ onVisibleChanged: text = ""
159​ horizontalAlignment: TextInput.AlignHCenter
160​ font.pixelSize: 24
161​ anchors.topMargin: 200
162​ style: TextFieldStyle {
163​ textColor: "black"
164​ background: Rectangle {
165​ radius: 5
166​ color: "transparent"
167​ implicitWidth: bar.height * 0.9
168​ implicitHeight: 130/800*parent.width
169​ border.color: "#333"
170​ border.width: 2
171​ }
172​ }
173​ }
174​ Image {
175​ id: question_image
176​ width: 50
177​ height: 50
178​ anchors.verticalCenter: questionText.verticalCenter
179​ anchors.left: answerText.right
180​ anchors.top: questionText.top
181​ visible: items.showAnswerStatus
182​ fillMode: Image.PreserveAspectFit
183​ source: (answerText.text).trim() === items.answers[index] ?
184​ "qrc:/gcompris/src/activities/question_and_answer/resource/right.svg" :
185​ "qrc:/gcompris/src/activities/photo_hunter/resource/wrong.svg"
186​ }
187​ }
188​
189​ }
190​
191​ MenuScreen {
192​ id: menuScreen
193​ z:2
194​ }
195​
196​ Button {
197​ id: startFinishButton
198​ property bool visibility: true
199​ style: GCButtonStyle { theme: "highContrast" }
200​ height: bar.height * 0.4
201​ visible: !menuScreen.visible && visibility && !noQuestionText.visible
202​ text: items.levelStarted ? qsTr("Submit") : qsTr("Start")
203​ onClicked: {
204​ if(items.levelStarted) {
205​ items.showAnswerStatus = true
206​ items.levelStarted = false
207​ visibility = false
208​ }
209​ else {
210​ items.levelStarted = true
211​ items.showAnswerStatus = false
212​ }
213​ }
214​ anchors.top: playArea.bottom
215​ anchors.right: restartButton.left
216​ anchors.margins: 20
217​ }
jjazeixUnsubmitted
Done

it seems you never actually store the parameters in the config file, so if you do changes, quit the game and restart it, everything is lost?
There is three methods in the item that should be used:
onLoadData, onSaveData and you should set the default values via setDefaultValues instead of doing everything in the onConfigClicked signal.

jjazeix: it seems you never actually store the parameters in the config file, so if you do changes, quit…
218​
219​ Button {
220​ id: restartButton
221​ style: GCButtonStyle { theme: "highContrast"}
222​ height: bar.height * 0.4
223​ visible: !menuScreen.visible && !noQuestionText.visible
224​ text: qsTr("Restart")
225​ onClicked: {
226​ Activity.restartLevel()
227​ }
228​ anchors.top: playArea.bottom
229​ anchors.right: playArea.right
230​ anchors.margins: 20
231​ }
232​
233​ ExclusiveGroup {
234​ id: configOptions
235​ }
jjazeixUnsubmitted
Done

if you use an ExclusiveGroup, you won't need to change the other CheckBox

jjazeix: if you use an ExclusiveGroup, you won't need to change the other CheckBox
236​
237​ DialogActivityConfig {
238​ id: dialogActivityConfig
239​ currentActivity: activity
240​ content: Component {
241​ Item {
242​ width: dialogActivityConfig.width
243​ height: dialogActivityConfig.height
jjazeixUnsubmitted
Done

unused?

jjazeix: unused?
244​ property alias grid: grid
245​ property alias adminMode: adminMode
246​ GCDialogCheckBox {
247​ id: freeMode
248​ width: parent.width - 50
249​ text: qsTr("Free Mode")
250​ checked: items.currentMode === "freeMode" ? true : false
251​ exclusiveGroup: configOptions
252​ onCheckedChanged: {
253​ if(checked) {
254​ items.currentMode = "freeMode"
255​ adminMode.checked = false
256​
257​ }
258​ Activity.modeChanged()
259​ }
260​ }
261​
262​ GCDialogCheckBox {
263​ id: adminMode
264​ width: parent.width - 50
265​ text: qsTr("Admin Mode")
266​ checked: items.currentMode === "adminMode" ? true : false
267​ anchors.top: freeMode.bottom
268​ exclusiveGroup: configOptions
269​ onCheckedChanged: {
270​ if(checked) {
jjazeixUnsubmitted
Done

use GCText, not Text to have the same font everywhere

jjazeix: use GCText, not Text to have the same font everywhere
271​ items.currentMode = "adminMode"
272​ freeMode.checked = false
273​ }
274​ Activity.modeChanged()
275​ }
276​ }
277​
278​ CheckBox {
279​ id:sampleCheckBox
280​ text: items.longestQuestion
281​ checked: false
282​ width: ((dialogActivityConfig.width * 2) / (items.allQuestions[0].length)) * 0.9
283​ visible: false
284​ style: CheckBoxStyle {
285​ label: Text {
286​ text: items.longestQuestion
287​ wrapMode: Text.WordWrap
288​ anchors.leftMargin: 10
289​ }
290​ indicator: Rectangle {
291​ implicitWidth: sampleCheckBox.width / 5
292​ }
293​ }
294​ }
295​ GridView {
296​ id: grid
297​ width: dialogActivityConfig.width
298​ height: dialogActivityConfig.height
299​ anchors.top: adminMode.bottom
300​ visible: adminMode.checked
301​ anchors.topMargin: 30
302​ cellWidth: (dialogActivityConfig.width * 2) / (items.allQuestions[0].length)
303​ cellHeight: Math.max(sampleCheckBox.height, 40)
304​ model: items.questionsCount
305​ focus: true
306​ delegate: Component {
307​ id: contractDelegate
308​ CheckBox {
309​ id:checkBoxQuestion
310​ property int questionSet: items.hash[index][0]
311​ property int questionIndex: items.hash[index][1]
312​ checked: false
313​ width: grid.cellWidth * 0.9
314​ height: grid.cellHeight * 0.9
315​ style: CheckBoxStyle {
316​ label: Text {
317​ text: (items.allQuestions.length > 0) ? items.allQuestions[checkBoxQuestion.questionSet][checkBoxQuestion.questionIndex] : ""
318​ wrapMode: Text.WordWrap
319​ anchors.leftMargin: 10
320​ }
321​ indicator: Rectangle {
322​ implicitWidth: grid.cellWidth / 8
323​ implicitHeight: Math.max(grid.cellHeight / 2, 40)
324​ radius: 3
325​ border.color: control.activeFocus ? "darkblue" : "gray"
326​ border.width: 1
327​ Rectangle {
328​ visible: control.checked
329​ color: "#555"
330​ border.color: "#333"
331​ radius: 1
332​ anchors.margins: 4
333​ anchors.fill: parent
334​ }
335​ }
336​ }
337​ onCheckedChanged: {
338​ if(checked) {
339​ Activity.addQuestion(questionSet, questionIndex)
340​ } else {
341​ Activity.removeQuestion(items.allQuestions[questionSet][questionIndex])
342​ }
343​ }
344​ }
345​ }
346​ }
347​ }
348​ }
349​ onClose: {
350​ Activity.getMaxWidth()
351​ home()
352​ }
353​
354​ onLoadData: {
355​ if(dataToSave["currentMode"]) {
356​ items.currentMode = dataToSave["currentMode"]
357​ }
358​ }
359​ onSaveData: {
360​ dataToSave = {"currentMode": items.currentMode}
361​ }
362​
363​ function setDefaultValues() {
364​ items.levelStarted = false
365​ if (items.currentMode === "adminMode") {
366​ items.questions = []
367​ items.answers = []
368​ }
369​ dialogActivityConfig.active = true
370​ displayDialog(dialogActivityConfig)
371​ var dialogChildren = dialogActivityConfig.configItem.grid.contentItem.children
372​ for(var child in dialogChildren) {
373​ if (typeof dialogChildren[child].checked !== 'undefined') {
374​ dialogChildren[child].checked = false
375​ }
jjazeixUnsubmitted
Done

you can use of temp variable to store the children, it will be easier to read after

jjazeix: you can use of temp variable to store the children, it will be easier to read after
376​ }
377​ }
378​ }
379​
380​ DialogHelp {
381​ id: dialogHelp
382​ onClose: home()
383​ }
384​
385​ Bar {
386​ id: bar
387​ property BarEnumContent activityZoneContent: BarEnumContent { value: home | level | config}
388​ property BarEnumContent menuScreenContent: BarEnumContent { value: help | home }
389​ content: menuScreen.started ? menuScreenContent : activityZoneContent
390​ onHelpClicked: {
391​ displayDialog(dialogHelp)
392​ }
393​ onPreviousLevelClicked: Activity.previousLevel()
394​ onNextLevelClicked: Activity.nextLevel()
395​ onHomeClicked: {
396​ if(items.menuScreen.started)
397​ activity.home()
398​ else {
399​ Activity.launchMenuScreen()
400​ }
401​ }
402​ onConfigClicked: {
403​ dialogActivityConfig.setDefaultValues()
404​ }
405​ }
406​
407​ Bonus {
408​ id: bonus
409​ Component.onCompleted: win.connect(Activity.nextLevel)
410​ }
411​ }
412​
413​}