Differential D18570 Diff 50397 platformsupport/scenes/opengl/abstract_egl_backend.cpp

Changeset View

Standalone View

View Options

platformsupport/scenes/opengl/abstract_egl_backend.cpp

Context not available.
127 return eglGetProcAddress(name); 127​ return eglGetProcAddress(name);
128} 128​}
129 129​
130​GLboolean AbstractEglBackend::queryWaylandBufferWL(wl_resource *buffer,
cfeckUnsubmitted
Done

Does it really need to be declared GLboolean? You are using the logical && operator anyway.

cfeck: Does it really need to be declared `GLboolean`? You are using the logical `&&` operator anyway.
romanggUnsubmitted
Not Done

Put this function in EglStreamBackend only. On another note, do we need it at all? It's called only once.

romangg: Put this function in EglStreamBackend only. On another note, do we need it at all? It's called…
131​ EGLint attribute, EGLint *value)
132​{
133​ return eglQueryWaylandBufferWL &&
134​ eglQueryWaylandBufferWL(eglDisplay(), buffer, attribute, value);
135​}
136​
130void AbstractEglBackend::initKWinGL() 137​void AbstractEglBackend::initKWinGL()
131{ 138​{
132 GLPlatform *glPlatform = GLPlatform::instance(); 139​ GLPlatform *glPlatform = GLPlatform::instance();
Context not available.