Differential D18230 Diff 50380 src/activities/question_and_answer/Question_and_answer.qml

Changeset View

Standalone View

View Options

src/activities/question_and_answer/Question_and_answer.qml

  • This file was added.
1​/* GCompris - question_and_answer.qml
2​ *
3​ * Copyright (C) 2018 Amit Sagtani <asagtani06@gmail.com>
4​ *
5​ * Authors:
6​ * Amit Sagtani <asagtani06@gmail.com>
7​ *
8​ * This program is free software; you can redistribute it and/or modify
9​ * it under the terms of the GNU General Public License as published by
10​ * the Free Software Foundation; either version 3 of the License, or
11​ * (at your option) any later version.
12​ *
13​ * This program is distributed in the hope that it will be useful,
14​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
15​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16​ * GNU General Public License for more details.
17​ *
18​ * You should have received a copy of the GNU General Public License
19​ * along with this program; if not, see <http://www.gnu.org/licenses/>.
20​ */
21​import QtQuick 2.6
22​import GCompris 1.0
23​import QtQuick.Controls 1.5
24​import QtQuick.Layouts 1.1
25​import QtQuick.Controls.Styles 1.4
26​
27​import "../../core"
28​import "question_and_answer.js" as Activity
29​import "dataset.js" as Dataset
30​
echarruauUnsubmitted
Done

You need to remove this line, otherwise it does not compile.

echarruau: You need to remove this line, otherwise it does not compile.
31​ActivityBase {
32​ id: activity
33​ property var dataset: Dataset
34​ onStart: focus = true
echarruauUnsubmitted
Done

I get the following message when running
qrc:/gcompris/src/activities/question_and_answer/Question_and_answer.qml:33: ReferenceError: Dataset is not defined

echarruau: I get the following message when running qrc…
35​ onStop: {}
36​ pageComponent: Image {
37​ id: background
38​ anchors.fill: parent
39​ source: "qrc:/gcompris/src/activities/algebra_by/resource/background.svg"
40​ signal start
41​ signal stop
42​
43​ Component.onCompleted: {
44​ dialogActivityConfig.getInitialConfiguration()
45​ activity.start.connect(start)
jjazeixUnsubmitted
Done

missing dialogActivityConfig.getInitialConfiguration() to initialize the config dialog

jjazeix: missing dialogActivityConfig.getInitialConfiguration() to initialize the config dialog
46​ activity.stop.connect(stop)
47​ }
48​
49​ // Add here the QML items you need to access in javascript
50​ QtObject {
51​ id: items
52​ property Item main: activity.main
53​ property alias background: background
54​ property alias bar: bar
55​ property alias bonus: bonus
56​ property alias menuScreen: menuScreen
57​ property alias menuModel: menuScreen.menuModel
58​ property alias startFinishButton: startFinishButton
59​ property string currentMode: "freeMode"
60​ property alias questionsGrid: questionsGrid
61​ property alias sampleQuestion: sampleQuestion
62​ property int noOfQuestions: 9
63​ property var sampleWidth: 750
64​ property bool levelStarted: false
echarruauUnsubmitted
Not Done

Seems like a hard coded value?

echarruau: Seems like a hard coded value?
AkshayCHDAuthorUnsubmitted
Not Done

No these values change depending on the number of questions in the json

AkshayCHD: No these values change depending on the number of questions in the json
65​ property bool showAnswerStatus: false
jjazeixUnsubmitted
Done

int?

jjazeix: int?
66​ property var questions: []
67​ property var answers: []
68​ property var allQuestions: []
69​ property var longestQuestion: ""
jjazeixUnsubmitted
Done

if it is a string, use a string (else keep it as var)

jjazeix: if it is a string, use a string (else keep it as var)
jjazeixUnsubmitted
Not Done

it's really not a string?

jjazeix: it's really not a string?
70​ property var questionsCount: 0
71​ property var hash: []
72​ property var currentSubActivity
jjazeixUnsubmitted
Done

int?

jjazeix: int?
73​ }
74​
jjazeixUnsubmitted
Done

int?

jjazeix: int?
75​ onStart: { Activity.init(items, dataset) }
76​ onStop: { Activity.stop() }
77​
78​
79​ GCText {
80​ id: noQuestionText
81​ visible: (items.questions.length === 0)
82​ anchors.centerIn: playArea
83​ text: qsTr("You are in Admin mode but havn't selected any question")
84​ z: 1
85​ wrapMode: Text.WordWrap
86​ color: "white"
87​ fontSize: regularSize
88​ }
jjazeixUnsubmitted
Done

you haven't

jjazeix: you haven't
89​
90​ GCText {
91​ id: sampleQuestion
92​ visible: false
93​ width: background.width > background.height ? items.sampleWidth / 3 : questionsGrid.width / 2
94​ wrapMode: Text.WordWrap
95​ color: "white"
96​ fontSize: smallSize
97​ }
98​
99​ Rectangle {
100​ id: playArea
101​ width: background.width * 0.95
102​ height: background.height * 0.90 - bar.height
103​ border.color: "black"
104​ border.width: 5
105​ anchors.horizontalCenter: parent.horizontalCenter
106​ anchors.bottom: bar.top
107​ anchors.bottomMargin: 30
108​ color: "#32000000"
109​ radius: 20
110​ }
111​
112​ GridView {
113​ id: questionsGrid
114​ visible: false
115​ model: items.questions.length
116​ anchors.top: playArea.top
117​ anchors.left: playArea.left
118​ anchors.leftMargin: 30
119​ width: playArea.width
120​ height: playArea.height - 200
121​ anchors.horizontalCenter: playArea.horizontalCenter
122​ cellHeight: (sampleQuestion.height < sampleQuestion.width * 0.5) ? sampleQuestion.height * 3 : sampleQuestion.height * 1.1
123​ cellWidth: sampleQuestion.width * 2
124​ property int spacing: 60
125​
126​ delegate:
127​ Item {
128​ GCText {
129​ id: questionText
130​ text: items.questions[index]
131​ wrapMode: Text.WordWrap
132​ horizontalAlignment: Text.AlignHCenter
133​ fontSize: smallSize
134​ verticalAlignment: Text.AlignVCenter
135​ width: questionsGrid.cellWidth * 0.5
136​ height: questionsGrid.cellHeight
137​ fontSizeMode: Text.Fit
138​ }
139​ GCText {
140​ id: equals
141​ height: questionsGrid.cellHeight
142​ text: " = "
143​ width: questionsGrid.cellWidth * 0.10
144​ verticalAlignment: Text.AlignVCenter
145​ anchors.left: questionText.right
146​ }
147​ TextField {
148​ id: answerText
149​ height: bar.height * 0.4
150​ width: questionsGrid.cellWidth * 0.30
151​ anchors.left: equals.right
152​ anchors.verticalCenter: questionText.verticalCenter
153​ activeFocusOnPress: true
154​ readOnly: !items.levelStarted
155​ onReadOnlyChanged: focus = false
156​ onVisibleChanged: text = ""
157​ horizontalAlignment: TextInput.AlignHCenter
158​ font.pixelSize: 24
159​ anchors.topMargin: 200
160​ style: TextFieldStyle {
161​ textColor: "black"
162​ background: Rectangle {
163​ radius: 5
164​ color: "transparent"
165​ implicitWidth: bar.height * 0.9
166​ implicitHeight: 130/800*parent.width
167​ border.color: "#333"
168​ border.width: 2
169​ }
170​ }
171​ }
172​ Image {
173​ id: question_image
174​ width: 50
175​ height: 50
176​ anchors.verticalCenter: questionText.verticalCenter
177​ anchors.left: answerText.right
178​ anchors.top: questionText.top
179​ visible: items.showAnswerStatus
180​ fillMode: Image.PreserveAspectFit
181​ source: (answerText.text).trim() === items.answers[index] ?
182​ "qrc:/gcompris/src/activities/question_and_answer/resource/right.svg" :
183​ "qrc:/gcompris/src/activities/photo_hunter/resource/wrong.svg"
184​ }
185​ }
186​
187​ }
188​
189​ MenuScreen {
190​ id: menuScreen
191​ z:2
192​ }
193​
194​ Button {
195​ id: startFinishButton
196​ property bool visibility: true
197​ style: GCButtonStyle { theme: "highContrast" }
198​ height: bar.height * 0.4
199​ visible: !menuScreen.visible && visibility && !noQuestionText.visible
200​ text: items.levelStarted ? qsTr("Submit") : qsTr("Start")
201​ onClicked: {
202​ if(items.levelStarted) {
203​ items.showAnswerStatus = true
204​ items.levelStarted = false
205​ visibility = false
206​ }
207​ else {
208​ items.levelStarted = true
209​ items.showAnswerStatus = false
210​ }
211​ }
212​ anchors.top: playArea.bottom
213​ anchors.right: restartButton.left
214​ anchors.margins: 20
215​ }
216​
217​ Button {
jjazeixUnsubmitted
Done

it seems you never actually store the parameters in the config file, so if you do changes, quit the game and restart it, everything is lost?
There is three methods in the item that should be used:
onLoadData, onSaveData and you should set the default values via setDefaultValues instead of doing everything in the onConfigClicked signal.

jjazeix: it seems you never actually store the parameters in the config file, so if you do changes, quit…
218​ id: restartButton
219​ style: GCButtonStyle { theme: "highContrast"}
220​ height: bar.height * 0.4
221​ visible: !menuScreen.visible && !noQuestionText.visible
222​ text: qsTr("Restart")
223​ onClicked: {
224​ Activity.restartLevel()
225​ }
226​ anchors.top: playArea.bottom
227​ anchors.right: playArea.right
228​ anchors.margins: 20
229​ }
230​
231​ ExclusiveGroup {
232​ id: configOptions
233​ }
234​
235​ DialogActivityConfig {
jjazeixUnsubmitted
Done

if you use an ExclusiveGroup, you won't need to change the other CheckBox

jjazeix: if you use an ExclusiveGroup, you won't need to change the other CheckBox
236​ id: dialogActivityConfig
237​ currentActivity: activity
238​ property bool checked: false
239​ content: Component {
240​ Item {
241​ width: dialogActivityConfig.width
242​ height: dialogActivityConfig.height
243​ property alias grid: grid
jjazeixUnsubmitted
Done

unused?

jjazeix: unused?
244​ property alias adminMode: adminMode
245​ GCDialogCheckBox {
246​ id: freeMode
247​ width: parent.width - 50
248​ text: qsTr("Free Mode")
249​ checked: items.currentMode === "freeMode" ? true : false
250​ exclusiveGroup: configOptions
251​ onCheckedChanged: {
252​ if(checked) {
253​ items.currentMode = "freeMode"
254​ adminMode.checked = false
255​
256​ }
257​ Activity.modeChanged()
258​ }
259​ }
260​
261​ GCDialogCheckBox {
262​ id: adminMode
263​ width: parent.width - 50
264​ text: qsTr("Admin Mode")
265​ checked: items.currentMode === "adminMode" ? true : false
266​ anchors.top: freeMode.bottom
267​ exclusiveGroup: configOptions
268​ onCheckedChanged: {
269​ if(checked) {
270​ items.currentMode = "adminMode"
jjazeixUnsubmitted
Done

use GCText, not Text to have the same font everywhere

jjazeix: use GCText, not Text to have the same font everywhere
271​ freeMode.checked = false
272​ }
273​ Activity.modeChanged()
274​ }
275​ }
276​
277​ CheckBox {
278​ id:sampleCheckBox
279​ text: items.longestQuestion
280​ checked: false
281​ width: ((dialogActivityConfig.width * 2) / (items.allQuestions[0].length)) * 0.9
282​ visible: false
283​ style: CheckBoxStyle {
284​ label: Text {
285​ text: items.longestQuestion
286​ wrapMode: Text.WordWrap
287​ anchors.leftMargin: 10
288​ }
289​ indicator: Rectangle {
290​ implicitWidth: sampleCheckBox.width / 5
291​ }
292​ }
293​ }
294​ GridView {
295​ id: grid
296​ width: dialogActivityConfig.width
297​ height: dialogActivityConfig.height
298​ anchors.top: adminMode.bottom
299​ visible: adminMode.checked
300​ anchors.topMargin: 30
301​ cellWidth: (dialogActivityConfig.width * 2) / (items.allQuestions[0].length)
302​ cellHeight: Math.max(sampleCheckBox.height, 40)
303​ model: items.questionsCount
304​ focus: true
305​ delegate: Component {
306​ id: contractDelegate
307​ CheckBox {
308​ id:checkBoxQuestion
309​ property int questionSet: items.hash[index][0]
310​ property int questionIndex: items.hash[index][1]
311​ checked: false
312​ width: grid.cellWidth * 0.9
313​ height: grid.cellHeight * 0.9
314​ style: CheckBoxStyle {
315​ label: Text {
316​ text: (items.allQuestions.length > 0) ? items.allQuestions[checkBoxQuestion.questionSet][checkBoxQuestion.questionIndex] : ""
317​ wrapMode: Text.WordWrap
318​ anchors.leftMargin: 10
319​ }
320​ indicator: Rectangle {
321​ implicitWidth: grid.cellWidth / 8
322​ implicitHeight: Math.max(grid.cellHeight / 2, 40)
323​ radius: 3
324​ border.color: control.activeFocus ? "darkblue" : "gray"
325​ border.width: 1
326​ Rectangle {
327​ visible: control.checked
328​ color: "#555"
329​ border.color: "#333"
330​ radius: 1
331​ anchors.margins: 4
332​ anchors.fill: parent
333​ }
334​ }
335​ }
336​ onCheckedChanged: {
337​ if(checked) {
338​ Activity.addQuestion(questionSet, questionIndex)
339​ } else {
340​ Activity.removeQuestion(items.allQuestions[questionSet][questionIndex])
341​ }
342​ }
343​ }
344​ }
345​ }
346​ }
347​ }
348​ onClose: {
349​ Activity.getMaxWidth()
350​ home()
351​ }
352​
353​ onLoadData: {
354​ if(dataToSave["currentMode"]) {
355​ items.currentMode = dataToSave["currentMode"]
356​ }
357​ }
358​ onSaveData: {
359​ dataToSave = {"currentMode": items.currentMode}
360​ }
361​
362​ function setDefaultValues() {
363​ items.levelStarted = false
364​ if (items.currentMode === "adminMode") {
365​ items.questions = []
366​ items.answers = []
367​ }
368​ dialogActivityConfig.active = true
369​ displayDialog(dialogActivityConfig)
370​ for(var child in dialogActivityConfig.configItem.grid.contentItem.children) {
371​ if (typeof dialogActivityConfig.configItem.grid.contentItem.children[child].checked !== 'undefined') {
372​ dialogActivityConfig.configItem.grid.contentItem.children[child].checked = false
373​ }
374​ }
375​ }
jjazeixUnsubmitted
Done

you can use of temp variable to store the children, it will be easier to read after

jjazeix: you can use of temp variable to store the children, it will be easier to read after
376​ }
377​
378​ DialogHelp {
379​ id: dialogHelp
380​ onClose: home()
381​ }
382​
383​ Bar {
384​ id: bar
385​ property BarEnumContent activityZoneContent: BarEnumContent { value: home | level | config}
386​ property BarEnumContent menuScreenContent: BarEnumContent { value: help | home }
387​ content: menuScreen.started ? menuScreenContent : activityZoneContent
388​ onHelpClicked: {
389​ displayDialog(dialogHelp)
390​ }
391​ onPreviousLevelClicked: Activity.previousLevel()
392​ onNextLevelClicked: Activity.nextLevel()
393​ onHomeClicked: {
394​ if(items.menuScreen.started)
395​ activity.home()
396​ else {
397​ Activity.launchMenuScreen()
398​ }
399​ }
400​ onConfigClicked: {
401​ dialogActivityConfig.setDefaultValues()
402​ }
403​ }
404​
405​ Bonus {
406​ id: bonus
407​ Component.onCompleted: win.connect(Activity.nextLevel)
408​ }
409​ }
410​
411​}