Changeset View
Changeset View
Standalone View
Standalone View
kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
| Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Line(s) | |||||
| 92 | } | 92 | } | ||
| 93 | 93 | | |||
| 94 | void PreviewBridge::setPlugin(const QString &plugin) | 94 | void PreviewBridge::setPlugin(const QString &plugin) | ||
| 95 | { | 95 | { | ||
| 96 | if (m_plugin == plugin) { | 96 | if (m_plugin == plugin) { | ||
| 97 | return; | 97 | return; | ||
| 98 | } | 98 | } | ||
| 99 | m_plugin = plugin; | 99 | m_plugin = plugin; | ||
| 100 | qDebug() << "Plugin changed to: " << m_plugin; | | |||
| 101 | emit pluginChanged(); | 100 | emit pluginChanged(); | ||
| 102 | } | 101 | } | ||
| 103 | 102 | | |||
| 104 | QString PreviewBridge::theme() const | 103 | QString PreviewBridge::theme() const | ||
| 105 | { | 104 | { | ||
| 106 | return m_theme; | 105 | return m_theme; | ||
| 107 | } | 106 | } | ||
| 108 | 107 | | |||
| Show All 9 Lines | |||||
| 118 | QString PreviewBridge::plugin() const | 117 | QString PreviewBridge::plugin() const | ||
| 119 | { | 118 | { | ||
| 120 | return m_plugin; | 119 | return m_plugin; | ||
| 121 | } | 120 | } | ||
| 122 | 121 | | |||
| 123 | void PreviewBridge::createFactory() | 122 | void PreviewBridge::createFactory() | ||
| 124 | { | 123 | { | ||
| 125 | m_factory.clear(); | 124 | m_factory.clear(); | ||
| 125 | | ||||
| 126 | if (m_plugin.isNull()) { | 126 | if (m_plugin.isNull()) { | ||
| 127 | setValid(false); | 127 | setValid(false); | ||
| 128 | qDebug() <<"Plugin not set"; | 128 | qWarning() << "Plugin not set"; | ||
| 129 | return; | | |||
| 130 | } | | |||
| 131 | const auto offers = KPluginTrader::self()->query(s_pluginName, | | |||
| 132 | s_pluginName, | | |||
| 133 | QStringLiteral("[X-KDE-PluginInfo-Name] == '%1'").arg(m_plugin)); | | |||
| 134 | if (offers.isEmpty()) { | | |||
| 135 | setValid(false); | | |||
| 136 | qDebug() << "no offers"; | | |||
| 137 | return; | 129 | return; | ||
| 138 | } | 130 | } | ||
| 139 | KPluginLoader loader(offers.first().libraryPath()); | 131 | | ||
| 132 | const auto offers = KPluginTrader::self()->query(s_pluginName, s_pluginName); | ||||
| 133 | auto item = std::find_if(offers.cbegin(), offers.cend(), [this](const auto &plugin) { return plugin.pluginName() == m_plugin; }); | ||||
zzag: In KWin, we tend to use constBegin/constEnd. | |||||
zzag: This isn't done, below `cend` is used. | |||||
| 134 | if (item != offers.cend()) { | ||||
| 135 | KPluginLoader loader(item->libraryPath()); | ||||
| 140 | m_factory = loader.factory(); | 136 | m_factory = loader.factory(); | ||
| 141 | qDebug() << "Factory: " << !m_factory.isNull(); | 137 | } | ||
| 138 | | ||||
| 142 | setValid(!m_factory.isNull()); | 139 | setValid(!m_factory.isNull()); | ||
| 143 | } | 140 | } | ||
| 144 | 141 | | |||
| 145 | bool PreviewBridge::isValid() const | 142 | bool PreviewBridge::isValid() const | ||
| 146 | { | 143 | { | ||
| 147 | return m_valid; | 144 | return m_valid; | ||
| 148 | } | 145 | } | ||
| 149 | 146 | | |||
| ▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines | |||||
In KWin, we tend to use constBegin/constEnd.