Changeset View
Changeset View
Standalone View
Standalone View
core/document.h
Show First 20 Lines • Show All 717 Lines • ▼ Show 20 Line(s) | 198 | public: | |||
---|---|---|---|---|---|
718 | * Returns the last print error in case print() failed | 718 | * Returns the last print error in case print() failed | ||
719 | * @since 0.11 (KDE 4.5) | 719 | * @since 0.11 (KDE 4.5) | ||
720 | */ | 720 | */ | ||
721 | QString printError() const; | 721 | QString printError() const; | ||
722 | 722 | | |||
723 | /** | 723 | /** | ||
724 | * Returns a custom printer configuration page or 0 if no | 724 | * Returns a custom printer configuration page or 0 if no | ||
725 | * custom printer configuration page is available. | 725 | * custom printer configuration page is available. | ||
726 | * | ||||
727 | * The returned object should be of a PrintOptionsWidget subclass | ||||
728 | * (which is not officially enforced by the signature for binary | ||||
729 | * compatibility reasons). | ||||
726 | */ | 730 | */ | ||
727 | QWidget* printConfigurationWidget() const; | 731 | QWidget* printConfigurationWidget() const; | ||
aacid: this is binary incompatible :/
We could just let it be a QWidget but document it has to be a… | |||||
I have changed the return type to a QWidget* again, but only for the Document class itself, not in the other places. As far as I understand, this place here is the only one relevant for the ABI. Is this correct? Currently, there is no complaint if a plain QWidget* is returned, it's just handled as it used to be then. Should I change that (e.g. emit a 'qWarning()')? michaelweghorn: I have changed the return type to a QWidget* again, but only for the Document class itself, not… | |||||
interfaces/ is also installed when doing make install so compatibility there is also important. Since you have a dynamic cast in part.cpp i guess it makes sense to have a warning when the dynamic cast fails? Telling the "developer" that he should update her implementation of the method? aacid: interfaces/ is also installed when doing make install so compatibility there is also important. | |||||
728 | 732 | | |||
729 | /** | 733 | /** | ||
730 | * Fill the KConfigDialog @p dialog with the setting pages of the | 734 | * Fill the KConfigDialog @p dialog with the setting pages of the | ||
731 | * generators. | 735 | * generators. | ||
732 | */ | 736 | */ | ||
733 | void fillConfigDialog( KConfigDialog * dialog ); | 737 | void fillConfigDialog( KConfigDialog * dialog ); | ||
734 | 738 | | |||
735 | /** | 739 | /** | ||
▲ Show 20 Lines • Show All 717 Lines • Show Last 20 Lines |
this is binary incompatible :/
We could just let it be a QWidget but document it has to be a PrintOptionsWidge subclass, and then on the user do a dynamic_cast and complain if it is not a PrintOptionsWidget, but maybe we can just say meh and break the BC.