Differential D18294 Diff 49692 src/backend/worksheet/plots/cartesian/XYCurve.h

Changeset View

Standalone View

View Options

src/backend/worksheet/plots/cartesian/XYCurve.h

Context not available.
66 bool load(XmlStreamReader*, bool preview) override; 66​ bool load(XmlStreamReader*, bool preview) override;
67 void loadThemeConfig(const KConfig&) override; 67​ void loadThemeConfig(const KConfig&) override;
68 void saveThemeConfig(const KConfig&) override; 68​ void saveThemeConfig(const KConfig&) override;
69​ static int calculateMaxSteps(unsigned int value);
70​ double y(double x, bool &valueFound) const;
71​ int indexForX(double x) const;
72​ int indexForX(double x, QVector<double>& column, AbstractColumn::Properties properties = AbstractColumn::Properties::No) const;
asemkeUnsubmitted
Done

indexForX oder indexForXinColumn? Let's maybe name all these functions simply indexForX and diferentiation is done by the parameters and the documentation of these overloaded parameters. This would be similar for example to the all those map*() functions in CartesianCoordinateSystem.

asemke: indexForX oder indexForXinColumn? Let's maybe name all these functions simply indexForX and…
73​ int indexForX(double x, QVector<QPointF>& column, AbstractColumn::Properties properties = AbstractColumn::Properties::No) const;
74​ int indexForX(double x, QVector<QLineF>& lines, AbstractColumn::Properties properties = AbstractColumn::Properties::No) const;
69 75​
70 POINTER_D_ACCESSOR_DECL(const AbstractColumn, xColumn, XColumn) 76​ POINTER_D_ACCESSOR_DECL(const AbstractColumn, xColumn, XColumn)
71 POINTER_D_ACCESSOR_DECL(const AbstractColumn, yColumn, YColumn) 77​ POINTER_D_ACCESSOR_DECL(const AbstractColumn, yColumn, YColumn)
Context not available.