Changeset View
Changeset View
Standalone View
Standalone View
abstract_client.h
Show First 20 Lines • Show All 747 Lines • ▼ Show 20 Line(s) | 294 | public: | |||
---|---|---|---|---|---|
748 | void showApplicationMenu(int actionId); | 748 | void showApplicationMenu(int actionId); | ||
749 | 749 | | |||
750 | bool unresponsive() const; | 750 | bool unresponsive() const; | ||
751 | 751 | | |||
752 | virtual bool isInitialPositionSet() const { | 752 | virtual bool isInitialPositionSet() const { | ||
753 | return false; | 753 | return false; | ||
754 | } | 754 | } | ||
755 | 755 | | |||
756 | /** | ||||
757 | * Default implementation returns @c null. | ||||
758 | * Mostly intended for X11 clients, from EWMH: | ||||
zzag: If it's X11 specific, doesn't it make sense to keep groupTransient in Client? | |||||
The reason I moved it is that we need to cast in Workspace and similar places. The casts are a problem. Every cast is a potential "forgot to port". I recently stumbled over a few and thought: let's try to get rid of all. We have more such API in AbstractClient: e.g. shade is only in X11. graesslin: The reason I moved it is that we need to cast in Workspace and similar places. The casts are a… | |||||
759 | * <quote> | ||||
760 | * If the WM_TRANSIENT_FOR property is set to None or Root window, the window should be | ||||
761 | * treated as a transient for all other windows in the same group. It has been noted that this | ||||
762 | * is a slight ICCCM violation, but as this behavior is pretty standard for many toolkits and | ||||
763 | * window managers, and is extremely unlikely to break anything, it seems reasonable to document | ||||
764 | * it as standard. | ||||
765 | * </quote> | ||||
766 | **/ | ||||
767 | virtual bool groupTransient() const; | ||||
768 | /** | ||||
769 | * Default implementation returns @c null. | ||||
770 | * | ||||
771 | * Mostly for X11 clients, holds the client group | ||||
772 | **/ | ||||
773 | virtual const Group *group() const; | ||||
zzag: Please fix coding style. | |||||
Stupid question: what's wrong? I just copied the method definitions from client.h and added a virtual... graesslin: Stupid question: what's wrong? I just copied the method definitions from client.h and added a… | |||||
I think there should be a whitespace before *, e.g. virtual const Group *group() const; zzag: I think there should be a whitespace before *, e.g.
```lang=cpp
virtual const Group *group()… | |||||
774 | /** | ||||
775 | * Default implementation returns @c null. | ||||
776 | * | ||||
777 | * Mostly for X11 clients, holds the client group | ||||
778 | **/ | ||||
779 | virtual Group *group(); | ||||
780 | | ||||
756 | public Q_SLOTS: | 781 | public Q_SLOTS: | ||
757 | virtual void closeWindow() = 0; | 782 | virtual void closeWindow() = 0; | ||
758 | 783 | | |||
759 | Q_SIGNALS: | 784 | Q_SIGNALS: | ||
760 | void fullScreenChanged(); | 785 | void fullScreenChanged(); | ||
761 | void skipTaskbarChanged(); | 786 | void skipTaskbarChanged(); | ||
762 | void skipPagerChanged(); | 787 | void skipPagerChanged(); | ||
763 | void skipSwitcherChanged(); | 788 | void skipSwitcherChanged(); | ||
▲ Show 20 Lines • Show All 500 Lines • Show Last 20 Lines |
If it's X11 specific, doesn't it make sense to keep groupTransient in Client?