Differential D17834 Diff 48701 vpn/fortisslvpn/fortisslvpnauth.cpp

Changeset View

Standalone View

View Options

vpn/fortisslvpn/fortisslvpnauth.cpp

Context not available.
40 d->ui.setupUi(this); 40​ d->ui.setupUi(this);
41 d->setting = setting; 41​ d->setting = setting;
42 42​
43​ const NetworkManager::Setting::SecretFlags otpFlag = static_cast<NetworkManager::Setting::SecretFlags>(data.value(NM_FORTISSLVPN_KEY_OTP"-flags").toInt());
44​ if (otpFlag == NetworkManager::Setting::NotSaved){
jgrulichUnsubmitted
Not Done

I think you should check for NetworkManager::Setting::NotSaved only, if it's this case, make it visible, if not, make it hidden. It's a one-time password so it won't be saved.

jgrulich: I think you should check for NetworkManager::Setting::NotSaved only, if it's this case, make it…
jgrulichUnsubmitted
Not Done

Missing space before "{".

jgrulich: Missing space before "{".
45​ d->ui.otpFrame->setVisible(true);
46​ } else {
jgrulichUnsubmitted
Not Done

Coding style.

jgrulich: Coding style.
47​ d->ui.otpFrame->setVisible(false);
jgrulichUnsubmitted
Not Done

You can make this shorter:
d->ui.otpFrame->setVisible(otpFlag == NetworkManager::Setting::NotSaved)

jgrulich: You can make this shorter: d->ui.otpFrame->setVisible(otpFlag == NetworkManager::Setting…
48​ }
49​
43 KAcceleratorManager::manage(this); 50​ KAcceleratorManager::manage(this);
44} 51​}
45 52​
Context not available.
58 if (!d->ui.password->text().isEmpty()) { 65​ if (!d->ui.password->text().isEmpty()) {
59 secrets.insert(QLatin1String(NM_FORTISSLVPN_KEY_PASSWORD), d->ui.password->text()); 66​ secrets.insert(QLatin1String(NM_FORTISSLVPN_KEY_PASSWORD), d->ui.password->text());
60 } 67​ }
68​
69​ if (!data.value(NM_FORTISSLVPN_KEY_OTP"-flags").isEmpty()){
jgrulichUnsubmitted
Not Done

Missing space before "{".

jgrulich: Missing space before "{".
70​ const NetworkManager::Setting::SecretFlags otpFlag = static_cast<NetworkManager::Setting::SecretFlags>(data.value(NM_FORTISSLVPN_KEY_OTP"-flags").toInt());
71​ if (otpFlag == NetworkManager::Setting::NotSaved && !d->ui.otp->text().isEmpty()){
jgrulichUnsubmitted
Not Done

Missing space before "{".

jgrulich: Missing space before "{".
72​ secrets.insert(QLatin1String(NM_FORTISSLVPN_KEY_OTP),d->ui.otp->text());
jgrulichUnsubmitted
Not Done

Missing space after second parameter.

jgrulich: Missing space after second parameter.
73​ }
74​ }
61 75​
62 secretData.insert("secrets", QVariant::fromValue<NMStringMap>(secrets)); 76​ secretData.insert("secrets", QVariant::fromValue<NMStringMap>(secrets));
63 return secretData; 77​ return secretData;
Context not available.