Changeset View
Changeset View
Standalone View
Standalone View
workspace.h
Show First 20 Lines • Show All 272 Lines • ▼ Show 20 Line(s) | 254 | public: | |||
---|---|---|---|---|---|
273 | AbstractClient* topClientOnDesktop(int desktop, int screen, bool unconstrained = false, | 273 | AbstractClient* topClientOnDesktop(int desktop, int screen, bool unconstrained = false, | ||
274 | bool only_normal = true) const; | 274 | bool only_normal = true) const; | ||
275 | AbstractClient* findDesktop(bool topmost, int desktop) const; | 275 | AbstractClient* findDesktop(bool topmost, int desktop) const; | ||
276 | void sendClientToDesktop(AbstractClient* c, int desktop, bool dont_activate); | 276 | void sendClientToDesktop(AbstractClient* c, int desktop, bool dont_activate); | ||
277 | void windowToPreviousDesktop(AbstractClient* c); | 277 | void windowToPreviousDesktop(AbstractClient* c); | ||
278 | void windowToNextDesktop(AbstractClient* c); | 278 | void windowToNextDesktop(AbstractClient* c); | ||
279 | void sendClientToScreen(AbstractClient* c, int screen); | 279 | void sendClientToScreen(AbstractClient* c, int screen); | ||
280 | 280 | | |||
281 | void addManualOverlay(xcb_window_t id) { | ||||
zzag: Could we maybe rename it to a more intuitive name, e.g. addDragProxyWindow? or something like… | |||||
The functionality is not specific to drag windows and could be used in other ways as well. romangg: The functionality is not specific to drag windows and could be used in other ways as well. | |||||
282 | manual_overlays << id; | ||||
283 | } | ||||
284 | void removeManualOverlay(xcb_window_t id) { | ||||
"rm" is quite unusual. We use "remove" more often, e.g. removeClient, removeDeleted, etc. zzag: "rm" is quite unusual. We use "remove" more often, e.g. removeClient, removeDeleted, etc. | |||||
True. Unnecessary shortening. Will rename to removeManualOverlay on commit. romangg: True. Unnecessary shortening. Will rename to `removeManualOverlay` on commit. | |||||
285 | manual_overlays.removeOne(id); | ||||
286 | } | ||||
287 | | ||||
281 | /** | 288 | /** | ||
282 | * Shows the menu operations menu for the client and makes it active if | 289 | * Shows the menu operations menu for the client and makes it active if | ||
283 | * it's not already. | 290 | * it's not already. | ||
284 | */ | 291 | */ | ||
285 | void showWindowMenu(const QRect& pos, AbstractClient* cl); | 292 | void showWindowMenu(const QRect& pos, AbstractClient* cl); | ||
286 | const UserActionsMenu *userActionsMenu() const { | 293 | const UserActionsMenu *userActionsMenu() const { | ||
287 | return m_userActionsMenu; | 294 | return m_userActionsMenu; | ||
288 | } | 295 | } | ||
▲ Show 20 Lines • Show All 270 Lines • ▼ Show 20 Line(s) | 502 | private: | |||
559 | ClientList clients; | 566 | ClientList clients; | ||
560 | QList<AbstractClient*> m_allClients; | 567 | QList<AbstractClient*> m_allClients; | ||
561 | ClientList desktops; | 568 | ClientList desktops; | ||
562 | UnmanagedList unmanaged; | 569 | UnmanagedList unmanaged; | ||
563 | DeletedList deleted; | 570 | DeletedList deleted; | ||
564 | 571 | | |||
565 | ToplevelList unconstrained_stacking_order; // Topmost last | 572 | ToplevelList unconstrained_stacking_order; // Topmost last | ||
566 | ToplevelList stacking_order; // Topmost last | 573 | ToplevelList stacking_order; // Topmost last | ||
574 | QVector<xcb_window_t> manual_overlays; //Topmost last | ||||
567 | bool force_restacking; | 575 | bool force_restacking; | ||
568 | ToplevelList x_stacking; // From XQueryTree() | 576 | ToplevelList x_stacking; // From XQueryTree() | ||
569 | std::unique_ptr<Xcb::Tree> m_xStackingQueryTree; | 577 | std::unique_ptr<Xcb::Tree> m_xStackingQueryTree; | ||
570 | bool m_xStackingDirty = false; | 578 | bool m_xStackingDirty = false; | ||
571 | QList<AbstractClient*> should_get_focus; // Last is most recent | 579 | QList<AbstractClient*> should_get_focus; // Last is most recent | ||
572 | QList<AbstractClient*> attention_chain; | 580 | QList<AbstractClient*> attention_chain; | ||
573 | 581 | | |||
574 | bool showing_desktop; | 582 | bool showing_desktop; | ||
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines |
Could we maybe rename it to a more intuitive name, e.g. addDragProxyWindow? or something like that.