Differential D17834 Diff 48397 vpn/fortisslvpn/fortisslvpnwidget.cpp

Changeset View

Standalone View

View Options

vpn/fortisslvpn/fortisslvpnwidget.cpp

Context not available.
128 d->advUi.trustedCert->setText(trustedCert); 128​ d->advUi.trustedCert->setText(trustedCert);
129 } 129​ }
130 130​
131​ const QString otp = data.value(NM_FORTISSLVPN_KEY_OTP"-flags");
jgrulichUnsubmitted
Not Done

Missing space before "{".

jgrulich: Missing space before "{".
132​ if (!otp.isEmpty() && otp == "2"){
133​ d->advUi.otp->setChecked(true);
jgrulichUnsubmitted
Not Done

Missing space before "{".

jgrulich: Missing space before "{".
134​ }
135​ else {
136​ d->advUi.otp->setChecked(false);
137​ }
131 loadSecrets(setting); 138​ loadSecrets(setting);
132} 139​}
133 140​
Context not available.
190 if (!d->advUi.trustedCert->text().isEmpty()) { 197​ if (!d->advUi.trustedCert->text().isEmpty()) {
191 data.insert(NM_FORTISSLVPN_KEY_TRUSTED_CERT, d->advUi.trustedCert->text()); 198​ data.insert(NM_FORTISSLVPN_KEY_TRUSTED_CERT, d->advUi.trustedCert->text());
192 } 199​ }
200​
201​ data.insert(QLatin1String(NM_FORTISSLVPN_KEY_OTP"-flags"), d->advUi.otp->isChecked() ? "2" : "0");
jgrulichUnsubmitted
Not Done

Missing space before "{".

jgrulich: Missing space before "{".
jgrulichUnsubmitted
Not Done

I don't understand why you hare check for prevData.value(), but later on you get optFlag from data (not prevData). Still I don't think this is needed at all. I would go back and use your previous approach, because the result will be the same.

jgrulich: I don't understand why you hare check for prevData.value(), but later on you get optFlag from…
enriquemAuthorUnsubmitted
Not Done

You are probably right. Networkmanager-fortisslvpn is probably drawing code form other VPN plugins where there can be more flags set. Here, as you say, the only relevant flag is NotSaved.

enriquem: You are probably right. Networkmanager-fortisslvpn is probably drawing code form other VPN…
193 202​
194 setting.setData(data); 203​ setting.setData(data);
jgrulichUnsubmitted
Not Done

Coding style.

jgrulich: Coding style.
195 setting.setSecrets(secrets); 204​ setting.setSecrets(secrets);
Context not available.
jgrulichUnsubmitted
Not Done

Shouldn't it be NetworkManager::Setting::NotRequired? Using NetworkManager::Setting::None says the one-time password should be saved to NetworkManager.

jgrulich: Shouldn't it be NetworkManager::Setting::NotRequired? Using NetworkManager::Setting::None says…
enriquemAuthorUnsubmitted
Not Done

I don't think so; I created a new VPN setting wit nm-connection-editor, and it sets it to 0, that is, to NetworkManager::Setting::None

enriquem: I don't think so; I created a new VPN setting wit nm-connection-editor, and it sets it to 0…