Differential D17834 Diff 48397 vpn/fortisslvpn/fortisslvpnauth.cpp

Changeset View

Standalone View

vpn/fortisslvpn/fortisslvpnauth.cpp

Context not available.
40	d->ui.setupUi(this);	40		d->ui.setupUi(this);
41	d->setting = setting;	41		d->setting = setting;
42		42
		43		const QString otp = d->setting->data().value(NM_FORTISSLVPN_KEY_OTP"-flags");
		44		if (!otp.isEmpty() && otp == "2"){
			jgrulichUnsubmitted Not Done I think you should check for NetworkManager::Setting::NotSaved only, if it's this case, make it visible, if not, make it hidden. It's a one-time password so it won't be saved. jgrulich: I think you should check for NetworkManager::Setting::NotSaved only, if it's this case, make it…
			jgrulichUnsubmitted Not Done Missing space before "{". jgrulich: Missing space before "{".
		45		d->ui.otpFrame->setVisible(true);
		46		}
			jgrulichUnsubmitted Not Done Coding style. jgrulich: Coding style.
		47		else {
			jgrulichUnsubmitted Not Done You can make this shorter: d->ui.otpFrame->setVisible(otpFlag == NetworkManager::Setting::NotSaved) jgrulich: You can make this shorter: d->ui.otpFrame->setVisible(otpFlag == NetworkManager::Setting…
		48		d->ui.otpFrame->setVisible(false);
		49		}
		50
43	KAcceleratorManager::manage(this);	51		KAcceleratorManager::manage(this);
44	}	52		}
45		53
Context not available.
58	if (!d->ui.password->text().isEmpty()) {	66		if (!d->ui.password->text().isEmpty()) {
59	secrets.insert(QLatin1String(NM_FORTISSLVPN_KEY_PASSWORD), d->ui.password->text());	67		secrets.insert(QLatin1String(NM_FORTISSLVPN_KEY_PASSWORD), d->ui.password->text());
60	}	68		}
		69
		70		const QString otp = d->setting->data().value(NM_FORTISSLVPN_KEY_OTP"-flags");
			jgrulichUnsubmitted Not Done Missing space before "{". jgrulich: Missing space before "{".
		71		if (!otp.isEmpty() && otp == "2" && !d->ui.otp->text().isEmpty() ){
		72		secrets.insert(QLatin1String(NM_FORTISSLVPN_KEY_OTP),d->ui.otp->text());
			jgrulichUnsubmitted Not Done Missing space before "{". jgrulich: Missing space before "{".
		73		}
			jgrulichUnsubmitted Not Done Missing space after second parameter. jgrulich: Missing space after second parameter.
61		74
62	secretData.insert("secrets", QVariant::fromValue<NMStringMap>(secrets));	75		secretData.insert("secrets", QVariant::fromValue<NMStringMap>(secrets));
63	return secretData;	76		return secretData;
Context not available.