Differential D1554 Diff 3771 documentation/qthelp/qthelpconfig.cpp

Changeset View

Standalone View

View Options

documentation/qthelp/qthelpconfig.cpp

Show First 20 Lines • Show All 371 Lines • ▼ Show 20 Line(s)
372 372​
373void QtHelpConfig::searchDirChanged() 373​void QtHelpConfig::searchDirChanged()
374{ 374​{
375 emit changed(); 375​ emit changed();
376} 376​}
377 377​
378QString QtHelpConfig::name() const 378​QString QtHelpConfig::name() const
379{ 379​{
380 return i18n("QtHelp Documentation"); 380​ return i18n("API Documentation");
apolUnsubmitted
Not Done

Why the change? This doesn't specify what kind of documentation. One could have documentation on other formats. e.g. PHP docs

apol: Why the change? This doesn't specify what kind of documentation. One could have documentation…
cordlandwehrAuthorUnsubmitted
Not Done

My intention was to make clear that this is a configuration page for the API documentations one can install for different frameworks/languages. "QtHelp Documentation" is correct from the implementation details, yet a user won't care if it is in QCH files or different containers. Furthermore, I did not use "Documentation" since that easily can be confused with documentation about KDevelop.
Actually, IMO PHP Docs is API documentation and fits will under this caption.
Which caption would you prefer?

cordlandwehr: My intention was to make clear that this is a configuration page for the API documentations one…
apolUnsubmitted
Not Done

Maybe "Qt API Documentation"?

apol: Maybe "Qt API Documentation"?
381} 381​}
382 382​
383QIcon QtHelpConfig::icon() const 383​QIcon QtHelpConfig::icon() const
384{ 384​{
385 return QIcon::fromTheme(QStringLiteral("qtlogo")); 385​ return QIcon::fromTheme(QStringLiteral("help-contents"));
386} 386​}