Differential D17790 Diff 48169 tests/testsslsocketlinereader.cpp

Changeset View

Standalone View

tests/testsslsocketlinereader.cpp

Context not available.
22	#include "../core/backends/lan/socketlinereader.h"	22		#include "../core/backends/lan/socketlinereader.h"
23		23
24	#include <QSslKey>	24		#include <QSslKey>
25	#include <QtCrypto>
26	#include <QTest>	25		#include <QTest>
27	#include <QTimer>	26		#include <QTimer>
		27		#include <QTemporaryFile>
		28		#include <QProcess>
28		29
29	/*	30		/*
30	* This class tests the behaviour of socket line reader when the connection if over ssl. Since SSL takes part below application layer,	31		* This class tests the behaviour of socket line reader when the connection if over ssl. Since SSL takes part below application layer,
Context not available.
51	private:	52		private:
52	const int PORT = 7894;	53		const int PORT = 7894;
53	QTimer m_timer;	54		QTimer m_timer;
54	QCA::Initializer m_qcaInitializer;
55	QEventLoop m_loop;	55		QEventLoop m_loop;
56	QList<QByteArray> m_packets;	56		QList<QByteArray> m_packets;
57	Server* m_server;	57		Server* m_server;
Context not available.
112	QVERIFY2(serverSocket != 0, "Null socket returned by server");	112		QVERIFY2(serverSocket != 0, "Null socket returned by server");
113	QVERIFY2(serverSocket->isOpen(), "Server socket already closed");	113		QVERIFY2(serverSocket->isOpen(), "Server socket already closed");
114		114
115	setSocketAttributes(serverSocket, QStringLiteral("Test Server"));	115		setSocketAttributes(serverSocket, QStringLiteral("foo"));
116	setSocketAttributes(m_clientSocket, QStringLiteral("Test Client"));	116		setSocketAttributes(m_clientSocket, QStringLiteral("foo"));
117		117
118	serverSocket->setPeerVerifyName(QStringLiteral("Test Client"));	118		serverSocket->setPeerVerifyName(QStringLiteral("Test Client"));
119	serverSocket->setPeerVerifyMode(QSslSocket::VerifyPeer);	119		serverSocket->setPeerVerifyMode(QSslSocket::VerifyPeer);
Context not available.
174	QVERIFY2(serverSocket != 0, "Null socket returned by server");	174		QVERIFY2(serverSocket != 0, "Null socket returned by server");
175	QVERIFY2(serverSocket->isOpen(), "Server socket already closed");	175		QVERIFY2(serverSocket->isOpen(), "Server socket already closed");
176		176
177	setSocketAttributes(serverSocket, QStringLiteral("Test Server"));	177		setSocketAttributes(serverSocket, QStringLiteral("foo"));
			nicolasfellaAuthorUnsubmitted Not Done ???? nicolasfella: ????
178	setSocketAttributes(m_clientSocket, QStringLiteral("Test Client"));	178		setSocketAttributes(m_clientSocket, QStringLiteral("foo"));
179		179
180	serverSocket->setPeerVerifyName(QStringLiteral("Test Client"));	180		serverSocket->setPeerVerifyName(QStringLiteral("Test Client"));
181	serverSocket->setPeerVerifyMode(QSslSocket::QueryPeer);	181		serverSocket->setPeerVerifyMode(QSslSocket::QueryPeer);
Context not available.
231		231
232	QVERIFY2(serverSocket != 0, "Could not open a connection to the client");	232		QVERIFY2(serverSocket != 0, "Could not open a connection to the client");
233		233
234	setSocketAttributes(serverSocket, QStringLiteral("Test Server"));	234		setSocketAttributes(serverSocket, QStringLiteral("foo"));
235	setSocketAttributes(m_clientSocket, QStringLiteral("Test Client"));	235		setSocketAttributes(m_clientSocket, QStringLiteral("foo"));
236		236
237	// Not adding other device certificate to list of CA certificate, and using VerifyPeer. This should lead to handshake failure	237		// Not adding other device certificate to list of CA certificate, and using VerifyPeer. This should lead to handshake failure
238	serverSocket->setPeerVerifyName(QStringLiteral("Test Client"));	238		serverSocket->setPeerVerifyName(QStringLiteral("Test Client"));
Context not available.
283		283
284	void TestSslSocketLineReader::setSocketAttributes(QSslSocket* socket, QString deviceName) {	284		void TestSslSocketLineReader::setSocketAttributes(QSslSocket* socket, QString deviceName) {
285		285
286	QDateTime startTime = QDateTime::currentDateTime();	286		QTemporaryFile cert;
287	QDateTime endTime = startTime.addYears(10);	287		cert.open();
			pinoUnsubmitted Not Done this can fail, needs error handling pino: this can fail, needs error handling
288	QCA::CertificateInfo certificateInfo;	288		QTemporaryFile priv;
289	certificateInfo.insert(QCA::CommonName,deviceName);	289		priv.open();
			pinoUnsubmitted Not Done this can fail, needs error handling pino: this can fail, needs error handling
290	certificateInfo.insert(QCA::Organization,QStringLiteral("KDE"));
291	certificateInfo.insert(QCA::OrganizationalUnit,QStringLiteral("Kde connect"));
292		290
293	QCA::CertificateOptions certificateOptions(QCA::PKCS10);	291		QProcess::execute("openssl", QStringLiteral("req -new -x509 -sha256 -newkey rsa:2048 -nodes -keyout %1 -days 3650 -out %2 -subj /O=KDE/OU=KDEConnect/CN=%3").arg(priv.fileName(), cert.fileName(), deviceName).split(" "));
			pinoUnsubmitted Not Done missing handling of the return value of the command (what if fails?) please do not split the arguments from a single string, but directly build a string list with the arguments (in case the paths contain spaces, for example) pino: - missing handling of the return value of the command (what if fails?) - please do not split…
			nicolasfellaAuthorUnsubmitted Not Done break into a couple of lines. nicolasfella: break into a couple of lines.
294	certificateOptions.setSerialNumber(10);
295	certificateOptions.setInfo(certificateInfo);
296	certificateOptions.setValidityPeriod(startTime, endTime);
297	certificateOptions.setFormat(QCA::PKCS10);
298		292
299	QCA::PrivateKey privKey = QCA::KeyGenerator().createRSA(2048);	293		QSslCertificate certificate = QSslCertificate::fromPath(cert.fileName()).at(0);
			pinoUnsubmitted Not Done if QSslCertificate::fromPath fails, the return is an empty list, and this will misbehave pino: if QSslCertificate::fromPath fails, the return is an empty list, and this will misbehave
300	QSslCertificate certificate = QSslCertificate(QCA::Certificate(certificateOptions, privKey).toPEM().toLatin1());
301		294
302	socket->setPrivateKey(QSslKey(privKey.toPEM().toLatin1(), QSsl::Rsa));	295		socket->setPrivateKey(priv.fileName());
303	socket->setLocalCertificate(certificate);	296		socket->setLocalCertificate(certificate);
304		297
305	}	298		}
Context not available.