Differential D17790 Diff 48169 tests/lanlinkprovidertest.cpp

Changeset View

Standalone View

View Options

tests/lanlinkprovidertest.cpp

Context not available.
69 // Attributes for test device 69​ // Attributes for test device
70 QString m_deviceId; 70​ QString m_deviceId;
71 QString m_name; 71​ QString m_name;
72 QCA::PrivateKey m_privateKey; ​
73 QSslCertificate m_certificate; 72​ QSslCertificate m_certificate;
73​ QTemporaryFile m_privateKeyFile;
74 74​
75 QSslCertificate generateCertificate(QString&, QCA::PrivateKey&); 75​ QSslCertificate generateCertificate(QString&);
76 void addTrustedDevice(); 76​ void addTrustedDevice();
77 void removeTrustedDevice(); 77​ void removeTrustedDevice();
78 void setSocketAttributes(QSslSocket* socket); 78​ void setSocketAttributes(QSslSocket* socket);
Context not available.
86 86​
87 m_deviceId = QStringLiteral("testdevice"); 87​ m_deviceId = QStringLiteral("testdevice");
88 m_name = QStringLiteral("Test Device"); 88​ m_name = QStringLiteral("Test Device");
89 m_privateKey = QCA::KeyGenerator().createRSA(2048); 89​ m_certificate = generateCertificate(m_deviceId);
90 m_certificate = generateCertificate(m_deviceId, m_privateKey); ​
91 90​
92 m_lanLinkProvider.onStart(); 91​ m_lanLinkProvider.onStart();
93 92​
Context not available.
312 QVERIFY2(body.contains("deviceType"), "Device type not found in identity packet"); 311​ QVERIFY2(body.contains("deviceType"), "Device type not found in identity packet");
313} 312​}
314 313​
315QSslCertificate LanLinkProviderTest::generateCertificate(QString& commonName, QCA::PrivateKey& privateKey) 314​QSslCertificate LanLinkProviderTest::generateCertificate(QString& commonName)
316{ 315​{
317 QDateTime startTime = QDateTime::currentDateTime(); 316​ QTemporaryFile cert;
318 QDateTime endTime = startTime.addYears(10); 317​ cert.open();
pinoUnsubmitted
Not Done

this can fail, needs error handling

pino: this can fail, needs error handling
319 QCA::CertificateInfo certificateInfo; 318​ m_privateKeyFile.open();
pinoUnsubmitted
Not Done

this can fail, needs error handling

pino: this can fail, needs error handling
320 certificateInfo.insert(QCA::CommonName,commonName); 319​
321 certificateInfo.insert(QCA::Organization,QStringLiteral("KDE")); 320​ QProcess::execute("openssl", QStringLiteral("req -new -x509 -sha256 -newkey rsa:2048 -nodes -keyout %1 -days 3650 -out %2 -subj /O=KDE/OU=KDEConnect/CN=%3").arg(m_privateKeyFile.fileName(), cert.fileName(), commonName).split(" "));
pinoUnsubmitted
Not Done
  • missing handling of the return value of the command (what if fails?)
  • please do not split the arguments from a single string, but directly build a string list with the arguments (in case the paths contain spaces, for example)
pino: - missing handling of the return value of the command (what if fails?) - please do not split…
322 certificateInfo.insert(QCA::OrganizationalUnit,QStringLiteral("Kde connect")); 321​
323 322​ QSslCertificate certificate = QSslCertificate::fromPath(cert.fileName()).at(0);
pinoUnsubmitted
Not Done

if QSslCertificate::fromPath fails, the return is an empty list, and this will misbehave

pino: if QSslCertificate::fromPath fails, the return is an empty list, and this will misbehave
324 QCA::CertificateOptions certificateOptions(QCA::PKCS10); ​
325 certificateOptions.setSerialNumber(10); ​
326 certificateOptions.setInfo(certificateInfo); ​
327 certificateOptions.setValidityPeriod(startTime, endTime); ​
328 certificateOptions.setFormat(QCA::PKCS10); ​
329 ​
330 QSslCertificate certificate = QSslCertificate(QCA::Certificate(certificateOptions, privateKey).toPEM().toLatin1()); ​
331 return certificate; 323​ return certificate;
332} 324​}
333 325​
334void LanLinkProviderTest::setSocketAttributes(QSslSocket* socket) 326​void LanLinkProviderTest::setSocketAttributes(QSslSocket* socket)
335{ 327​{
336 socket->setPrivateKey(QSslKey(m_privateKey.toPEM().toLatin1(), QSsl::Rsa)); 328​ socket->setPrivateKey(m_privateKeyFile.fileName());
337 socket->setLocalCertificate(m_certificate); 329​ socket->setLocalCertificate(m_certificate);
338} 330​}
339 331​
Context not available.