Differential D17547 Diff 47613 cmake/modules/FindFontconfig.cmake

Changeset View

Standalone View

View Options

cmake/modules/FindFontconfig.cmake

1# - Try to find the Fontconfig 1​#.rst:
2# Once done this will define 2​# FindFontconfig
3​# --------------
3# 4​#
4# FONTCONFIG_FOUND - system has Fontconfig 5​# Try to find Fontconfig.
5# FONTCONFIG_INCLUDE_DIR - The include directory to use for the fontconfig headers 6​# Once done this will define the following variables:
6# FONTCONFIG_LIBRARIES - Link these to use FONTCONFIG 7​#
7# FONTCONFIG_DEFINITIONS - Compiler switches required for using FONTCONFIG 8​# ``Fontconfig_FOUND``
9​# True if Fontconfig is available
10​# ``Fontconfig_INCLUDE_DIRS``
kropUnsubmitted
Not Done

shall be FONTCONFIG_INCLUDE_DIRS

(https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names)

This link also suggests the variable names shall be exact-case FONTCONFIG_ → Fontconfig_

krop: shall be FONTCONFIG_INCLUDE_DIRS (https://cmake.org/cmake/help/latest/manual/cmake-developer.7.
11​# The include directory to use for the Fontconfig headers
12​# ``Fontconfig_LIBRARIES``
13​# The Fontconfig libraries for linking
14​# ``Fontconfig_DEFINITIONS``
15​# Compiler switches required for using Fontconfig
16​# ``Fontconfig_VERSION``
17​# The version of Fontconfig that has been found
18​#
19​# If ``Fontconfig_FOUND`` is True, it will also define the following
20​# imported target:
21​#
22​# ``Fontconfig::Fontconfig``
8 23​
24​#=============================================================================
9# Copyright (c) 2006,2007 Laurent Montel, <montel@kde.org> 25​# Copyright (c) 2006,2007 Laurent Montel, <montel@kde.org>
26​# Copyright (c) 2018 Volker Krause <vkrause@kde.org>
10# 27​#
11# Redistribution and use is allowed according to the terms of the BSD license. 28​# Redistribution and use in source and binary forms, with or without
12# For details see the accompanying COPYING-CMAKE-SCRIPTS file. 29​# modification, are permitted provided that the following conditions
13 30​# are met:
14 31​#
15if (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR) 32​# 1. Redistributions of source code must retain the copyright
16 33​# notice, this list of conditions and the following disclaimer.
17 # in cache already 34​# 2. Redistributions in binary form must reproduce the copyright
18 set(FONTCONFIG_FOUND TRUE) 35​# notice, this list of conditions and the following disclaimer in the
19 36​# documentation and/or other materials provided with the distribution.
20else (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR) 37​# 3. The name of the author may not be used to endorse or promote products
38​# derived from this software without specific prior written permission.
39​#
40​# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
41​# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
42​# OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
43​# IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
44​# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
45​# NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
46​# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
47​# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
48​# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
49​# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
50​#=============================================================================
21 51​
22 if (NOT WIN32) ​
23 # use pkg-config to get the directories and then use these values 52​# use pkg-config to get the directories and then use these values
24 # in the FIND_PATH() and FIND_LIBRARY() calls 53​# in the FIND_PATH() and FIND_LIBRARY() calls
25 find_package(PkgConfig) 54​find_package(PkgConfig)
26 pkg_check_modules(PC_FONTCONFIG QUIET fontconfig) 55​pkg_check_modules(PC_FONTCONFIG QUIET fontconfig)
27 56​
28 set(FONTCONFIG_DEFINITIONS ${PC_FONTCONFIG_CFLAGS_OTHER}) 57​set(Fontconfig_DEFINITIONS ${PC_FONTCONFIG_CFLAGS_OTHER})
29 endif (NOT WIN32) 58​set(Fontconfig_VERSION ${PC_FONTCONFIG_VERSION})
kropUnsubmitted
Not Done

Remove this condition. This is not recommended anymore

krop: Remove this condition. This is not recommended anymore
kropUnsubmitted
Not Done

You need a fallback method for platforms where pkgconfig isn't usable.

fontconfig.h defines FC_MAJOR, FC_MINOR, FC_REVISION

krop: You need a fallback method for platforms where pkgconfig isn't usable. fontconfig.h defines…
30 59​
31 find_path(FONTCONFIG_INCLUDE_DIR fontconfig/fontconfig.h 60​find_path(Fontconfig_INCLUDE_DIRS fontconfig/fontconfig.h
32 PATHS 61​ PATHS
33 ${PC_FONTCONFIG_INCLUDEDIR} ​
34 ${PC_FONTCONFIG_INCLUDE_DIRS} 62​ ${PC_FONTCONFIG_INCLUDE_DIRS}
35 /usr/X11/include 63​ /usr/X11/include
36 ) 64​)
37 65​
38 find_library(FONTCONFIG_LIBRARIES NAMES fontconfig 66​find_library(Fontconfig_LIBRARIES NAMES fontconfig
kropUnsubmitted
Not Done

Delete this if() / endif(). Not needed anymore since ages.

krop: Delete this if() / endif(). Not needed anymore since ages.
39 PATHS 67​ PATHS
40 ${PC_FONTCONFIG_LIBDIR} ​
41 ${PC_FONTCONFIG_LIBRARY_DIRS} 68​ ${PC_FONTCONFIG_LIBRARY_DIRS}
42 ) 69​)
43 70​
44 include(FindPackageHandleStandardArgs) 71​include(FindPackageHandleStandardArgs)
45 find_package_handle_standard_args(Fontconfig DEFAULT_MSG FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR ) 72​find_package_handle_standard_args(Fontconfig DEFAULT_MSG Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS)
kropUnsubmitted
Not Done

Now that you have Fontconfig_VERSION, please use the second form:

find_package_handle_standard_args(Fontconfig
FOUND_VAR Fontconfig_FOUND
REQUIRED_VARS Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS
VERSION_VAR Fontconfig_VERSION)
krop: Now that you have Fontconfig_VERSION, please use the second form: ```…
46 73​
47 mark_as_advanced(FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR) 74​mark_as_advanced(Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS)
48 75​
49endif (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR) 76​if(Fontconfig_FOUND AND NOT TARGET Fontconfig::Fontconfig)
77​ add_library(Fontconfig::Fontconfig UNKNOWN IMPORTED)
78​ set_target_properties(Fontconfig::Fontconfig PROPERTIES
79​ IMPORTED_LOCATION "${Fontconfig_LIBRARIES}"
80​ INTERFACE_INCLUDE_DIRECTORIES "${Fontconfig_INCLUDE_DIRS}"
81​ INTERFACE_COMPILER_DEFINITIONS "${Fontconfig_DEFINITIONS}"
82​ )
83​endif()
50 84​
kropUnsubmitted
Not Done

There's no version check, does it matter?

krop: There's no version check, does it matter?
85​include(FeatureSummary)
kropUnsubmitted
Not Done

endif()

krop: endif()
86​set_package_properties(Fontconfig PROPERTIES
87​ URL "https://www.fontconfig.org/"
88​ DESCRIPTION "Fontconfig is a library for configuring and customizing font access"
89​)
kropUnsubmitted
Not Done

Remove the dot, feature_summary() adds a comma after the description

krop: Remove the dot, feature_summary() adds a comma after the description