Differential D17547 Diff 47471 cmake/modules/FindFontconfig.cmake

Changeset View

Standalone View

View Options

cmake/modules/FindFontconfig.cmake

1# - Try to find the Fontconfig 1​#.rst:
2# Once done this will define 2​# FindFontconfig
3​# --------------
3# 4​#
4# FONTCONFIG_FOUND - system has Fontconfig 5​# Try to find Fontconfig.
5# FONTCONFIG_INCLUDE_DIR - The include directory to use for the fontconfig headers 6​# Once done this will define the following variables:
6# FONTCONFIG_LIBRARIES - Link these to use FONTCONFIG 7​#
7# FONTCONFIG_DEFINITIONS - Compiler switches required for using FONTCONFIG 8​# ``FONTCONFIG_FOUND``
9​# True if Fontconfig is available
10​# ``FONTCONFIG_INCLUDE_DIR``
kropUnsubmitted
Not Done

shall be FONTCONFIG_INCLUDE_DIRS

(https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names)

This link also suggests the variable names shall be exact-case FONTCONFIG_ → Fontconfig_

krop: shall be FONTCONFIG_INCLUDE_DIRS (https://cmake.org/cmake/help/latest/manual/cmake-developer.7.
11​# The include directory to use for the Fontconfig headers
12​# ``FONTCONFIG_LIBRARIES``
13​# The Fontconfig libraries for linking
14​# ``FONTCONFIG_DEFINITIONS``
15​# Compiler switches required for using Fontconfig
16​#
17​# If ``FONTCONFIG_FOUND`` is True, it will also define the following
18​# imported target:
19​#
20​# ``Fontconfig::Fontconfig``
8 21​
22​#=============================================================================
9# Copyright (c) 2006,2007 Laurent Montel, <montel@kde.org> 23​# Copyright (c) 2006,2007 Laurent Montel, <montel@kde.org>
24​# Copyright (c) 2018 Volker Krause <vkrause@kde.org>
10# 25​#
11# Redistribution and use is allowed according to the terms of the BSD license. 26​# Redistribution and use in source and binary forms, with or without
12# For details see the accompanying COPYING-CMAKE-SCRIPTS file. 27​# modification, are permitted provided that the following conditions
13 28​# are met:
29​#
30​# 1. Redistributions of source code must retain the copyright
31​# notice, this list of conditions and the following disclaimer.
32​# 2. Redistributions in binary form must reproduce the copyright
33​# notice, this list of conditions and the following disclaimer in the
34​# documentation and/or other materials provided with the distribution.
35​# 3. The name of the author may not be used to endorse or promote products
36​# derived from this software without specific prior written permission.
37​#
38​# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
39​# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
40​# OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
41​# IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
42​# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
43​# NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
44​# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
45​# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
46​# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
47​# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
48​#=============================================================================
14 49​
15if (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR) 50​if (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR)
16 51​
17 # in cache already 52​ # in cache already
18 set(FONTCONFIG_FOUND TRUE) 53​ set(FONTCONFIG_FOUND TRUE)
kropUnsubmitted
Not Done

Remove this condition. This is not recommended anymore

krop: Remove this condition. This is not recommended anymore
19 54​
kropUnsubmitted
Not Done

You need a fallback method for platforms where pkgconfig isn't usable.

fontconfig.h defines FC_MAJOR, FC_MINOR, FC_REVISION

krop: You need a fallback method for platforms where pkgconfig isn't usable. fontconfig.h defines…
20else (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR) 55​else (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR)
21 56​
22 if (NOT WIN32) 57​ if (NOT WIN32)
kropUnsubmitted
Not Done

Delete this if() / endif(). Not needed anymore since ages.

krop: Delete this if() / endif(). Not needed anymore since ages.
23 # use pkg-config to get the directories and then use these values 58​ # use pkg-config to get the directories and then use these values
24 # in the FIND_PATH() and FIND_LIBRARY() calls 59​ # in the FIND_PATH() and FIND_LIBRARY() calls
25 find_package(PkgConfig) 60​ find_package(PkgConfig)
26 pkg_check_modules(PC_FONTCONFIG QUIET fontconfig) 61​ pkg_check_modules(PC_FONTCONFIG QUIET fontconfig)
27 62​
28 set(FONTCONFIG_DEFINITIONS ${PC_FONTCONFIG_CFLAGS_OTHER}) 63​ set(FONTCONFIG_DEFINITIONS ${PC_FONTCONFIG_CFLAGS_OTHER})
29 endif (NOT WIN32) 64​ endif (NOT WIN32)
30 65​
kropUnsubmitted
Not Done

Now that you have Fontconfig_VERSION, please use the second form:

find_package_handle_standard_args(Fontconfig
FOUND_VAR Fontconfig_FOUND
REQUIRED_VARS Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS
VERSION_VAR Fontconfig_VERSION)
krop: Now that you have Fontconfig_VERSION, please use the second form: ```…
31 find_path(FONTCONFIG_INCLUDE_DIR fontconfig/fontconfig.h 66​ find_path(FONTCONFIG_INCLUDE_DIR fontconfig/fontconfig.h
32 PATHS 67​ PATHS
33 ${PC_FONTCONFIG_INCLUDEDIR} 68​ ${PC_FONTCONFIG_INCLUDEDIR}
34 ${PC_FONTCONFIG_INCLUDE_DIRS} 69​ ${PC_FONTCONFIG_INCLUDE_DIRS}
35 /usr/X11/include 70​ /usr/X11/include
36 ) 71​ )
37 72​
38 find_library(FONTCONFIG_LIBRARIES NAMES fontconfig 73​ find_library(FONTCONFIG_LIBRARIES NAMES fontconfig
39 PATHS 74​ PATHS
40 ${PC_FONTCONFIG_LIBDIR} 75​ ${PC_FONTCONFIG_LIBDIR}
41 ${PC_FONTCONFIG_LIBRARY_DIRS} 76​ ${PC_FONTCONFIG_LIBRARY_DIRS}
42 ) 77​ )
43 78​
kropUnsubmitted
Not Done

There's no version check, does it matter?

krop: There's no version check, does it matter?
44 include(FindPackageHandleStandardArgs) 79​ include(FindPackageHandleStandardArgs)
45 find_package_handle_standard_args(Fontconfig DEFAULT_MSG FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR ) 80​ find_package_handle_standard_args(Fontconfig DEFAULT_MSG FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR )
46 81​
47 mark_as_advanced(FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR) 82​ mark_as_advanced(FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR)
48 83​
49endif (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR) 84​endif (FONTCONFIG_LIBRARIES AND FONTCONFIG_INCLUDE_DIR)
kropUnsubmitted
Not Done

endif()

krop: endif()
50 85​
86​if(FONTCONFIG_FOUND AND NOT TARGET Fontconfig::Fontconfig)
87​ add_library(Fontconfig::Fontconfig UNKNOWN IMPORTED)
88​ set_target_properties(Fontconfig::Fontconfig PROPERTIES
89​ IMPORTED_LOCATION "${FONTCONFIG_LIBRARIES}"
90​ INTERFACE_INCLUDE_DIRECTORIES "${FONTCONFIG_INCLUDE_DIR}"
91​ INTERFACE_COMPILER_DEFINITIONS "${FONTCONFIG_DEFINITIONS}"
92​ )
93​endif()
94​
95​include(FeatureSummary)
96​set_package_properties(Fontconfig PROPERTIES
97​ URL "https://www.fontconfig.org/"
98​ DESCRIPTION "Fontconfig is a library for configuring and customizing font access."
kropUnsubmitted
Not Done

Remove the dot, feature_summary() adds a comma after the description

krop: Remove the dot, feature_summary() adds a comma after the description
99​)