Differential D17483 Diff 47291 qml/virtualkeyboard/main.qml

Changeset View

Standalone View

View Options

qml/virtualkeyboard/main.qml

Show All 14 Lines
15GNU General Public License for more details. 15​GNU General Public License for more details.
16 16​
17You should have received a copy of the GNU General Public License 17​You should have received a copy of the GNU General Public License
18along with this program. If not, see <http://www.gnu.org/licenses/>. 18​along with this program. If not, see <http://www.gnu.org/licenses/>.
19*********************************************************************/ 19​*********************************************************************/
20import QtQuick 2.0 20​import QtQuick 2.0
21import QtQuick.Controls 2.3 21​import QtQuick.Controls 2.3
22import QtQuick.VirtualKeyboard 2.1 22​import QtQuick.VirtualKeyboard 2.1
23​import org.kde.kirigami 2.5 as Kirigami
graesslinUnsubmitted
Not Done

This introduces a new dependency on KWin which we otherwise do not use or need. I think it is overkill to use kirigami for this. Please change.

graesslin: This introduces a new dependency on KWin which we otherwise do not use or need. I think it is…
23 24​
24Item { 25​Item {
25 id: window 26​ id: window
26 property real adjustment: 0 27​ property real adjustment: 0
27 property real adjustmentFactor: 0.0 28​ property real adjustmentFactor: 0.0
28 InputPanel { 29​ InputPanel {
29 id: inputPanel 30​ id: inputPanel
30 objectName: "inputPanel" 31​ objectName: "inputPanel"
31 width: parent.width - parent.width * parent.adjustmentFactor 32​ width: parent.width - parent.width * parent.adjustmentFactor
32 anchors.horizontalCenter: parent.horizontalCenter 33​ anchors.horizontalCenter: parent.horizontalCenter
33 anchors.bottom: parent.bottom 34​ anchors.bottom: parent.bottom
34 } 35​ }
35 ToolButton { 36​ //NOTE: ToolButton for some reasons breaks the virtual keyboard loading on Plasma Mobile
37​ Button {
36 id: resizeButton 38​ id: resizeButton
39​ visible: !Kirigami.Settings.isMobile //don't show on handheld devices
37 flat: true 40​ flat: true
38 display: AbstractButton.IconOnly 41​ display: AbstractButton.IconOnly
39 icon.name: "transform-scale" 42​ icon.name: "transform-scale"
40 icon.color: "white" 43​ icon.color: "white"
41 down: mouseArea.pressed 44​ down: mouseArea.pressed
42 45​
43 anchors { 46​ anchors {
44 right: inputPanel.right 47​ right: inputPanel.right
Show All 18 Lines