Changeset View
Changeset View
Standalone View
Standalone View
kate/katemainwindow.h
Show First 20 Lines • Show All 360 Lines • ▼ Show 20 Line(s) | 302 | public Q_SLOTS: | |||
---|---|---|---|---|---|
361 | */ | 361 | */ | ||
362 | bool closeView(KTextEditor::View *view) | 362 | bool closeView(KTextEditor::View *view) | ||
363 | { | 363 | { | ||
364 | m_viewManager->closeView(view); | 364 | m_viewManager->closeView(view); | ||
365 | return true; | 365 | return true; | ||
366 | } | 366 | } | ||
367 | 367 | | |||
368 | /** | 368 | /** | ||
369 | * Close the split view where the given view is contained. | | |||
370 | * \param view the view. | | |||
371 | * \return true if the split view was closed. | | |||
372 | */ | | |||
373 | bool closeSplitView(KTextEditor::View *view) | | |||
dhaumann: If I am not mistaken: This should not be removed, since it's possibly called via the… | |||||
Ah, good to know. I found this occurrence: frameworks/ktexteditor/src/utils/mainwindow.cpp Christoph also mentioned it. I will revert this change. gregormi: Ah, good to know. I found this occurrence:
frameworks/ktexteditor/src/utils/mainwindow.cpp… | |||||
374 | { | | |||
375 | m_viewManager->closeViewSpace(view); | | |||
376 | return true; | | |||
377 | } | | |||
378 | | ||||
379 | /** | | |||
380 | * @returns true if the two given views share the same split view, | 369 | * @returns true if the two given views share the same split view, | ||
381 | * false otherwise. | 370 | * false otherwise. | ||
382 | */ | 371 | */ | ||
383 | bool viewsInSameSplitView(KTextEditor::View *view1, | 372 | bool viewsInSameSplitView(KTextEditor::View *view1, | ||
384 | KTextEditor::View *view2) | 373 | KTextEditor::View *view2) | ||
385 | { | 374 | { | ||
386 | return m_viewManager->viewsInSameViewSpace(view1, view2); | 375 | return m_viewManager->viewsInSameViewSpace(view1, view2); | ||
387 | } | 376 | } | ||
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines |
If I am not mistaken: This should not be removed, since it's possibly called via the KTextEditor interface: https://github.com/KDE/ktexteditor/blob/master/src/utils/mainwindow.cpp#L152
Note this is a public Q_SLOT, meaning we can invoke this function via a QString trick we use to avoid binary compatibility issues... (not nice, but works!).