Differential D17381 Diff 47027 autotests/settings/macsecsettingtest.cpp

Changeset View

Standalone View

View Options

autotests/settings/macsecsettingtest.cpp

  • This file was added.
1​/*
2​ Copyright 2018 Pranav Gade <pranavgade20@gmail.com>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Lesser General Public
6​ License as published by the Free Software Foundation; either
7​ version 2.1 of the License, or (at your option) version 3, or any
8​ later version accepted by the membership of KDE e.V. (or its
9​ successor approved by the membership of KDE e.V.), which shall
10​ act as a proxy defined in Section 6 of version 3 of the license.
11​
12​ This library is distributed in the hope that it will be useful,
13​ but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ Lesser General Public License for more details.
16​
17​ You should have received a copy of the GNU Lesser General Public
18​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​*/
20​
21​#include "macsecsettingtest.h"
22​
23​#include "settings/macsecsetting.h"
24​
25​#include <libnm/NetworkManager.h>
26​
27​#include <QTest>
28​
29​#if !NM_CHECK_VERSION(1, 6, 0)
30​#define NM_SETTING_MACSEC_PARENT "parent"
jgrulichUnsubmitted
Done

This required version is not true, please verify it properly, I'm not going to do it every time :).

jgrulich: This required version is not true, please verify it properly, I'm not going to do it every time…
pranavgadeAuthorUnsubmitted
Done

I tried to get the version from here:

Is that incorrect?
If so, from where do I check the version?

pranavgade: I tried to get the version from here: {F6459587} Is that incorrect? If so, from where do I…
jgrulichUnsubmitted
Done

That is probably incorrect, the easiest way how to search for this is to clone NetworkManager and checkout to a branch you want to check and grep the define you are looking for.

So for example in my cloned NM, I go to "nm-1-6" branch and do "grep -ir NM_SETTING_MACSEC_MODE" and see that this property is defined there. You should check all NM versions so if it's defined in NM 1.6, I test also whether it is in NM 1.4. I usually start checking from the middle, which means "nm-1-8" branch and go to newer or older based on the result.

jgrulich: That is probably incorrect, the easiest way how to search for this is to clone NetworkManager…
31​#define NM_SETTING_MACSEC_MODE "mode"
32​#define NM_SETTING_MACSEC_ENCRYPT "encrypt"
33​#define NM_SETTING_MACSEC_MKA_CAK "mka-cak"
34​#define NM_SETTING_MACSEC_MKA_CAK_FLAGS "mka-cak-flags"
35​#define NM_SETTING_MACSEC_MKA_CKN "mka-ckn"
36​#define NM_SETTING_MACSEC_PORT "port"
37​#define NM_SETTING_MACSEC_VALIDATION "validation"
38​#endif
39​
40​#if !NM_CHECK_VERSION(1, 12, 0)
41​#define NM_SETTING_MACSEC_SEND_SCI "send-sci"
42​#endif
43​
44​void MacsecSettingTest::testSetting_data()
45​{
46​ QTest::addColumn<bool>("encrypt");
47​ QTest::addColumn<QString>("mkaCak");
48​ QTest::addColumn<QString>("mkaCkn");
49​ QTest::addColumn<qint32>("mode");
50​ QTest::addColumn<QString>("parent");
51​ QTest::addColumn<qint32>("port");
52​ QTest::addColumn<bool>("sendSci");
53​ QTest::addColumn<qint32>("validation");
54​ QTest::addColumn<quint32>("mkaCakFlags");
55​
56​ QTest::newRow("setting1")
57​ << false // encrypt
58​ << QString("abc") // mkaCak
59​ << QString("abc") // mkaCkn
60​ << (qint32) 1 // mode
61​ << QString("abc") // parent
62​ << (qint32) 666 // port
63​ << false // sendSci
64​ << (qint32) 4 // validation
65​ << (quint32) 6; // mkaCakFlags
66​
67​}
68​
69​void MacsecSettingTest::testSetting()
70​{
71​ QFETCH(bool, encrypt);
72​ QFETCH(QString, mkaCak);
73​ QFETCH(QString, mkaCkn);
74​ QFETCH(qint32, mode);
75​ QFETCH(QString, parent);
76​ QFETCH(qint32, port);
77​ QFETCH(bool, sendSci);
78​ QFETCH(qint32, validation);
79​ QFETCH(quint32, mkaCakFlags);
80​
81​ QVariantMap map;
82​
83​ map.insert(QLatin1String(NM_SETTING_MACSEC_ENCRYPT), encrypt);
84​ map.insert(QLatin1String(NM_SETTING_MACSEC_MKA_CAK), mkaCak);
85​ map.insert(QLatin1String(NM_SETTING_MACSEC_MKA_CKN), mkaCkn);
86​ map.insert(QLatin1String(NM_SETTING_MACSEC_MODE), mode);
87​ map.insert(QLatin1String(NM_SETTING_MACSEC_PARENT), parent);
88​ map.insert(QLatin1String(NM_SETTING_MACSEC_PORT), port);
89​ map.insert(QLatin1String(NM_SETTING_MACSEC_SEND_SCI), sendSci);
90​ map.insert(QLatin1String(NM_SETTING_MACSEC_VALIDATION), validation);
91​ map.insert(QLatin1String(NM_SETTING_MACSEC_MKA_CAK_FLAGS), mkaCakFlags);
92​
93​ NetworkManager::MacsecSetting setting;
94​ setting.fromMap(map);
95​
96​ QVariantMap map1 = setting.toMap();
97​
98​ // Will fail if set some default values, because they are skipped in toMap() method
99​ QVariantMap::const_iterator it = map.constBegin();
100​ while (it != map.constEnd()) {
101​ QCOMPARE(it.value(), map1.value(it.key()));
102​ ++it;
103​ }
104​}
105​
106​QTEST_MAIN(MacsecSettingTest)