Differential D17342 Diff 46946 src/settings/teamportsetting.cpp

Changeset View

Standalone View

View Options

src/settings/teamportsetting.cpp

  • This file was added.
1​/*
2​ Copyright Pranav Gade <pranavgade20@gmail.com>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Lesser General Public
6​ License as published by the Free Software Foundation; either
7​ version 2.1 of the License, or (at your option) version 3, or any
8​ later version accepted by the membership of KDE e.V. (or its
9​ successor approved by the membership of KDE e.V.), which shall
10​ act as a proxy defined in Section 6 of version 3 of the license.
11​
12​ This library is distributed in the hope that it will be useful,
13​ but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ Lesser General Public License for more details.
16​
17​ You should have received a copy of the GNU Lesser General Public
18​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​*/
20​
21​#include "teamportsetting.h"
22​#include "teamportsetting_p.h"
23​
24​#include <QDebug>
25​
26​#if !NM_CHECK_VERSION(1, 10, 0)
27​#define NM_SETTING_TEAM_PORT_SETTING_NAME "team-port"
jgrulichUnsubmitted
Done

NM 1.10.0

jgrulich: NM 1.10.0
28​
29​#define NM_SETTING_TEAM_PORT_CONFIG "config"
30​#define NM_SETTING_TEAM_PORT_QUEUE_ID "queue-id"
31​#define NM_SETTING_TEAM_PORT_PRIO "prio"
32​#define NM_SETTING_TEAM_PORT_STICKY "sticky"
33​#define NM_SETTING_TEAM_PORT_LACP_PRIO "lacp-prio"
34​#define NM_SETTING_TEAM_PORT_LACP_KEY "lacp-key"
35​#define NM_SETTING_TEAM_PORT_LINK_WATCHERS "link-watchers"
36​#endif
37​
38​NetworkManager::TeamPortSettingPrivate::TeamPortSettingPrivate()
39​ : name(NM_SETTING_TEAM_PORT_SETTING_NAME)
40​ , lacpKey(0)
41​ , lacpPrio(255)
42​ , prio(0)
43​ , queueId(-1)
44​ , sticky(false)
45​{ }
jgrulichUnsubmitted
Done

Default property initialization is missing.

jgrulich: Default property initialization is missing.
46​
47​NetworkManager::TeamPortSetting::TeamPortSetting()
48​ : Setting(Setting::TeamPort)
49​ , d_ptr(new TeamPortSettingPrivate())
50​{ }
51​
52​NetworkManager::TeamPortSetting::TeamPortSetting(const Ptr &other)
53​ : Setting(other)
54​ , d_ptr(new TeamPortSettingPrivate())
55​{
56​ config(other->config());
57​ lacpKey(other->lacpKey());
58​ lacpPrio(other->lacpPrio());
59​ prio(other->prio());
60​ queueId(other->queueId());
61​ sticky(other->sticky());
62​ setLinkWatchers(other->linkWatchers());
63​}
64​
65​NetworkManager::TeamPortSetting::~TeamPortSetting()
66​{
67​ delete d_ptr;
68​}
69​
70​QString NetworkManager::TeamPortSetting::name() const
71​{
72​ Q_D(const TeamPortSetting);
73​
74​ return d->name;
75​}
76​
77​void NetworkManager::TeamPortSetting::config(QString config)
78​{
79​ Q_D(TeamPortSetting);
80​
81​ d->config = config;
82​}
83​
84​QString NetworkManager::TeamPortSetting::config() const
85​{
86​ Q_D(const TeamPortSetting);
87​
88​ return d->config;
89​}
90​
91​void NetworkManager::TeamPortSetting::lacpKey(qint32 key)
92​{
93​ Q_D(TeamPortSetting);
94​
95​ d->lacpKey = key;
96​}
97​
98​qint32 NetworkManager::TeamPortSetting::lacpKey() const
99​{
100​ Q_D(const TeamPortSetting);
101​
102​ return d->lacpKey;
103​}
104​
105​void NetworkManager::TeamPortSetting::lacpPrio(qint32 priority)
106​{
107​ Q_D(TeamPortSetting);
108​
109​ d->lacpPrio = priority;
110​}
111​
112​qint32 NetworkManager::TeamPortSetting::lacpPrio() const
113​{
114​ Q_D(const TeamPortSetting);
115​
116​ return d->lacpPrio;
117​}
118​
119​void NetworkManager::TeamPortSetting::prio(qint32 prio)
120​{
121​ Q_D(TeamPortSetting);
122​
123​ d->prio = prio;
124​}
125​
126​qint32 NetworkManager::TeamPortSetting::prio() const
127​{
128​ Q_D(const TeamPortSetting);
129​
130​ return d->prio;
131​}
132​
133​void NetworkManager::TeamPortSetting::queueId(qint32 id)
134​{
135​ Q_D(TeamPortSetting);
136​
137​ d->queueId = id;
138​}
139​
140​qint32 NetworkManager::TeamPortSetting::queueId() const
141​{
142​ Q_D(const TeamPortSetting);
143​
144​ return d->queueId;
145​}
146​
147​void NetworkManager::TeamPortSetting::sticky(bool sticky)
148​{
149​ Q_D(TeamPortSetting);
150​
151​ d->sticky = sticky;
152​}
153​
154​bool NetworkManager::TeamPortSetting::sticky() const
155​{
156​ Q_D(const TeamPortSetting);
157​
158​ return d->sticky;
159​}
160​
161​void NetworkManager::TeamPortSetting::setLinkWatchers(const NMVariantMapList &linkWatchers)
162​{
163​ Q_D(TeamPortSetting);
164​
165​ d->linkWatchers = linkWatchers;
166​}
167​
168​NMVariantMapList NetworkManager::TeamPortSetting::linkWatchers() const
169​{
170​ Q_D(const TeamPortSetting);
171​
172​ return d->linkWatchers;
173​}
174​
175​
176​void NetworkManager::TeamPortSetting::fromMap(const QVariantMap &setting)
177​{
178​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_CONFIG))) {
179​ config(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_CONFIG)).toString());
180​ }
181​
182​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_LACP_KEY))) {
183​ lacpKey(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_LACP_KEY)).toUInt());
184​ }
185​
186​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_LACP_PRIO))) {
187​ lacpPrio(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_LACP_PRIO)).toUInt());
188​ }
189​
190​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_PRIO))) {
191​ prio(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_PRIO)).toUInt());
192​ }
193​
194​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_QUEUE_ID))) {
195​ queueId(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_QUEUE_ID)).toUInt());
196​ }
197​
198​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_STICKY))) {
199​ sticky(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_STICKY)).toBool());
200​ }
201​
202​ if (setting.contains(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS))) {
203​ setLinkWatchers(qdbus_cast<NMVariantMapList>(setting.value(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS))));
204​ }
205​}
206​
207​QVariantMap NetworkManager::TeamPortSetting::toMap() const
208​{
209​ QVariantMap setting;
210​
211​ if (!config().isEmpty()) {
jgrulichUnsubmitted
Done

0

jgrulich: > 0
212​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_CONFIG), config());
213​ }
214​
215​ if (lacpKey() > 0) {
jgrulichUnsubmitted
Done

!= 255

jgrulich: != 255
216​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_LACP_KEY), lacpKey());
217​ }
218​
219​ if (lacpPrio() != 255) {
jgrulichUnsubmitted
Done

0

jgrulich: > 0
220​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_LACP_PRIO), lacpPrio());
221​ }
222​
223​ if (prio() > 0) {
224​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_PRIO), prio());
225​ }
226​
227​ if (queueId() >= 0) {
jgrulichUnsubmitted
Done

This is wrong, default value is FALSE, which means you would skip this property if it's set.

jgrulich: This is wrong, default value is FALSE, which means you would skip this property if it's set.
228​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_QUEUE_ID), queueId());
229​ }
230​
231​ if (sticky()) {
232​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_STICKY), sticky());
233​ }
234​
235​ if (!linkWatchers().empty()) {
236​ setting.insert(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS), QVariant::fromValue(linkWatchers()));
237​ }
238​
239​ return setting;
240​}
241​
242​QDebug NetworkManager::operator <<(QDebug dbg, const NetworkManager::TeamPortSetting &setting)
243​{
244​ dbg.nospace() << "type: " << setting.typeAsString(setting.type()) << '\n';
245​ dbg.nospace() << "initialized: " << !setting.isNull() << '\n';
246​
247​ dbg.nospace() << NM_SETTING_TEAM_PORT_CONFIG << ": " << setting.config() << '\n';
248​ dbg.nospace() << NM_SETTING_TEAM_PORT_LACP_KEY << ": " << setting.lacpKey() << '\n';
249​ dbg.nospace() << NM_SETTING_TEAM_PORT_LACP_PRIO << ": " << setting.lacpPrio() << '\n';
250​ dbg.nospace() << NM_SETTING_TEAM_PORT_PRIO << ": " << setting.prio() << '\n';
251​ dbg.nospace() << NM_SETTING_TEAM_PORT_QUEUE_ID << ": " << setting.queueId() << '\n';
252​ dbg.nospace() << NM_SETTING_TEAM_PORT_STICKY << ": " << setting.sticky() << '\n';
253​
254​ dbg.nospace() << NM_SETTING_TEAM_PORT_LINK_WATCHERS << ": " << '\n';
255​ Q_FOREACH (const QVariantMap & linkWatcher, setting.linkWatchers()) {
256​ QVariantMap::const_iterator i = linkWatcher.constBegin();
257​ while (i != linkWatcher.constEnd()) {
258​ dbg.nospace() << i.key() << ": " << i.value() << '\n';
259​ }
260​ }
261​
262​ return dbg.maybeSpace();
263​}