Differential D17355 Diff 46918 src/declarativeimports/plasmastyle/ButtonStyle.qml

Changeset View

Standalone View

View Options

src/declarativeimports/plasmastyle/ButtonStyle.qml

Context not available.
37 property int minimumWidth 37​ property int minimumWidth
38 property int minimumHeight 38​ property int minimumHeight
39 39​
40 label: RowLayout { 40​ label: Item {
41 spacing: units.smallSpacing 41​ implicitWidth: row.implicitWidth
apolUnsubmitted
Done

This looks wrong, a RowLayout inside another one?

apol: This looks wrong, a RowLayout inside another one?
davidedmundsonUnsubmitted
Not Done

why this Item wrapper

davidedmundson: why this Item wrapper
42 42​ RowLayout {
43 property real minimumWidth: implicitWidth + style.padding.left + style.padding.right 43​ id: row
44 onMinimumWidthChanged: { 44​ anchors.fill: parent
45 if (control.minimumWidth !== undefined) { 45​ spacing: units.smallSpacing
46 style.minimumWidth = minimumWidth; 46​
47 control.minimumWidth = minimumWidth; 47​ property real minimumWidth: implicitWidth + style.padding.left + style.padding.right
48​ onMinimumWidthChanged: {
49​ if (control.minimumWidth !== undefined) {
50​ style.minimumWidth = minimumWidth;
51​ control.minimumWidth = minimumWidth;
52​ }
48 } 53​ }
49 } ​
50 54​
51 property real minimumHeight: implicitHeight + style.padding.top + style.padding.bottom 55​ property real minimumHeight: implicitHeight + style.padding.top + style.padding.bottom
52 onMinimumHeightChanged: { 56​ onMinimumHeightChanged: {
53 if (control.minimumHeight !== undefined) { 57​ if (control.minimumHeight !== undefined) {
54 style.minimumHeight = minimumHeight; 58​ style.minimumHeight = minimumHeight;
55 control.minimumHeight = minimumHeight; 59​ control.minimumHeight = minimumHeight;
60​ }
56 } 61​ }
57 } ​
58 62​
59 PlasmaCore.IconItem { 63​ PlasmaCore.IconItem {
60 id: icon 64​ id: icon
61 source: control.iconName || control.iconSource 65​ source: control.iconName || control.iconSource
62 Layout.minimumWidth: valid ? units.iconSizes.tiny : 0 66​ Layout.minimumWidth: valid ? units.iconSizes.tiny : 0
63 Layout.preferredWidth: valid ? units.iconSizes.small : 0 67​ Layout.preferredWidth: valid ? units.iconSizes.small : 0
64 visible: valid 68​ visible: valid
65 Layout.minimumHeight: Layout.minimumWidth 69​ Layout.minimumHeight: Layout.minimumWidth
66 Layout.preferredHeight: Layout.preferredWidth 70​ Layout.preferredHeight: Layout.preferredWidth
67 Layout.alignment: Qt.AlignHCenter | Qt.AlignVCenter 71​ Layout.alignment: Qt.AlignRight | Qt.AlignVCenter
68 active: control.hovered 72​ active: control.hovered
69 colorGroup: PlasmaCore.Theme.ButtonColorGroup 73​ colorGroup: PlasmaCore.Theme.ButtonColorGroup
70 } 74​ }
71 75​
72 PlasmaComponents.Label { 76​ PlasmaComponents.Label {
73 id: label 77​ id: label
74 Layout.fillHeight: true 78​ Layout.fillHeight: true
75 text: Util.stylizeEscapedMnemonics(Util.toHtmlEscaped(control.text)) 79​ text: Util.stylizeEscapedMnemonics(Util.toHtmlEscaped(control.text))
76 textFormat: Text.StyledText 80​ textFormat: Text.StyledText
77 height: undefined 81​ height: undefined
78 font: control.font || theme.defaultFont 82​ font: control.font || theme.defaultFont
79 visible: control.text != "" 83​ visible: control.text != ""
80 Layout.fillWidth: true 84​ Layout.fillWidth: false
81 color: theme.buttonTextColor 85​ color: theme.buttonTextColor
82 horizontalAlignment: icon.valid ? Text.AlignLeft : Text.AlignHCenter 86​ Layout.alignment: icon.valid ? Qt.AlignLeft : Qt.AlignHCenter | Qt.AlignVCenter
83 verticalAlignment: Text.AlignVCenter 87​ horizontalAlignment: Text.AlignLeft
84 elide: Text.ElideRight 88​ verticalAlignment: Text.AlignVCenter
85 } 89​ elide: Text.ElideRight
90​ }
86 91​
87 PlasmaExtras.ConditionalLoader { 92​ PlasmaExtras.ConditionalLoader {
88 id: arrow 93​ id: arrow
89 when: control.menu !== null 94​ when: control.menu !== null
90 visible: when 95​ visible: when
91 Layout.minimumWidth: units.iconSizes.small 96​ Layout.minimumWidth: units.iconSizes.small
92 Layout.maximumWidth: Layout.minimumWidth 97​ Layout.maximumWidth: Layout.minimumWidth
93 Layout.alignment: Qt.AlignVCenter 98​ Layout.alignment: Qt.AlignRight | Qt.AlignVCenter
94 height: width 99​ Layout.minimumHeight: Layout.minimumWidth
95 100​
96 source: Component { 101​ source: Component {
97 PlasmaCore.SvgItem { 102​ PlasmaCore.SvgItem {
98 visible: control.menu !== null 103​ visible: control.menu !== null
99 anchors.fill: parent 104​ anchors.fill: parent
100 svg: PlasmaCore.Svg { 105​ svg: PlasmaCore.Svg {
101 imagePath: "widgets/arrows" 106​ imagePath: "widgets/arrows"
102 colorGroup: PlasmaCore.Theme.ButtonColorGroup 107​ colorGroup: PlasmaCore.Theme.ButtonColorGroup
108​ }
109​ elementId: "down-arrow"
103 } 110​ }
104 elementId: "down-arrow" ​
105 } 111​ }
106 } 112​ }
107 } 113​ }
Context not available.