Changeset View
Changeset View
Standalone View
Standalone View
addons/project/kateprojectcodeanalysistool.h
| Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Line(s) | 43 | public: | |||
|---|---|---|---|---|---|
| 50 | virtual void setProject(KateProject *project); | 50 | virtual void setProject(KateProject *project); | ||
| 51 | 51 | | |||
| 52 | /** | 52 | /** | ||
| 53 | * @return tool descriptive name | 53 | * @return tool descriptive name | ||
| 54 | */ | 54 | */ | ||
| 55 | virtual QString name() = 0; | 55 | virtual QString name() = 0; | ||
| 56 | 56 | | |||
| 57 | /** | 57 | /** | ||
| 58 | * @returns a string containing the file extensions this | ||||
| 59 | * tool should be run, separated by '|', | ||||
| 60 | * e.g. "cpp|cxx" | ||||
| 61 | */ | ||||
| 62 | virtual QString fileExtensions() = 0; | ||||
dhaumann: Why not return a QStringList? The current version just forces parsing in other places. :)
... | |||||
gregormi: I added a comment about this. | |||||
| 63 | | ||||
| 64 | /** | ||||
| 58 | * filter relevant files | 65 | * filter relevant files | ||
| 59 | * @param files set of files in project | 66 | * @param files set of files in project | ||
| 60 | * @return relevant files that can be analyzed | 67 | * @return relevant files that can be analyzed | ||
| 61 | */ | 68 | */ | ||
| 62 | virtual QStringList filter(const QStringList &files) = 0; | 69 | virtual QStringList filter(const QStringList &files) = 0; | ||
| 63 | 70 | | |||
| 64 | /** | 71 | /** | ||
| 65 | * @return tool path | 72 | * @return tool path | ||
| Show All 29 Lines | |||||
Why not return a QStringList? The current version just forces parsing in other places. :)
...
Later: ok, now I see it's used in the regular expression. Still, I don't like how an implementation detail in a specific location (here: regex later) imposes design decisions here. And also in the UI, a label would rather be comma separated instead of | separated.