Differential D17278 Diff 46602 plugins/meson/settings/mesonconfigpage.cpp

Changeset View

Standalone View

View Options

plugins/meson/settings/mesonconfigpage.cpp

  • This file was added.
1​/* This file is part of KDevelop
2​ Copyright 2018 Daniel Mensinger <daniel@mensinger-ka.de>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License as published by the Free Software Foundation; either
7​ version 2 of the License, or (at your option) any later version.
8​
9​ This library is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ Library General Public License for more details.
13​
14​ You should have received a copy of the GNU Library General Public License
15​ along with this library; see the file COPYING.LIB. If not, write to
16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ Boston, MA 02110-1301, USA.
18​*/
19​
20​#include "mesonconfigpage.h"
21​#include "mesonbuilder.h"
22​#include "mesonjob.h"
23​#include "mesonmanager.h"
24​#include "mesonnewbuilddir.h"
25​#include "ui_mesonconfigpage.h"
26​#include <QIcon>
27​#include <debug.h>
28​#include <executecompositejob.h>
29​#include <interfaces/iplugin.h>
30​#include <interfaces/iproject.h>
31​
32​using namespace KDevelop;
33​
34​MesonConfigPage::MesonConfigPage(IPlugin* plugin, IProject* project, QWidget* parent)
35​ : ConfigPage(plugin, nullptr, parent)
36​ , m_project(project)
37​{
38​ Q_ASSERT(project); // Catch errors early
39​ MesonManager* mgr = dynamic_cast<MesonManager*>(m_project->buildSystemManager());
40​ Q_ASSERT(mgr); // This dialog only works with the MesonManager
41​
42​ m_ui = new Ui::MesonConfigPage;
43​ m_ui->setupUi(this);
44​ m_ui->advanced->setSupportedBackends(mgr->supportedMesonBackends());
45​
46​ m_config = Meson::getMesonConfig(m_project);
47​ if (m_config.buildDirs.isEmpty()) {
48​ m_config.currentIndex = -1;
49​ reset();
50​ return;
51​ } else if (m_config.currentIndex < 0 || m_config.currentIndex >= m_config.buildDirs.size()) {
52​ m_config.currentIndex = 0;
53​ }
54​
55​ QStringList buildPathList;
56​ for (auto& i : m_config.buildDirs) {
57​ buildPathList << i.buildDir.toLocalFile();
58​ }
59​
60​ m_ui->i_buildDirs->blockSignals(true);
61​ m_ui->i_buildDirs->clear();
62​ m_ui->i_buildDirs->addItems(buildPathList);
63​ m_ui->i_buildDirs->setCurrentIndex(m_config.currentIndex);
64​ m_ui->i_buildDirs->blockSignals(false);
65​
66​ reset();
67​}
68​
69​void MesonConfigPage::writeConfig()
70​{
71​ qCDebug(KDEV_Meson) << "Writing config to file";
72​ if (m_config.currentIndex >= 0) {
73​ m_config.buildDirs[m_config.currentIndex] = m_current;
74​ }
75​
76​ if (m_config.buildDirs.isEmpty()) {
77​ m_config.currentIndex = -1;
78​ } else if (m_config.currentIndex < 0 || m_config.currentIndex >= m_config.buildDirs.size()) {
79​ m_config.currentIndex = 0;
80​ }
81​ Meson::writeMesonConfig(m_project, m_config);
82​}
83​
84​void MesonConfigPage::apply()
85​{
86​ qCDebug(KDEV_Meson) << "Applying meson config for build dir " << m_current.buildDir;
87​ readUI();
88​ writeConfig();
89​
90​ if (m_config.currentIndex >= 0) {
91​ QStringList args;
92​ QList<KJob*> joblist = {
93​ new MesonJob(m_current, m_project, MesonJob::SET_CONFIG, args, nullptr),
94​ new MesonJob(m_current, m_project, MesonJob::RE_CONFIGURE, args, nullptr),
95​ };
96​ KJob* job = new ExecuteCompositeJob(nullptr, joblist);
97​ job->start();
98​ }
99​}
100​
101​void MesonConfigPage::defaults()
102​{
103​ qCDebug(KDEV_Meson) << "Restoring build dir " << m_current.buildDir << " to it's default values";
104​ MesonManager* mgr = dynamic_cast<MesonManager*>(m_project->buildSystemManager());
105​ Q_ASSERT(mgr);
106​
107​ m_current.mesonArgs.clear();
108​ m_current.mesonBackend = mgr->defaultMesonBackend();
109​ m_current.mesonExecutable = mgr->findMeson();
110​
111​ updateUI();
112​}
113​
114​void MesonConfigPage::reset()
115​{
116​ if (m_config.buildDirs.isEmpty()) {
117​ m_config.currentIndex = -1;
118​ m_ui->i_buildDirs->clear();
119​ setWidgetsDisabled(true);
120​ return;
121​ } else if (m_config.currentIndex < 0 || m_config.currentIndex >= m_config.buildDirs.size()) {
122​ m_config.currentIndex = 0;
123​ m_ui->i_buildDirs->blockSignals(true);
124​ m_ui->i_buildDirs->setCurrentIndex(m_config.currentIndex);
125​ m_ui->i_buildDirs->blockSignals(false);
126​ }
127​
128​ setWidgetsDisabled(false);
129​ qCDebug(KDEV_Meson) << "Resetting changes for build dir " << m_current.buildDir;
130​
131​ m_current = m_config.buildDirs[m_config.currentIndex];
132​ updateUI();
133​}
134​
135​void MesonConfigPage::updateUI()
136​{
137​ m_ui->i_buildType->setCurrentIndex(1);
138​
139​ QStringList buildTypes = { QStringLiteral("plain"), QStringLiteral("debug"), QStringLiteral("debugoptimized"),
140​ QStringLiteral("release"), QStringLiteral("minsize"), QStringLiteral("custom") };
141​
142​ m_ui->i_buildType->clear();
143​ m_ui->i_buildType->addItems(buildTypes);
144​ m_ui->i_buildType->setCurrentIndex(std::max(0, buildTypes.indexOf(m_current.buildType)));
145​
146​ m_ui->i_installPrefix->setUrl(m_current.installPrefix.toUrl());
147​
148​ auto aConf = m_ui->advanced->getConfig();
149​ aConf.args = m_current.mesonArgs;
150​ aConf.backend = m_current.mesonBackend;
151​ aConf.meson = m_current.mesonExecutable;
152​ m_ui->advanced->setConfig(aConf);
153​}
154​
155​void MesonConfigPage::readUI()
156​{
157​ qCDebug(KDEV_Meson) << "Reading current build configuration from the UI " << m_current.buildDir.toLocalFile();
158​ m_current.installPrefix = Path(m_ui->i_installPrefix->url());
159​ m_current.buildType = m_ui->i_buildType->currentText();
160​
161​ auto aConf = m_ui->advanced->getConfig();
162​ m_current.mesonArgs = aConf.args;
163​ m_current.mesonBackend = aConf.backend;
164​ m_current.mesonExecutable = aConf.meson;
165​}
166​
167​void MesonConfigPage::setWidgetsDisabled(bool disabled)
168​{
169​ m_ui->advanced->setDisabled(disabled);
170​ m_ui->c_01_basic->setDisabled(disabled);
171​ m_ui->c_02_buildConfig->setDisabled(disabled);
172​ m_ui->b_rmDir->setDisabled(disabled);
173​}
174​
175​void MesonConfigPage::addBuildDir()
176​{
177​ qCDebug(KDEV_Meson) << "Adding build directory";
178​ MesonManager* mgr = dynamic_cast<MesonManager*>(m_project->buildSystemManager());
179​ MesonBuilder* bld = dynamic_cast<MesonBuilder*>(mgr->builder());
rizzitelloUnsubmitted
Not Done

auto

rizzitello: auto
dmensingerAuthorUnsubmitted
Not Done

I don't know why you would use auto here. Should I use auto for every dynamic_cast?

dmensinger: I don't know why you would use `auto` here. Should I use `auto` for every dynamic_cast?
rizzitelloUnsubmitted
Not Done

In these cases the type is obvious. Why not use auto?

rizzitello: In these cases the type is obvious. Why not use auto?
dmensingerAuthorUnsubmitted
Not Done

Then I guess it is personal preference :)
I like it better this way for (relatively) short type names without templates and :: (outside C++11 for loops).
If you are OK with it, I would like to keep the types the way they are now.

dmensinger: Then I guess it is personal preference :) I like it better this way for (relatively) short type…
rizzitelloUnsubmitted
Not Done

It's okay with me if you keep the types how they are now.

rizzitello: It's okay with me if you keep the types how they are now.
180​ Q_ASSERT(mgr);
181​ Q_ASSERT(bld);
182​ MesonNewBuildDir newBD(m_project);
183​
184​ if (!newBD.exec() || !newBD.isConfigValid()) {
185​ qCDebug(KDEV_Meson) << "Failed to create a new build directory";
186​ return;
187​ }
188​
189​ m_current = newBD.currentConfig();
190​ m_config.currentIndex = m_config.addBuildDir(m_current);
191​ m_ui->i_buildDirs->blockSignals(true);
192​ m_ui->i_buildDirs->addItem(m_current.buildDir.toLocalFile());
193​ m_ui->i_buildDirs->setCurrentIndex(m_config.currentIndex);
194​ m_ui->i_buildDirs->blockSignals(false);
195​
196​ setWidgetsDisabled(true);
197​ writeConfig();
198​ KJob* job = bld->configure(m_project);
199​ connect(job, &KJob::result, this, [this]() { reset(); });
200​ job->start();
201​}
202​
203​void MesonConfigPage::removeBuildDir()
204​{
205​ qCDebug(KDEV_Meson) << "Removing current build directory";
206​ m_ui->i_buildDirs->blockSignals(true);
207​ m_ui->i_buildDirs->removeItem(m_config.currentIndex);
208​ m_config.removeBuildDir(m_config.currentIndex);
209​ if (m_config.buildDirs.isEmpty()) {
210​ m_config.currentIndex = -1;
211​ } else if (m_config.currentIndex < 0 || m_config.currentIndex >= m_config.buildDirs.size()) {
212​ m_config.currentIndex = 0;
213​ }
214​ m_ui->i_buildDirs->setCurrentIndex(m_config.currentIndex);
215​ m_ui->i_buildDirs->blockSignals(false);
216​ reset();
217​ writeConfig();
218​}
219​
220​void MesonConfigPage::changeBuildDirIndex(int index)
221​{
222​ if (index == m_config.currentIndex || m_config.buildDirs.isEmpty()) {
223​ return;
224​ }
225​
226​ if (index < 0 || index >= m_config.buildDirs.size()) {
227​ qCWarning(KDEV_Meson) << "Invalid build dir index " << index;
228​ return;
229​ }
230​
231​ qCDebug(KDEV_Meson) << "Changing build directory to index " << index;
232​
233​ m_config.currentIndex = index;
234​ reset();
235​ writeConfig();
236​}
237​
238​void MesonConfigPage::emitChanged()
239​{
240​ emit changed();
241​}
242​
243​QString MesonConfigPage::name() const
244​{
245​ return i18n("Meson");
246​}
247​
248​QString MesonConfigPage::fullName() const
249​{
250​ return i18n("Meson project configuration");
251​}
252​
253​QIcon MesonConfigPage::icon() const
254​{
255​ return QIcon::fromTheme(QStringLiteral("meson"));
256​}